All of lore.kernel.org
 help / color / mirror / Atom feed
From: santosh shilimkar <santosh.shilimkar@oracle.com>
To: Christoph Hellwig <hch@infradead.org>, Tom Talpey <tom@talpey.com>
Cc: Chuck Lever <chuck.lever@oracle.com>,
	linux-rdma@vger.kernel.org, linux-nfs@vger.kernel.org,
	Sagi Grimberg <sagig@mellanox.com>
Subject: Re: Future of FMR support, was: Re: [PATCH v1 5/9] xprtrdma: Add ro_unmap_sync method for FMR
Date: Tue, 24 Nov 2015 13:54:02 -0800	[thread overview]
Message-ID: <5654DC7A.7080807@oracle.com> (raw)
In-Reply-To: <20151124065225.GB29141@infradead.org>

Hi Christoph,

On 11/23/2015 10:52 PM, Christoph Hellwig wrote:
> On Mon, Nov 23, 2015 at 07:57:42PM -0500, Tom Talpey wrote:
>> On 11/23/2015 5:14 PM, Chuck Lever wrote:
>>> FMR's ro_unmap method is already synchronous because ib_unmap_fmr()
>>> is a synchronous verb. However, some improvements can be made here.
>>
>> I thought FMR support was about to be removed in the core.
>
> Seems like everyone would love to kill it, but no one dares to do
> it just yet.  Reasons to keep FMRs:
>
>   - mthca doesn't support FRs but haven't been staged out
>   - RDS only supports FRMs for the IB transports (it does support FRs for
>     an entirely separate iWarp transports.  I'd love to know why we can't
>     just use that iWarp transport for IB as well).
>   - mlx4 hardware might be slower with FRs than FRMs (Or mentioned this
>     in reply to the iSER remote invalidation series).
>
> So at lest for 4.5 we're unlikely to be able to get rid of it alone
> due to the RDS issue.  We'll then need performance numbers for mlx4,
> and figure out how much we care about mthca.
>
As already indicated to Sagi [1], RDS IB FR support is work in
progress and I was hoping to get it ready for 4.5. There are few
issues we found with one of the HCA and hence the progress
slowed down. Looking at where we are, 4.6 merge window seems
to be realistic for me to get RDS FR support.

Now on the iWARP transport itself, it has been bit tough because
of lack of hardware to tests. I have been requesting test(s) in
previous RDS patches and haven't seen any interest so far. If
this continues to be the trend, I might as well get rid of
RDS iWARP support after couple of merge windows.

Regards,
Santosh
[1] http://www.spinics.net/lists/linux-nfs/msg53909.html

WARNING: multiple messages have this Message-ID (diff)
From: santosh shilimkar <santosh.shilimkar-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
	Tom Talpey <tom-CLs1Zie5N5HQT0dZR+AlfA@public.gmane.org>
Cc: Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Sagi Grimberg <sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: Re: Future of FMR support, was: Re: [PATCH v1 5/9] xprtrdma: Add ro_unmap_sync method for FMR
Date: Tue, 24 Nov 2015 13:54:02 -0800	[thread overview]
Message-ID: <5654DC7A.7080807@oracle.com> (raw)
In-Reply-To: <20151124065225.GB29141-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>

Hi Christoph,

On 11/23/2015 10:52 PM, Christoph Hellwig wrote:
> On Mon, Nov 23, 2015 at 07:57:42PM -0500, Tom Talpey wrote:
>> On 11/23/2015 5:14 PM, Chuck Lever wrote:
>>> FMR's ro_unmap method is already synchronous because ib_unmap_fmr()
>>> is a synchronous verb. However, some improvements can be made here.
>>
>> I thought FMR support was about to be removed in the core.
>
> Seems like everyone would love to kill it, but no one dares to do
> it just yet.  Reasons to keep FMRs:
>
>   - mthca doesn't support FRs but haven't been staged out
>   - RDS only supports FRMs for the IB transports (it does support FRs for
>     an entirely separate iWarp transports.  I'd love to know why we can't
>     just use that iWarp transport for IB as well).
>   - mlx4 hardware might be slower with FRs than FRMs (Or mentioned this
>     in reply to the iSER remote invalidation series).
>
> So at lest for 4.5 we're unlikely to be able to get rid of it alone
> due to the RDS issue.  We'll then need performance numbers for mlx4,
> and figure out how much we care about mthca.
>
As already indicated to Sagi [1], RDS IB FR support is work in
progress and I was hoping to get it ready for 4.5. There are few
issues we found with one of the HCA and hence the progress
slowed down. Looking at where we are, 4.6 merge window seems
to be realistic for me to get RDS FR support.

Now on the iWARP transport itself, it has been bit tough because
of lack of hardware to tests. I have been requesting test(s) in
previous RDS patches and haven't seen any interest so far. If
this continues to be the trend, I might as well get rid of
RDS iWARP support after couple of merge windows.

Regards,
Santosh
[1] http://www.spinics.net/lists/linux-nfs/msg53909.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2015-11-24 21:54 UTC|newest]

Thread overview: 78+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-23 22:13 [PATCH v1 0/9] NFS/RDMA client patches for 4.5 Chuck Lever
2015-11-23 22:13 ` Chuck Lever
2015-11-23 22:13 ` [PATCH v1 1/9] xprtrdma: Add a safety margin for receive buffers Chuck Lever
2015-11-23 22:13   ` Chuck Lever
2015-11-24  0:55   ` Tom Talpey
2015-11-24  0:55     ` Tom Talpey
2015-11-24  1:16     ` Chuck Lever
2015-11-24  1:16       ` Chuck Lever
2015-11-24  1:22       ` Tom Talpey
2015-11-24  1:22         ` Tom Talpey
2015-11-24  1:44         ` Chuck Lever
2015-11-24  1:44           ` Chuck Lever
2015-11-23 22:14 ` [PATCH v1 2/9] xprtrdma: Move struct ib_send_wr off the stack Chuck Lever
2015-11-23 22:14   ` Chuck Lever
2015-11-23 22:14 ` [PATCH v1 3/9] xprtrdma: Introduce ro_unmap_sync method Chuck Lever
2015-11-23 22:14   ` Chuck Lever
2015-11-24  6:45   ` Christoph Hellwig
2015-11-24  6:45     ` Christoph Hellwig
2015-11-24  7:28     ` Jason Gunthorpe
2015-11-24  7:28       ` Jason Gunthorpe
2015-11-24 10:59     ` Sagi Grimberg
2015-11-24 10:59       ` Sagi Grimberg
2015-11-24 13:43       ` Tom Talpey
2015-11-24 13:43         ` Tom Talpey
2015-11-24 14:40         ` Sagi Grimberg
2015-11-24 14:40           ` Sagi Grimberg
2015-11-24 14:39       ` Chuck Lever
2015-11-24 14:39         ` Chuck Lever
2015-11-24 14:44         ` Sagi Grimberg
2015-11-24 14:44           ` Sagi Grimberg
2015-11-24 15:20           ` Chuck Lever
2015-11-24 15:20             ` Chuck Lever
2015-11-24 18:57         ` Jason Gunthorpe
2015-11-24 18:57           ` Jason Gunthorpe
2015-11-23 22:14 ` [PATCH v1 4/9] xprtrdma: Add ro_unmap_sync method for FRWR Chuck Lever
2015-11-23 22:14   ` Chuck Lever
2015-11-23 22:14 ` [PATCH v1 5/9] xprtrdma: Add ro_unmap_sync method for FMR Chuck Lever
2015-11-23 22:14   ` Chuck Lever
2015-11-24  0:57   ` Tom Talpey
2015-11-24  0:57     ` Tom Talpey
2015-11-24  6:52     ` Future of FMR support, was: " Christoph Hellwig
2015-11-24  6:52       ` Christoph Hellwig
2015-11-24  7:12       ` Jason Gunthorpe
2015-11-24  7:12         ` Jason Gunthorpe
2015-12-01 15:33         ` Chuck Lever
2015-12-01 15:33           ` Chuck Lever
2015-12-02 12:27           ` Christoph Hellwig
2015-12-02 12:27             ` Christoph Hellwig
2015-11-24 12:36       ` Tom Talpey
2015-11-24 12:36         ` Tom Talpey
2015-11-24 21:54       ` santosh shilimkar [this message]
2015-11-24 21:54         ` santosh shilimkar
2015-11-25  9:00         ` Christoph Hellwig
2015-11-25  9:00           ` Christoph Hellwig
2015-11-25 17:09           ` santosh shilimkar
2015-11-25 17:09             ` santosh shilimkar
2015-11-25 18:22             ` Or Gerlitz
2015-11-25 18:22               ` Or Gerlitz
2015-11-25 19:17               ` santosh shilimkar
2015-11-25 19:17                 ` santosh shilimkar
2015-11-25 19:28             ` Jason Gunthorpe
2015-11-25 19:28               ` Jason Gunthorpe
2015-11-26 10:01               ` Sagi Grimberg
2015-11-26 10:01                 ` Sagi Grimberg
2015-11-23 22:14 ` [PATCH v1 6/9] xprtrdma: Add ro_unmap_sync method for all-physical registration Chuck Lever
2015-11-23 22:14   ` Chuck Lever
2015-11-23 22:14 ` [PATCH v1 7/9] SUNRPC: Introduct xprt_commit_rqst() Chuck Lever
2015-11-23 22:14   ` Chuck Lever
2015-11-24 19:54   ` Anna Schumaker
2015-11-24 19:54     ` Anna Schumaker
2015-11-24 19:56     ` Chuck Lever
2015-11-24 19:56       ` Chuck Lever
2015-11-23 22:14 ` [PATCH v1 8/9] xprtrdma: Invalidate in the RPC reply handler Chuck Lever
2015-11-23 22:14   ` Chuck Lever
2015-11-24  1:01   ` Tom Talpey
2015-11-24  1:01     ` Tom Talpey
2015-11-23 22:15 ` [PATCH v1 9/9] xprtrdma: Revert commit e7104a2a9606 ('xprtrdma: Cap req_cqinit') Chuck Lever
2015-11-23 22:15   ` Chuck Lever

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5654DC7A.7080807@oracle.com \
    --to=santosh.shilimkar@oracle.com \
    --cc=chuck.lever@oracle.com \
    --cc=hch@infradead.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=sagig@mellanox.com \
    --cc=tom@talpey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.