All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Arnd Bergmann <arnd@arndb.de>, Andy Gross <agross@codeaurora.org>
Subject: Re: [PATCH 1/3] clocksource: defbool CLKSRC_QCOM=y on ARCH_QCOM and make it visible
Date: Wed, 25 Nov 2015 11:10:49 +0100	[thread overview]
Message-ID: <56558929.6090403@linaro.org> (raw)
In-Reply-To: <1448413710-8101-2-git-send-email-sboyd@codeaurora.org>

On 11/25/2015 02:08 AM, Stephen Boyd wrote:
> We want to remove the ARCH_MSM* configs in mach-qcom/Kconfig
> because they are mostly proxy configs for selecting the right
> clocksource driver. Therefore, make CLKSRC_QCOM default to the
> value of ARCH_QCOM, but also make it visible if ARCH_QCOM=y so
> that we can turn it off when we don't want it.

I have been removing the ARCH dependencies in the Kconfig file.

Why do you have to turn it off manually ?

> Suggested-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
>   drivers/clocksource/Kconfig | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index b423785d6afc..7a5ffaa3e490 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -279,9 +279,10 @@ config EM_TIMER_STI
>   	  such as EMEV2 from former NEC Electronics.
>
>   config CLKSRC_QCOM
> -	bool "Qualcomm MSM timer" if COMPILE_TEST
> +	bool "Qualcomm MSM timer" if ARCH_QCOM || COMPILE_TEST
>   	depends on ARM
>   	select CLKSRC_OF
> +	defbool ARCH_QCOM
>   	help
>   	  This enables the clocksource and the per CPU clockevent driver for the
>   	  Qualcomm SoCs.
>


-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

WARNING: multiple messages have this Message-ID (diff)
From: daniel.lezcano@linaro.org (Daniel Lezcano)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] clocksource: defbool CLKSRC_QCOM=y on ARCH_QCOM and make it visible
Date: Wed, 25 Nov 2015 11:10:49 +0100	[thread overview]
Message-ID: <56558929.6090403@linaro.org> (raw)
In-Reply-To: <1448413710-8101-2-git-send-email-sboyd@codeaurora.org>

On 11/25/2015 02:08 AM, Stephen Boyd wrote:
> We want to remove the ARCH_MSM* configs in mach-qcom/Kconfig
> because they are mostly proxy configs for selecting the right
> clocksource driver. Therefore, make CLKSRC_QCOM default to the
> value of ARCH_QCOM, but also make it visible if ARCH_QCOM=y so
> that we can turn it off when we don't want it.

I have been removing the ARCH dependencies in the Kconfig file.

Why do you have to turn it off manually ?

> Suggested-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
>   drivers/clocksource/Kconfig | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index b423785d6afc..7a5ffaa3e490 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -279,9 +279,10 @@ config EM_TIMER_STI
>   	  such as EMEV2 from former NEC Electronics.
>
>   config CLKSRC_QCOM
> -	bool "Qualcomm MSM timer" if COMPILE_TEST
> +	bool "Qualcomm MSM timer" if ARCH_QCOM || COMPILE_TEST
>   	depends on ARM
>   	select CLKSRC_OF
> +	defbool ARCH_QCOM
>   	help
>   	  This enables the clocksource and the per CPU clockevent driver for the
>   	  Qualcomm SoCs.
>


-- 
  <http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

  parent reply	other threads:[~2015-11-25 10:10 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-25  1:08 [PATCH 0/3] Remove ARCH_MSM* configs Stephen Boyd
2015-11-25  1:08 ` Stephen Boyd
2015-11-25  1:08 ` [PATCH 1/3] clocksource: defbool CLKSRC_QCOM=y on ARCH_QCOM and make it visible Stephen Boyd
2015-11-25  1:08   ` Stephen Boyd
2015-11-25  2:07   ` Stephen Boyd
2015-11-25  2:07     ` Stephen Boyd
2015-11-25  9:03     ` Arnd Bergmann
2015-11-25  9:03       ` Arnd Bergmann
2015-11-25 10:10   ` Daniel Lezcano [this message]
2015-11-25 10:10     ` Daniel Lezcano
2015-11-25 10:17     ` Arnd Bergmann
2015-11-25 10:17       ` Arnd Bergmann
2015-11-25 12:37       ` Daniel Lezcano
2015-11-25 12:37         ` Daniel Lezcano
2015-11-25 12:49         ` Arnd Bergmann
2015-11-25 12:49           ` Arnd Bergmann
2015-11-25 13:22           ` Daniel Lezcano
2015-11-25 13:22             ` Daniel Lezcano
2015-11-25  1:08 ` [PATCH 2/3] ARM: qcom_defconfig: Enable HAVE_ARM_ARCH_TIMER Stephen Boyd
2015-11-25  1:08   ` Stephen Boyd
2015-11-25  1:08 ` [PATCH 3/3] ARM: qcom: Drop ARCH_MSM* configs Stephen Boyd
2015-11-25  1:08   ` Stephen Boyd
2015-11-25 12:27   ` Daniel Lezcano
2015-11-25 12:27     ` Daniel Lezcano
2015-11-25 12:51     ` Arnd Bergmann
2015-11-25 12:51       ` Arnd Bergmann
2015-11-25 19:34       ` Stephen Boyd
2015-11-25 19:34         ` Stephen Boyd
2015-11-25 20:30         ` Arnd Bergmann
2015-11-25 20:30           ` Arnd Bergmann
2015-11-25 20:39           ` Stephen Boyd
2015-11-25 20:39             ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56558929.6090403@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=agross@codeaurora.org \
    --cc=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.