All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org, "Marcelo Tosatti" <mtosatti@redhat.com>,
	kvm@vger.kernel.org, ying.huang@intel.com,
	"Borislav Petkov" <bp@alien8.de>,
	"Andreas Färber" <afaerber@suse.de>,
	"Richard Henderson" <rth@twiddle.net>
Subject: Re: [PATCH 3/3] target-i386: kvm: Print warning when clearing mcg_cap bits
Date: Wed, 25 Nov 2015 18:30:32 +0100	[thread overview]
Message-ID: <5655F038.50101@redhat.com> (raw)
In-Reply-To: <20151125172925.GT23717@thinpad.lan.raisama.net>



On 25/11/2015 18:29, Eduardo Habkost wrote:
>>> > >  
>>> > > +        unsupported_caps = env->mcg_cap & ~(mcg_cap | MCG_CAP_BANKS_MASK);
>>> > > +        if (unsupported_caps) {
>>> > > +            error_report("warning: Unsupported MCG_CAP bits: 0x%" PRIx64 "\n",
>> > 
>> > \n should not be at end of error_report.
>> > 
>> > Fixed and applied.
> MCG_CAP_BANKS_MASK is defined by patch 2/3. Have you applied the
> whole series?

Yes, of course.

Paolo

WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: kvm@vger.kernel.org, "Marcelo Tosatti" <mtosatti@redhat.com>,
	qemu-devel@nongnu.org, "Borislav Petkov" <bp@alien8.de>,
	ying.huang@intel.com, "Andreas Färber" <afaerber@suse.de>,
	"Richard Henderson" <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH 3/3] target-i386: kvm: Print warning when clearing mcg_cap bits
Date: Wed, 25 Nov 2015 18:30:32 +0100	[thread overview]
Message-ID: <5655F038.50101@redhat.com> (raw)
In-Reply-To: <20151125172925.GT23717@thinpad.lan.raisama.net>



On 25/11/2015 18:29, Eduardo Habkost wrote:
>>> > >  
>>> > > +        unsupported_caps = env->mcg_cap & ~(mcg_cap | MCG_CAP_BANKS_MASK);
>>> > > +        if (unsupported_caps) {
>>> > > +            error_report("warning: Unsupported MCG_CAP bits: 0x%" PRIx64 "\n",
>> > 
>> > \n should not be at end of error_report.
>> > 
>> > Fixed and applied.
> MCG_CAP_BANKS_MASK is defined by patch 2/3. Have you applied the
> whole series?

Yes, of course.

Paolo

  reply	other threads:[~2015-11-25 17:30 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-25 15:49 [PATCH 0/3] target-i386: kvm: Use env->mcg_cap when setting up MCE Eduardo Habkost
2015-11-25 15:49 ` [Qemu-devel] " Eduardo Habkost
2015-11-25 15:49 ` [PATCH 1/3] target-i386: kvm: Abort if MCE bank count is not supported by host Eduardo Habkost
2015-11-25 15:49   ` [Qemu-devel] " Eduardo Habkost
2015-11-25 16:46   ` Paolo Bonzini
2015-11-25 16:46     ` [Qemu-devel] " Paolo Bonzini
2015-11-25 17:26     ` Eduardo Habkost
2015-11-25 17:26       ` [Qemu-devel] " Eduardo Habkost
2015-11-25 17:30       ` Paolo Bonzini
2015-11-25 17:30         ` [Qemu-devel] " Paolo Bonzini
2015-11-25 15:49 ` [PATCH 2/3] target-i386: kvm: Use env->mcg_cap when setting up MCE Eduardo Habkost
2015-11-25 15:49   ` [Qemu-devel] " Eduardo Habkost
2015-11-25 15:49 ` [PATCH 3/3] target-i386: kvm: Print warning when clearing mcg_cap bits Eduardo Habkost
2015-11-25 15:49   ` [Qemu-devel] " Eduardo Habkost
2015-11-25 16:45   ` Paolo Bonzini
2015-11-25 16:45     ` [Qemu-devel] " Paolo Bonzini
2015-11-25 17:29     ` Eduardo Habkost
2015-11-25 17:29       ` [Qemu-devel] " Eduardo Habkost
2015-11-25 17:30       ` Paolo Bonzini [this message]
2015-11-25 17:30         ` Paolo Bonzini
2015-11-25 17:21   ` Borislav Petkov
2015-11-25 17:21     ` [Qemu-devel] " Borislav Petkov
2015-11-25 17:29     ` Paolo Bonzini
2015-11-25 17:29       ` [Qemu-devel] " Paolo Bonzini
2015-11-25 17:35       ` Borislav Petkov
2015-11-25 17:35         ` [Qemu-devel] " Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5655F038.50101@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=afaerber@suse.de \
    --cc=bp@alien8.de \
    --cc=ehabkost@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.