From: Eric Blake <eblake@redhat.com>
To: John Snow <jsnow@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, jcody@redhat.com
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH v2] util/id: fully allocate names table
Date: Wed, 25 Nov 2015 14:07:53 -0700 [thread overview]
Message-ID: <56562329.5040109@redhat.com> (raw)
In-Reply-To: <1448485417-8196-1-git-send-email-jsnow@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 777 bytes --]
On 11/25/2015 02:03 PM, John Snow wrote:
> Trivial: this array should be allocated to have ID_MAX entries always.
> Otherwise if someone were to forget to expand this table, the assertion
> in the id generator won't actually trigger; it will read junk data.
>
> v2: Fix the range assertion, too. Compare against the known actual size
> of the table instead of what it "should" be.
The v2 blurb would normally appear after the ---; it can be removed by
the maintainer.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> util/id.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Eric Blake <eblake@redhat.com>
To: John Snow <jsnow@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, jcody@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2] util/id: fully allocate names table
Date: Wed, 25 Nov 2015 14:07:53 -0700 [thread overview]
Message-ID: <56562329.5040109@redhat.com> (raw)
In-Reply-To: <1448485417-8196-1-git-send-email-jsnow@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 777 bytes --]
On 11/25/2015 02:03 PM, John Snow wrote:
> Trivial: this array should be allocated to have ID_MAX entries always.
> Otherwise if someone were to forget to expand this table, the assertion
> in the id generator won't actually trigger; it will read junk data.
>
> v2: Fix the range assertion, too. Compare against the known actual size
> of the table instead of what it "should" be.
The v2 blurb would normally appear after the ---; it can be removed by
the maintainer.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> util/id.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-11-25 21:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-25 21:03 [Qemu-trivial] [PATCH v2] util/id: fully allocate names table John Snow
2015-11-25 21:03 ` [Qemu-devel] " John Snow
2015-11-25 21:07 ` Eric Blake [this message]
2015-11-25 21:07 ` Eric Blake
2015-11-25 22:07 ` [Qemu-trivial] " Jeff Cody
2015-11-25 22:07 ` [Qemu-devel] " Jeff Cody
2015-11-29 10:36 ` [Qemu-trivial] " Michael Tokarev
2015-11-29 10:36 ` [Qemu-devel] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56562329.5040109@redhat.com \
--to=eblake@redhat.com \
--cc=jcody@redhat.com \
--cc=jsnow@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.