All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juergen Gross <jgross@suse.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org
Subject: Re: [PATCH] target: xen-scsiback: Return proper -Exx instead of -1.
Date: Thu, 26 Nov 2015 07:36:33 +0100	[thread overview]
Message-ID: <5656A871.5000405@suse.com> (raw)
In-Reply-To: <1448479486-5719-1-git-send-email-konrad.wilk@oracle.com>

On 25/11/15 20:24, Konrad Rzeszutek Wilk wrote:
> We could return EINVAL but EBUSY (or EALREADY?)is more appropiate.
> 
> CC: jgross@suse.com
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

While it doesn't really matter it's cleaner.

Reviewed-by: Juergen Gross <jgross@suse.com>

> ---
>  drivers/xen/xen-scsiback.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/xen/xen-scsiback.c b/drivers/xen/xen-scsiback.c
> index 43bcae8..286e3da 100644
> --- a/drivers/xen/xen-scsiback.c
> +++ b/drivers/xen/xen-scsiback.c
> @@ -800,7 +800,7 @@ static int scsiback_init_sring(struct vscsibk_info *info, grant_ref_t ring_ref,
>  	int err;
>  
>  	if (info->irq)
> -		return -1;
> +		return -EBUSY;
>  
>  	err = xenbus_map_ring_valloc(info->dev, &ring_ref, 1, &area);
>  	if (err)
> 


  parent reply	other threads:[~2015-11-26  6:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-25 19:24 [PATCH] target: xen-scsiback: Return proper -Exx instead of -1 Konrad Rzeszutek Wilk
2015-11-26  6:36 ` Juergen Gross
2015-11-26  6:36 ` Juergen Gross [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-11-25 19:24 Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5656A871.5000405@suse.com \
    --to=jgross@suse.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.