All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vlastimil Babka <vbabka@suse.cz>
To: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Minchan Kim <minchan@kernel.org>,
	Sasha Levin <sasha.levin@oracle.com>,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	Mel Gorman <mgorman@suse.de>, Michal Hocko <mhocko@suse.cz>
Subject: Re: [PATCH v2 5/9] mm, page_owner: track and print last migrate reason
Date: Thu, 26 Nov 2015 11:39:06 +0100	[thread overview]
Message-ID: <5656E14A.1020508@suse.cz> (raw)
In-Reply-To: <20151125081323.GB10494@js1304-P5Q-DELUXE>

On 11/25/2015 09:13 AM, Joonsoo Kim wrote:
>> +	if (page_ext->last_migrate_reason != -1) {
>> +		ret += snprintf(kbuf + ret, count - ret,
>> +			"Page has been migrated, last migrate reason: %s\n",
>> +			migrate_reason_names[page_ext->last_migrate_reason]);
>> +		if (ret >= count)
>> +			goto err;
>> +	}
>> +
> 
> migrate_reason_names is defined if CONFIG_MIGRATION is enabled so
> it would cause build failure in case of !CONFIG_MIGRATION and
> CONFIG_PAGE_OWNER.
> 
> Thanks.

Ugh right, linking gives warnings... Thanks.
I think instead of adding #ifdefs here, let's move migrate_reason_names to
mm/debug.c as we gradually do with these things. Also enum
migrate_reason is defined regardless of CONFIG_MIGRATION, so match that
for migrate_reason_names as well.

------8<------

WARNING: multiple messages have this Message-ID (diff)
From: Vlastimil Babka <vbabka@suse.cz>
To: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Minchan Kim <minchan@kernel.org>,
	Sasha Levin <sasha.levin@oracle.com>,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	Mel Gorman <mgorman@suse.de>, Michal Hocko <mhocko@suse.cz>
Subject: Re: [PATCH v2 5/9] mm, page_owner: track and print last migrate reason
Date: Thu, 26 Nov 2015 11:39:06 +0100	[thread overview]
Message-ID: <5656E14A.1020508@suse.cz> (raw)
In-Reply-To: <20151125081323.GB10494@js1304-P5Q-DELUXE>

On 11/25/2015 09:13 AM, Joonsoo Kim wrote:
>> +	if (page_ext->last_migrate_reason != -1) {
>> +		ret += snprintf(kbuf + ret, count - ret,
>> +			"Page has been migrated, last migrate reason: %s\n",
>> +			migrate_reason_names[page_ext->last_migrate_reason]);
>> +		if (ret >= count)
>> +			goto err;
>> +	}
>> +
> 
> migrate_reason_names is defined if CONFIG_MIGRATION is enabled so
> it would cause build failure in case of !CONFIG_MIGRATION and
> CONFIG_PAGE_OWNER.
> 
> Thanks.

Ugh right, linking gives warnings... Thanks.
I think instead of adding #ifdefs here, let's move migrate_reason_names to
mm/debug.c as we gradually do with these things. Also enum
migrate_reason is defined regardless of CONFIG_MIGRATION, so match that
for migrate_reason_names as well.

------8<------
>From 7b650fd613ed382aaa6f11f4b779e883a6af10aa Mon Sep 17 00:00:00 2001
From: Vlastimil Babka <vbabka@suse.cz>
Date: Thu, 26 Nov 2015 11:31:09 +0100
Subject: mm, page_owner: track and print last migrate reason-fix

Move migrate_reason_names from mm/migrate.c to mm/debug.c so that link doesn't
warn with CONFIG_MIGRATION disabled.

---
 include/linux/migrate.h |  2 +-
 mm/debug.c              | 11 +++++++++++
 mm/migrate.c            | 10 ----------
 3 files changed, 12 insertions(+), 11 deletions(-)

diff --git a/include/linux/migrate.h b/include/linux/migrate.h
index ab92a8cf4c93..8fdc033e527a 100644
--- a/include/linux/migrate.h
+++ b/include/linux/migrate.h
@@ -27,7 +27,7 @@ enum migrate_reason {
 	MR_TYPES
 };
 
-/* In mm/migrate.c; also keep sync with include/trace/events/migrate.h */
+/* In mm/debug.c; also keep sync with include/trace/events/migrate.h */
 extern char * migrate_reason_names[MR_TYPES];
 
 #ifdef CONFIG_MIGRATION
diff --git a/mm/debug.c b/mm/debug.c
index d9718fc8377a..a4cd0c093ff6 100644
--- a/mm/debug.c
+++ b/mm/debug.c
@@ -9,6 +9,17 @@
 #include <linux/mm.h>
 #include <linux/trace_events.h>
 #include <linux/memcontrol.h>
+#include <linux/migrate.h>
+
+char *migrate_reason_names[MR_TYPES] = {
+	"compaction",
+	"memory_failure",
+	"memory_hotplug",
+	"syscall_or_cpuset",
+	"mempolicy_mbind",
+	"numa_misplaced",
+	"cma",
+};
 
 static const struct trace_print_flags pageflag_names[] = {
 	{1UL << PG_locked,		"locked"	},
diff --git a/mm/migrate.c b/mm/migrate.c
index 12e9ab9de446..1c11b73cd834 100644
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -47,16 +47,6 @@
 
 #include "internal.h"
 
-char *migrate_reason_names[MR_TYPES] = {
-	"compaction",
-	"memory_failure",
-	"memory_hotplug",
-	"syscall_or_cpuset",
-	"mempolicy_mbind",
-	"numa_misplaced",
-	"cma",
-};
-
 /*
  * migrate_prep() needs to be called before we start compiling a list of pages
  * to be migrated using isolate_lru_page(). If scheduling work on other CPUs is
-- 
2.6.3





  reply	other threads:[~2015-11-26 10:39 UTC|newest]

Thread overview: 115+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-24 12:36 [PATCH v2 0/9] page_owner improvements for debugging Vlastimil Babka
2015-11-24 12:36 ` Vlastimil Babka
2015-11-24 12:36 ` [PATCH v2 1/9] mm, debug: fix wrongly filtered flags in dump_vma() Vlastimil Babka
2015-11-24 12:36   ` Vlastimil Babka
2015-11-27  9:52   ` Vlastimil Babka
2015-11-27  9:52     ` Vlastimil Babka
2015-11-24 12:36 ` [PATCH v2 2/9] mm, page_owner: print symbolic migratetype of both page and pageblock Vlastimil Babka
2015-11-24 12:36   ` Vlastimil Babka
2015-11-25  8:11   ` Joonsoo Kim
2015-11-25  8:11     ` Joonsoo Kim
2015-11-24 12:36 ` [PATCH v2 3/9] mm, page_owner: convert page_owner_inited to static key Vlastimil Babka
2015-11-24 12:36   ` Vlastimil Babka
2015-11-25 14:52   ` Michal Hocko
2015-11-25 14:52     ` Michal Hocko
2015-11-25 15:08     ` Vlastimil Babka
2015-11-25 15:08       ` Vlastimil Babka
2015-11-25 15:25       ` Peter Zijlstra
2015-11-25 15:25         ` Peter Zijlstra
2015-11-25 15:46         ` Michal Hocko
2015-11-25 15:46           ` Michal Hocko
2015-11-24 12:36 ` [PATCH v2 4/9] mm, page_owner: copy page owner info during migration Vlastimil Babka
2015-11-24 12:36   ` Vlastimil Babka
2015-11-24 12:36 ` [PATCH v2 5/9] mm, page_owner: track and print last migrate reason Vlastimil Babka
2015-11-24 12:36   ` Vlastimil Babka
2015-11-25  8:13   ` Joonsoo Kim
2015-11-25  8:13     ` Joonsoo Kim
2015-11-26 10:39     ` Vlastimil Babka [this message]
2015-11-26 10:39       ` Vlastimil Babka
2015-11-24 12:36 ` [PATCH v2 6/9] mm, debug: introduce dump_gfpflag_names() for symbolic printing of gfp_flags Vlastimil Babka
2015-11-24 12:36   ` Vlastimil Babka
2015-11-25  8:16   ` Joonsoo Kim
2015-11-25  8:16     ` Joonsoo Kim
2015-11-25 10:28     ` Vlastimil Babka
2015-11-25 10:28       ` Vlastimil Babka
2015-11-27  3:40       ` yalin wang
2015-11-27  3:40         ` yalin wang
2015-11-24 12:36 ` [PATCH v2 7/9] mm, page_owner: dump page owner info from dump_page() Vlastimil Babka
2015-11-24 12:36   ` Vlastimil Babka
2015-11-25 14:58   ` Michal Hocko
2015-11-25 14:58     ` Michal Hocko
2015-11-26 10:43     ` Vlastimil Babka
2015-11-26 10:43       ` Vlastimil Babka
2015-11-24 12:36 ` [PATCH v2 8/9] mm, page_alloc: print symbolic gfp_flags on allocation failure Vlastimil Babka
2015-11-24 12:36   ` Vlastimil Babka
2015-11-25 14:33   ` Michal Hocko
2015-11-25 14:33     ` Michal Hocko
2015-11-24 12:36 ` [PATCH v2 9/9] mm, oom: print symbolic gfp_flags in oom warning Vlastimil Babka
2015-11-24 12:36   ` Vlastimil Babka
2015-11-25 14:31   ` Michal Hocko
2015-11-25 14:31     ` Michal Hocko
2016-01-07 21:29   ` David Rientjes
2016-01-07 21:29     ` David Rientjes
2016-01-08 11:34     ` Vlastimil Babka
2016-01-08 11:34       ` Vlastimil Babka
2015-11-25 14:30 ` [PATCH v2 0/9] page_owner improvements for debugging Michal Hocko
2015-11-25 14:30   ` Michal Hocko
2015-11-30 16:10   ` [PATCH 1/2] mm, printk: introduce new format string for flags Vlastimil Babka
2015-11-30 16:10     ` Vlastimil Babka
2015-11-30 16:10     ` [PATCH 2/2] mm, page_owner: provide symbolic page flags and gfp_flags Vlastimil Babka
2015-11-30 16:10       ` Vlastimil Babka
2015-12-02 11:01     ` [PATCH 1/2] mm, printk: introduce new format string for flags Rasmus Villemoes
2015-12-02 11:01       ` Rasmus Villemoes
2015-12-02 20:34       ` Vlastimil Babka
2015-12-02 20:34         ` Vlastimil Babka
2015-12-03 12:37         ` Rasmus Villemoes
2015-12-03 12:37           ` Rasmus Villemoes
2015-12-03 13:46           ` Vlastimil Babka
2015-12-03 13:46             ` Vlastimil Babka
2015-12-04 15:16       ` [PATCH v2 1/3] " Vlastimil Babka
2015-12-04 15:16         ` Vlastimil Babka
2015-12-04 15:16         ` [PATCH v2 2/3] mm, page_owner: provide symbolic page flags and gfp_flags Vlastimil Babka
2015-12-04 15:16           ` Vlastimil Babka
2015-12-04 15:16         ` [PATCH v2 3/3] mm, debug: move bad flags printing to bad_page() Vlastimil Babka
2015-12-04 15:16           ` Vlastimil Babka
2015-12-05 20:00         ` [PATCH v2 1/3] mm, printk: introduce new format string for flags Rasmus Villemoes
2015-12-05 20:00           ` Rasmus Villemoes
2015-12-09 11:29         ` Arnd Bergmann
2015-12-09 11:29           ` Arnd Bergmann
2015-12-09 20:48           ` Vlastimil Babka
2015-12-09 20:48             ` Vlastimil Babka
2015-12-10 12:26           ` James Hogan
2015-12-10 12:26             ` James Hogan
2015-12-10 12:26             ` James Hogan
2015-12-10  2:59         ` Joonsoo Kim
2015-12-10  2:59           ` Joonsoo Kim
2015-12-10  4:04           ` Steven Rostedt
2015-12-10  4:04             ` Steven Rostedt
2015-12-10  4:12             ` Joonsoo Kim
2015-12-10  4:12               ` Joonsoo Kim
2015-12-10  8:41             ` Rasmus Villemoes
2015-12-10  8:41               ` Rasmus Villemoes
2015-12-10 10:03             ` Vlastimil Babka
2015-12-10 10:03               ` Vlastimil Babka
2015-12-14  3:03               ` Joonsoo Kim
2015-12-14  3:03                 ` Joonsoo Kim
2015-12-10  3:51         ` Steven Rostedt
2015-12-10  3:51           ` Steven Rostedt
2015-12-10  9:51           ` Vlastimil Babka
2015-12-10  9:51             ` Vlastimil Babka
2015-12-02 17:40     ` [PATCH 1/2] " yalin wang
2015-12-02 17:40       ` yalin wang
2015-12-02 21:04       ` Vlastimil Babka
2015-12-02 21:04         ` Vlastimil Babka
2015-12-03  0:11         ` yalin wang
2015-12-03  0:11           ` yalin wang
2015-12-03  8:03           ` Rasmus Villemoes
2015-12-03  8:03             ` Rasmus Villemoes
2015-12-03 18:38             ` yalin wang
2015-12-03 18:38               ` yalin wang
2015-12-04  1:04               ` yalin wang
2015-12-04  1:04                 ` yalin wang
2015-12-04 14:15               ` Vlastimil Babka
2015-12-04 14:15                 ` Vlastimil Babka
2015-12-10  4:03                 ` Steven Rostedt
2015-12-10  4:03                   ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5656E14A.1020508@suse.cz \
    --to=vbabka@suse.cz \
    --cc=akpm@linux-foundation.org \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=mhocko@suse.cz \
    --cc=minchan@kernel.org \
    --cc=sasha.levin@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.