From: aryabinin@virtuozzo.com (Andrey Ryabinin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 0/4] KASAN for arm64
Date: Thu, 26 Nov 2015 15:22:41 +0300 [thread overview]
Message-ID: <5656F991.8090108@virtuozzo.com> (raw)
In-Reply-To: <20151126121007.GC32343@leverpostej>
On 11/26/2015 03:10 PM, Mark Rutland wrote:
> Hi Catalin,
>
> Can you pick up Andrey's patch below for v4.4, until we have a better
> solution?
>
FYI, better solution is almost ready, I'm going to send it today.
However, I don't know for sure whether it works or not :)
I'm not able to test as I don't have any setup working with 16k pages.
> I stumbled across this myself and was about to post a similar patch.
>
> FWIW:
>
> Acked-by: Mark Rutland <mark.rutland@arm.com>
>
> Thanks,
> Mark.
>
> On Tue, Nov 17, 2015 at 06:47:08PM +0300, Andrey Ryabinin wrote:
>> We should either add proper Kconfig dependency for now, or just make it work.
>>
>>
>> From: Andrey Ryabinin <aryabinin@virtuozzo.com>
>> Subject: [PATCH] arm64: KASAN depends on !(ARM64_16K_PAGES && ARM64_VA_BITS_48)
>>
>> On KASAN + 16K_PAGES + 48BIT_VA
>> arch/arm64/mm/kasan_init.c: In function ?kasan_early_init?:
>> include/linux/compiler.h:484:38: error: call to ?__compiletime_assert_95? declared with attribute error: BUILD_BUG_ON failed: !IS_ALIGNED(KASAN_SHADOW_END, PGDIR_SIZE)
>> _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__)
>>
>> Currently KASAN will not work on 16K_PAGES and 48BIT_VA, so
>> forbid such configuration to avoid above build failure.
>>
>> Reported-by: Suzuki K. Poulose <Suzuki.Poulose@arm.com>
>> Signed-off-by: Andrey Ryabinin <aryabinin@virtuozzo.com>
>> ---
>> arch/arm64/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
>> index 9ac16a4..bf7de69 100644
>> --- a/arch/arm64/Kconfig
>> +++ b/arch/arm64/Kconfig
>> @@ -49,7 +49,7 @@ config ARM64
>> select HAVE_ARCH_AUDITSYSCALL
>> select HAVE_ARCH_BITREVERSE
>> select HAVE_ARCH_JUMP_LABEL
>> - select HAVE_ARCH_KASAN if SPARSEMEM_VMEMMAP
>> + select HAVE_ARCH_KASAN if SPARSEMEM_VMEMMAP && !(ARM64_16K_PAGES && ARM64_VA_BITS_48)
>> select HAVE_ARCH_KGDB
>> select HAVE_ARCH_SECCOMP_FILTER
>> select HAVE_ARCH_TRACEHOOK
>> --
>> 2.4.10
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel at lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>>
WARNING: multiple messages have this Message-ID (diff)
From: Andrey Ryabinin <aryabinin@virtuozzo.com>
To: Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>
Cc: "Suzuki K. Poulose" <Suzuki.Poulose@arm.com>,
Yury <yury.norov@gmail.com>, Arnd Bergmann <arnd@arndb.de>,
linux-mm@kvack.org, Linus Walleij <linus.walleij@linaro.org>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Will Deacon <will.deacon@arm.com>,
linux-kernel@vger.kernel.org,
kasan-dev <kasan-dev@googlegroups.com>,
Alexey Klimov <klimov.linux@gmail.com>,
Alexander Potapenko <glider@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
David Keitel <dkeitel@codeaurora.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v7 0/4] KASAN for arm64
Date: Thu, 26 Nov 2015 15:22:41 +0300 [thread overview]
Message-ID: <5656F991.8090108@virtuozzo.com> (raw)
In-Reply-To: <20151126121007.GC32343@leverpostej>
On 11/26/2015 03:10 PM, Mark Rutland wrote:
> Hi Catalin,
>
> Can you pick up Andrey's patch below for v4.4, until we have a better
> solution?
>
FYI, better solution is almost ready, I'm going to send it today.
However, I don't know for sure whether it works or not :)
I'm not able to test as I don't have any setup working with 16k pages.
> I stumbled across this myself and was about to post a similar patch.
>
> FWIW:
>
> Acked-by: Mark Rutland <mark.rutland@arm.com>
>
> Thanks,
> Mark.
>
> On Tue, Nov 17, 2015 at 06:47:08PM +0300, Andrey Ryabinin wrote:
>> We should either add proper Kconfig dependency for now, or just make it work.
>>
>>
>> From: Andrey Ryabinin <aryabinin@virtuozzo.com>
>> Subject: [PATCH] arm64: KASAN depends on !(ARM64_16K_PAGES && ARM64_VA_BITS_48)
>>
>> On KASAN + 16K_PAGES + 48BIT_VA
>> arch/arm64/mm/kasan_init.c: In function a??kasan_early_inita??:
>> include/linux/compiler.h:484:38: error: call to a??__compiletime_assert_95a?? declared with attribute error: BUILD_BUG_ON failed: !IS_ALIGNED(KASAN_SHADOW_END, PGDIR_SIZE)
>> _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__)
>>
>> Currently KASAN will not work on 16K_PAGES and 48BIT_VA, so
>> forbid such configuration to avoid above build failure.
>>
>> Reported-by: Suzuki K. Poulose <Suzuki.Poulose@arm.com>
>> Signed-off-by: Andrey Ryabinin <aryabinin@virtuozzo.com>
>> ---
>> arch/arm64/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
>> index 9ac16a4..bf7de69 100644
>> --- a/arch/arm64/Kconfig
>> +++ b/arch/arm64/Kconfig
>> @@ -49,7 +49,7 @@ config ARM64
>> select HAVE_ARCH_AUDITSYSCALL
>> select HAVE_ARCH_BITREVERSE
>> select HAVE_ARCH_JUMP_LABEL
>> - select HAVE_ARCH_KASAN if SPARSEMEM_VMEMMAP
>> + select HAVE_ARCH_KASAN if SPARSEMEM_VMEMMAP && !(ARM64_16K_PAGES && ARM64_VA_BITS_48)
>> select HAVE_ARCH_KGDB
>> select HAVE_ARCH_SECCOMP_FILTER
>> select HAVE_ARCH_TRACEHOOK
>> --
>> 2.4.10
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Andrey Ryabinin <aryabinin@virtuozzo.com>
To: Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>
Cc: "Suzuki K. Poulose" <Suzuki.Poulose@arm.com>,
Yury <yury.norov@gmail.com>, Arnd Bergmann <arnd@arndb.de>,
<linux-mm@kvack.org>, Linus Walleij <linus.walleij@linaro.org>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Will Deacon <will.deacon@arm.com>, <linux-kernel@vger.kernel.org>,
kasan-dev <kasan-dev@googlegroups.com>,
Alexey Klimov <klimov.linux@gmail.com>,
Alexander Potapenko <glider@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
David Keitel <dkeitel@codeaurora.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v7 0/4] KASAN for arm64
Date: Thu, 26 Nov 2015 15:22:41 +0300 [thread overview]
Message-ID: <5656F991.8090108@virtuozzo.com> (raw)
In-Reply-To: <20151126121007.GC32343@leverpostej>
On 11/26/2015 03:10 PM, Mark Rutland wrote:
> Hi Catalin,
>
> Can you pick up Andrey's patch below for v4.4, until we have a better
> solution?
>
FYI, better solution is almost ready, I'm going to send it today.
However, I don't know for sure whether it works or not :)
I'm not able to test as I don't have any setup working with 16k pages.
> I stumbled across this myself and was about to post a similar patch.
>
> FWIW:
>
> Acked-by: Mark Rutland <mark.rutland@arm.com>
>
> Thanks,
> Mark.
>
> On Tue, Nov 17, 2015 at 06:47:08PM +0300, Andrey Ryabinin wrote:
>> We should either add proper Kconfig dependency for now, or just make it work.
>>
>>
>> From: Andrey Ryabinin <aryabinin@virtuozzo.com>
>> Subject: [PATCH] arm64: KASAN depends on !(ARM64_16K_PAGES && ARM64_VA_BITS_48)
>>
>> On KASAN + 16K_PAGES + 48BIT_VA
>> arch/arm64/mm/kasan_init.c: In function ‘kasan_early_init’:
>> include/linux/compiler.h:484:38: error: call to ‘__compiletime_assert_95’ declared with attribute error: BUILD_BUG_ON failed: !IS_ALIGNED(KASAN_SHADOW_END, PGDIR_SIZE)
>> _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__)
>>
>> Currently KASAN will not work on 16K_PAGES and 48BIT_VA, so
>> forbid such configuration to avoid above build failure.
>>
>> Reported-by: Suzuki K. Poulose <Suzuki.Poulose@arm.com>
>> Signed-off-by: Andrey Ryabinin <aryabinin@virtuozzo.com>
>> ---
>> arch/arm64/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
>> index 9ac16a4..bf7de69 100644
>> --- a/arch/arm64/Kconfig
>> +++ b/arch/arm64/Kconfig
>> @@ -49,7 +49,7 @@ config ARM64
>> select HAVE_ARCH_AUDITSYSCALL
>> select HAVE_ARCH_BITREVERSE
>> select HAVE_ARCH_JUMP_LABEL
>> - select HAVE_ARCH_KASAN if SPARSEMEM_VMEMMAP
>> + select HAVE_ARCH_KASAN if SPARSEMEM_VMEMMAP && !(ARM64_16K_PAGES && ARM64_VA_BITS_48)
>> select HAVE_ARCH_KGDB
>> select HAVE_ARCH_SECCOMP_FILTER
>> select HAVE_ARCH_TRACEHOOK
>> --
>> 2.4.10
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>>
next prev parent reply other threads:[~2015-11-26 12:22 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-12 15:52 [PATCH v7 0/4] KASAN for arm64 Andrey Ryabinin
2015-10-12 15:52 ` Andrey Ryabinin
2015-10-12 15:52 ` Andrey Ryabinin
2015-10-12 15:52 ` [PATCH v7 1/4] arm64: move PGD_SIZE definition to pgalloc.h Andrey Ryabinin
2015-10-12 15:52 ` Andrey Ryabinin
2015-10-12 15:52 ` Andrey Ryabinin
2015-10-12 15:52 ` [PATCH v7 2/4] arm64: add KASAN support Andrey Ryabinin
2015-10-12 15:52 ` Andrey Ryabinin
2015-10-12 15:52 ` Andrey Ryabinin
2015-10-12 15:52 ` [PATCH v7 3/4] ARM64: kasan: print memory assignment Andrey Ryabinin
2015-10-12 15:52 ` Andrey Ryabinin
2015-10-12 15:52 ` Andrey Ryabinin
2015-10-12 15:53 ` [PATCH v7 4/4] Documentation/features/KASAN: arm64 supports KASAN now Andrey Ryabinin
2015-10-12 15:53 ` Andrey Ryabinin
2015-10-12 15:53 ` Andrey Ryabinin
2015-10-13 8:34 ` [PATCH v7 0/4] KASAN for arm64 Catalin Marinas
2015-10-13 8:34 ` Catalin Marinas
2015-10-13 8:34 ` Catalin Marinas
2015-11-16 11:16 ` Suzuki K. Poulose
2015-11-16 11:16 ` Suzuki K. Poulose
2015-11-16 11:16 ` Suzuki K. Poulose
2015-11-16 15:34 ` Andrey Ryabinin
2015-11-16 15:34 ` Andrey Ryabinin
2015-11-16 15:34 ` Andrey Ryabinin
2015-11-16 16:51 ` Catalin Marinas
2015-11-16 16:51 ` Catalin Marinas
2015-11-16 16:51 ` Catalin Marinas
2015-11-18 14:33 ` Andrey Ryabinin
2015-11-18 14:33 ` Andrey Ryabinin
2015-11-18 14:33 ` Andrey Ryabinin
2015-11-18 15:48 ` Suzuki K. Poulose
2015-11-18 15:48 ` Suzuki K. Poulose
2015-11-18 15:48 ` Suzuki K. Poulose
2015-11-18 15:52 ` Ard Biesheuvel
2015-11-18 15:52 ` Ard Biesheuvel
2015-11-18 15:52 ` Ard Biesheuvel
2015-11-18 17:24 ` Catalin Marinas
2015-11-18 17:24 ` Catalin Marinas
2015-11-18 17:24 ` Catalin Marinas
2015-11-17 14:58 ` Suzuki K. Poulose
2015-11-17 14:58 ` Suzuki K. Poulose
2015-11-17 14:58 ` Suzuki K. Poulose
2015-11-17 15:47 ` Andrey Ryabinin
2015-11-17 15:47 ` Andrey Ryabinin
2015-11-17 15:47 ` Andrey Ryabinin
2015-11-26 12:10 ` Mark Rutland
2015-11-26 12:10 ` Mark Rutland
2015-11-26 12:10 ` Mark Rutland
2015-11-26 12:22 ` Andrey Ryabinin [this message]
2015-11-26 12:22 ` Andrey Ryabinin
2015-11-26 12:22 ` Andrey Ryabinin
2015-11-26 15:05 ` Catalin Marinas
2015-11-26 15:05 ` Catalin Marinas
2015-11-26 15:05 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5656F991.8090108@virtuozzo.com \
--to=aryabinin@virtuozzo.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.