From: Lars-Peter Clausen <lars@metafoo.de>
To: Wolfram Sang <wsa@the-dreams.de>, Magnus Damm <magnus.damm@gmail.com>
Cc: dri-devel@lists.freedesktop.org,
SH-Linux <linux-sh@vger.kernel.org>,
Simon Horman <horms@verge.net.au>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>
Subject: Re: [PATCH] drm: adv7511: really enable interrupts for EDID detection
Date: Thu, 26 Nov 2015 12:43:33 +0000 [thread overview]
Message-ID: <5656FE75.5080207@metafoo.de> (raw)
In-Reply-To: <20151125082736.GA1526@katana>
[-- Attachment #1: Type: text/plain, Size: 783 bytes --]
On 11/25/2015 09:27 AM, Wolfram Sang wrote:
>
>> I guess you mean that the GPIO callbacks include Runtime PM handling
>> however for irq_chip Runtime PM may not be hooked up so the GPIO block
>> is in such case is not powered on / get clock enabled?
>
> Yes. There is another drawback when GPIOs are not properly requested. It
> is still possible to request them from userspace although a kernel
> driver is using them. I am playing with the idea that the GPIO core
> auto-requests GPIOs which are not already requested but still set up as
> interrupts.
I think the GPIO core already reserves the pins that are requested as IRQs.
See gpiochip_lock_as_irq().
As for PM see this discussion
http://lkml.iu.edu/hypermail/linux/kernel/1511.1/01645.html
- Lars
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Lars-Peter Clausen <lars@metafoo.de>
To: Wolfram Sang <wsa@the-dreams.de>, Magnus Damm <magnus.damm@gmail.com>
Cc: dri-devel@lists.freedesktop.org,
SH-Linux <linux-sh@vger.kernel.org>,
Simon Horman <horms@verge.net.au>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>
Subject: Re: [PATCH] drm: adv7511: really enable interrupts for EDID detection
Date: Thu, 26 Nov 2015 13:43:33 +0100 [thread overview]
Message-ID: <5656FE75.5080207@metafoo.de> (raw)
In-Reply-To: <20151125082736.GA1526@katana>
[-- Attachment #1: Type: text/plain, Size: 783 bytes --]
On 11/25/2015 09:27 AM, Wolfram Sang wrote:
>
>> I guess you mean that the GPIO callbacks include Runtime PM handling
>> however for irq_chip Runtime PM may not be hooked up so the GPIO block
>> is in such case is not powered on / get clock enabled?
>
> Yes. There is another drawback when GPIOs are not properly requested. It
> is still possible to request them from userspace although a kernel
> driver is using them. I am playing with the idea that the GPIO core
> auto-requests GPIOs which are not already requested but still set up as
> interrupts.
I think the GPIO core already reserves the pins that are requested as IRQs.
See gpiochip_lock_as_irq().
As for PM see this discussion
http://lkml.iu.edu/hypermail/linux/kernel/1511.1/01645.html
- Lars
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-11-26 12:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-24 14:50 [PATCH] drm: adv7511: really enable interrupts for EDID detection Wolfram Sang
2015-11-24 14:50 ` Wolfram Sang
2015-11-24 21:05 ` Wolfram Sang
2015-11-24 21:05 ` Wolfram Sang
2015-11-25 6:34 ` Magnus Damm
2015-11-25 6:34 ` Magnus Damm
2015-11-25 6:48 ` Wolfram Sang
2015-11-25 6:48 ` Wolfram Sang
2015-11-25 7:58 ` Magnus Damm
2015-11-25 7:58 ` Magnus Damm
2015-11-25 8:27 ` Wolfram Sang
2015-11-25 8:27 ` Wolfram Sang
2015-11-26 12:43 ` Lars-Peter Clausen [this message]
2015-11-26 12:43 ` Lars-Peter Clausen
2015-11-26 13:51 ` Wolfram Sang
2015-11-26 13:51 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5656FE75.5080207@metafoo.de \
--to=lars@metafoo.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=kuninori.morimoto.gx@gmail.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.