* [PATCH] ASoC: sigmadsp: Add check for return value of i2c_master_send
@ 2015-11-26 13:00 pascal.huerst
2015-11-26 13:04 ` Lars-Peter Clausen
0 siblings, 1 reply; 2+ messages in thread
From: pascal.huerst @ 2015-11-26 13:00 UTC (permalink / raw)
To: lars; +Cc: alsa-devel, Pascal Huerst
From: Pascal Huerst <pascal.huerst@gmail.com>
i2c_master_send returns the number of bytes transmitted, which leads
to an error in the firmware download function. Check for the return
value and only return it directly, if it is an actual error number.
Signed-off-by: Pascal Huerst <pascal.huerst@gmail.com>
---
sound/soc/codecs/sigmadsp-i2c.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/sound/soc/codecs/sigmadsp-i2c.c b/sound/soc/codecs/sigmadsp-i2c.c
index 21ca3a5..d374c18 100644
--- a/sound/soc/codecs/sigmadsp-i2c.c
+++ b/sound/soc/codecs/sigmadsp-i2c.c
@@ -31,7 +31,10 @@ static int sigmadsp_write_i2c(void *control_data,
kfree(buf);
- return ret;
+ if (ret < 0)
+ return ret;
+
+ return 0;
}
static int sigmadsp_read_i2c(void *control_data,
--
2.4.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: sigmadsp: Add check for return value of i2c_master_send
2015-11-26 13:00 [PATCH] ASoC: sigmadsp: Add check for return value of i2c_master_send pascal.huerst
@ 2015-11-26 13:04 ` Lars-Peter Clausen
0 siblings, 0 replies; 2+ messages in thread
From: Lars-Peter Clausen @ 2015-11-26 13:04 UTC (permalink / raw)
To: pascal.huerst; +Cc: alsa-devel
On 11/26/2015 02:00 PM, pascal.huerst@gmail.com wrote:
> From: Pascal Huerst <pascal.huerst@gmail.com>
>
> i2c_master_send returns the number of bytes transmitted, which leads
> to an error in the firmware download function. Check for the return
> value and only return it directly, if it is an actual error number.
>
> Signed-off-by: Pascal Huerst <pascal.huerst@gmail.com>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-11-26 13:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-26 13:00 [PATCH] ASoC: sigmadsp: Add check for return value of i2c_master_send pascal.huerst
2015-11-26 13:04 ` Lars-Peter Clausen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.