All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Marek <mmarek@suse.cz>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: fengguang.wu@intel.com, kbuild-all@01.org,
	ath10k@lists.infradead.org, linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] ath10: Fix build with CONFIG_THERMAL=m
Date: Thu, 26 Nov 2015 16:53:31 +0100	[thread overview]
Message-ID: <56572AFB.20309@suse.cz> (raw)
In-Reply-To: <1448552198-26911-1-git-send-email-mmarek@suse.com>

On 2015-11-26 16:36, Michal Marek wrote:
> After commit cf4f21938e13 ("kbuild: Allow to specify composite modules
> with modname-m"), thermal.c gets included in the driver and the build
> fails with
> 
> drivers/net/wireless/ath/ath10k/thermal.c:119:6: error: redefinition of ‘ath10k_thermal_event_temperature’
> drivers/net/wireless/ath/ath10k/thermal.h:54:20: note: previous definition of ‘ath10k_thermal_event_temperature’ was here
> drivers/net/wireless/ath/ath10k/thermal.c:136:6: error: redefinition of ‘ath10k_thermal_set_throttling’
> drivers/net/wireless/ath/ath10k/thermal.h:59:20: note: previous definition of ‘ath10k_thermal_set_throttling’ was here
> drivers/net/wireless/ath/ath10k/thermal.c:162:5: error: redefinition of ‘ath10k_thermal_register’
> drivers/net/wireless/ath/ath10k/thermal.h:45:19: note: previous definition of ‘ath10k_thermal_register’ was here
> drivers/net/wireless/ath/ath10k/thermal.c:216:6: error: redefinition of ‘ath10k_thermal_unregister’
> drivers/net/wireless/ath/ath10k/thermal.h:50:20: note: previous definition of ‘ath10k_thermal_unregister’ was here
> 
> Change the #ifdef to reflect the new kbuild behavior.

Forgot to mention: The above commit only exists in the kbuild tree, so I
will apply this there as well, unless anybody objects. Applying the
patch to the ath tree would break the other way around.

Michal

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Michal Marek <mmarek@suse.cz>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: linux-kbuild@vger.kernel.org, kbuild-all@01.org,
	fengguang.wu@intel.com, ath10k@lists.infradead.org
Subject: Re: [PATCH] ath10: Fix build with CONFIG_THERMAL=m
Date: Thu, 26 Nov 2015 16:53:31 +0100	[thread overview]
Message-ID: <56572AFB.20309@suse.cz> (raw)
In-Reply-To: <1448552198-26911-1-git-send-email-mmarek@suse.com>

On 2015-11-26 16:36, Michal Marek wrote:
> After commit cf4f21938e13 ("kbuild: Allow to specify composite modules
> with modname-m"), thermal.c gets included in the driver and the build
> fails with
> 
> drivers/net/wireless/ath/ath10k/thermal.c:119:6: error: redefinition of ‘ath10k_thermal_event_temperature’
> drivers/net/wireless/ath/ath10k/thermal.h:54:20: note: previous definition of ‘ath10k_thermal_event_temperature’ was here
> drivers/net/wireless/ath/ath10k/thermal.c:136:6: error: redefinition of ‘ath10k_thermal_set_throttling’
> drivers/net/wireless/ath/ath10k/thermal.h:59:20: note: previous definition of ‘ath10k_thermal_set_throttling’ was here
> drivers/net/wireless/ath/ath10k/thermal.c:162:5: error: redefinition of ‘ath10k_thermal_register’
> drivers/net/wireless/ath/ath10k/thermal.h:45:19: note: previous definition of ‘ath10k_thermal_register’ was here
> drivers/net/wireless/ath/ath10k/thermal.c:216:6: error: redefinition of ‘ath10k_thermal_unregister’
> drivers/net/wireless/ath/ath10k/thermal.h:50:20: note: previous definition of ‘ath10k_thermal_unregister’ was here
> 
> Change the #ifdef to reflect the new kbuild behavior.

Forgot to mention: The above commit only exists in the kbuild tree, so I
will apply this there as well, unless anybody objects. Applying the
patch to the ath tree would break the other way around.

Michal

  reply	other threads:[~2015-11-26 15:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-25 16:12 [kbuild:kbuild 2/3] drivers/net/wireless/ath/ath10k/thermal.c:119:6: error: redefinition of 'ath10k_thermal_event_temperature' kbuild test robot
2015-11-26 15:36 ` [PATCH] ath10: Fix build with CONFIG_THERMAL=m Michal Marek
2015-11-26 15:36   ` Michal Marek
2015-11-26 15:53   ` Michal Marek [this message]
2015-11-26 15:53     ` Michal Marek
2015-11-26 17:01   ` Kalle Valo
2015-11-26 17:01     ` Kalle Valo
2015-11-26 17:01     ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56572AFB.20309@suse.cz \
    --to=mmarek@suse.cz \
    --cc=ath10k@lists.infradead.org \
    --cc=fengguang.wu@intel.com \
    --cc=kbuild-all@01.org \
    --cc=kvalo@qca.qualcomm.com \
    --cc=linux-kbuild@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.