Re: [PATCH 1/4] powerpc/powernv: panic() on OPAL < V3

[Andrew Donnellan <andrew.donnellan@au1.ibm.com>]

On 27/11/15 15:45, Stewart Smith wrote:
> The OpenPower Abstraction Layer firmware went through a couple
> of iterations in the lab before being released. What we now know
> as OPAL advertises itself as OPALv3.
>
> OPALv2 and OPALv1 never made it outside the lab, and the possibility
> of anyone at all ever building a mainline kernel today and expecting
> it to boot on such hardware is zero.
>
> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>

Comment below.

Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>

> ---
>   arch/powerpc/platforms/powernv/opal.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/arch/powerpc/platforms/powernv/opal.c b/arch/powerpc/platforms/powernv/opal.c
> index 4296d55e88f3..ad691fc15309 100644
> --- a/arch/powerpc/platforms/powernv/opal.c
> +++ b/arch/powerpc/platforms/powernv/opal.c
> @@ -103,11 +103,8 @@ int __init early_init_dt_scan_opal(unsigned long node,
>   		powerpc_firmware_features |= FW_FEATURE_OPALv2;
>   		powerpc_firmware_features |= FW_FEATURE_OPALv3;
>   		pr_info("OPAL V3 detected !\n");
> -	} else if (of_flat_dt_is_compatible(node, "ibm,opal-v2")) {
> -		powerpc_firmware_features |= FW_FEATURE_OPALv2;
> -		pr_info("OPAL V2 detected !\n");
>   	} else {
> -		pr_info("OPAL V1 detected !\n");
> +		panic("OPAL != V3 detected, no longer supported.\n")

In the event of an OPAL v4 that is for some reason not backwards 
compatible with V3, "*no longer* supported" might not make sense. This 
isn't a huge problem of course.

-- 
Andrew Donnellan              Software Engineer, OzLabs
andrew.donnellan@au1.ibm.com  Australia Development Lab, Canberra
+61 2 6201 8874 (work)        IBM Australia Limited