From: Stewart Smith <stewart@linux.vnet.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 3/4] powerpc/powernv: remove FW_FEATURE_OPAL and just use FW_FEATURE_OPALv3
Date: Thu, 03 Dec 2015 17:06:03 +1100 [thread overview]
Message-ID: <874mg0gj78.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <1448942184.9027.7.camel@ellerman.id.au>
Michael Ellerman <mpe@ellerman.id.au> writes:
> On Fri, 2015-11-27 at 15:45 +1100, Stewart Smith wrote:
>
>> Long ago, only in the lab, there was OPALv1 and OPALv2. Now there is
>> just OPALv3, with nobody ever expecting anything on pre-OPALv3 to
>> be cared about or supported by mainline kernels.
>>
>> So, let's remove FW_FEATURE_OPAL and instead use FW_FEATURE_OPALv3
>> exclusively.
>
> It would be less churn if we did the reverse, ie. removed v3 and just used
> FW_FEATURE_OPAL. It would also read better as v3 is the one and only version we
> care about, so having it called out everywhere is superfluous.
>
> Or is there a good reason I missed?
excessive caution?
I'll send a V2 patchset doing the reverse, leaving FW_FEATURE_OPAL.
next prev parent reply other threads:[~2015-12-03 6:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-27 4:45 [PATCH 0/4] Remove OPAL pre-v3 support Stewart Smith
2015-11-27 4:45 ` [PATCH 1/4] powerpc/powernv: panic() on OPAL < V3 Stewart Smith
2015-11-27 5:36 ` Andrew Donnellan
2015-11-27 5:43 ` Stewart Smith
2015-11-27 5:56 ` Andrew Donnellan
2015-11-30 0:20 ` Andrew Donnellan
2015-11-27 7:13 ` kbuild test robot
2015-11-27 4:45 ` [PATCH 2/4] powerpc/powernv: Remove OPALv2 firmware define and references Stewart Smith
2015-11-27 5:31 ` Andrew Donnellan
2015-11-27 4:45 ` [PATCH 3/4] powerpc/powernv: remove FW_FEATURE_OPAL and just use FW_FEATURE_OPALv3 Stewart Smith
2015-11-27 5:45 ` Andrew Donnellan
2015-12-01 3:56 ` Michael Ellerman
2015-12-03 6:06 ` Stewart Smith [this message]
2015-12-03 8:55 ` Michael Ellerman
2015-11-27 4:45 ` [PATCH 4/4] powerpc/powernv: remove logic for pre-OPALv3 firmware Stewart Smith
2015-11-27 5:55 ` Andrew Donnellan
2015-12-09 6:18 ` [PATCH v2 0/3] Remove OPAL pre-v3 support Stewart Smith
2015-12-09 6:18 ` [PATCH v2 1/3] powerpc/powernv: panic() on OPAL < V3 Stewart Smith
2015-12-17 11:57 ` [v2,1/3] " Michael Ellerman
2015-12-09 6:18 ` [PATCH v2 2/3] powerpc/powernv: Remove OPALv2 firmware define and references Stewart Smith
2015-12-09 6:18 ` [PATCH v2 3/3] powerpc/powernv: remove FW_FEATURE_OPALv3 and just use FW_FEATURE_OPAL Stewart Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874mg0gj78.fsf@linux.vnet.ibm.com \
--to=stewart@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.