From: Paolo Bonzini <pbonzini@redhat.com>
To: asmetanin@virtuozzo.com, kvm@vger.kernel.org
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
Roman Kagan <rkagan@virtuozzo.com>,
"Denis V. Lunev" <den@openvz.org>,
qemu-devel@nongnu.org
Subject: Re: [PATCH v1 5/5] x86: Hyper-V SynIC timers test
Date: Fri, 27 Nov 2015 13:12:59 +0100 [thread overview]
Message-ID: <565848CB.9060509@redhat.com> (raw)
In-Reply-To: <56583ED3.3080209@virtuozzo.com>
On 27/11/2015 12:30, Andrey Smetanin wrote:
>>>
>>> +
>>> +static void stimer_test_cleanup(void *ctx)
>>> +{
>>> + irq_enable();
>>
>> Why enable again?
> I'll remove it.
I guess you can remove the one in stimer_test_prepare too. If the
interrupts are disabled you don't get the IPI either, do you?
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: asmetanin@virtuozzo.com, kvm@vger.kernel.org
Cc: "Denis V. Lunev" <den@openvz.org>,
Marcelo Tosatti <mtosatti@redhat.com>,
Roman Kagan <rkagan@virtuozzo.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v1 5/5] x86: Hyper-V SynIC timers test
Date: Fri, 27 Nov 2015 13:12:59 +0100 [thread overview]
Message-ID: <565848CB.9060509@redhat.com> (raw)
In-Reply-To: <56583ED3.3080209@virtuozzo.com>
On 27/11/2015 12:30, Andrey Smetanin wrote:
>>>
>>> +
>>> +static void stimer_test_cleanup(void *ctx)
>>> +{
>>> + irq_enable();
>>
>> Why enable again?
> I'll remove it.
I guess you can remove the one in stimer_test_prepare too. If the
interrupts are disabled you don't get the IPI either, do you?
Paolo
next prev parent reply other threads:[~2015-11-27 12:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-26 16:29 [PATCH v1 0/5] KVM-UNIT-TESTS: Hyper-V SynIC timers test Andrey Smetanin
2015-11-26 16:29 ` [Qemu-devel] " Andrey Smetanin
2015-11-26 16:29 ` [PATCH v1 1/5] lib/x86: Added Hyper-V MSR's availability bits into msr.h Andrey Smetanin
2015-11-26 16:29 ` [Qemu-devel] " Andrey Smetanin
2015-11-26 16:29 ` [PATCH v1 2/5] lib/x86: Added HV_X64_MSR_TIME_REF_COUNT value " Andrey Smetanin
2015-11-26 16:29 ` [Qemu-devel] " Andrey Smetanin
2015-11-26 16:29 ` [PATCH v1 3/5] lib/x86: Added Hyper-V SynIC timers MSR's values Andrey Smetanin
2015-11-26 16:29 ` [Qemu-devel] " Andrey Smetanin
2015-11-26 16:29 ` [PATCH v1 4/5] lib/x86: Make free_page() available to call Andrey Smetanin
2015-11-26 16:29 ` [Qemu-devel] " Andrey Smetanin
2015-11-26 16:29 ` [PATCH v1 5/5] x86: Hyper-V SynIC timers test Andrey Smetanin
2015-11-26 16:29 ` [Qemu-devel] " Andrey Smetanin
2015-11-27 11:17 ` Paolo Bonzini
2015-11-27 11:30 ` Andrey Smetanin
2015-11-27 11:30 ` [Qemu-devel] " Andrey Smetanin
2015-11-27 12:12 ` Paolo Bonzini [this message]
2015-11-27 12:12 ` Paolo Bonzini
2015-11-27 11:17 ` [PATCH v1 0/5] KVM-UNIT-TESTS: " Paolo Bonzini
2015-11-27 11:17 ` [Qemu-devel] " Paolo Bonzini
2015-11-27 11:31 ` Andrey Smetanin
2015-11-27 11:31 ` [Qemu-devel] " Andrey Smetanin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565848CB.9060509@redhat.com \
--to=pbonzini@redhat.com \
--cc=asmetanin@virtuozzo.com \
--cc=den@openvz.org \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rkagan@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.