From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH for-2.5] bt: fix two struct sizes
Date: Fri, 27 Nov 2015 18:29:55 +0100 [thread overview]
Message-ID: <56589313.80401@redhat.com> (raw)
In-Reply-To: <87h9k7nze2.fsf@blackfin.pond.sub.org>
On 27/11/2015 18:08, Markus Armbruster wrote:
>> > evt_encrypt_change 4 5
> Used in bt_hci_event_encrypt_change(). I figure it makes bt_hci_event()
> overrun the destination by one byte.
Yes, and Coverity complains.
> Kernel has
>
> struct hci_ev_encrypt_change {
> __u8 status;
> __le16 handle;
> __u8 encrypt;
> } __packed;
>
> You changed this one. Plausible, but I don't want to have my R-by on it
> all the same.
Shall I proceed with this patch, just without R-by? Or only modify the
one where Coverity complains? I picked this one because it matches a
bluez patch.
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH for-2.5] bt: fix two struct sizes
Date: Fri, 27 Nov 2015 18:29:55 +0100 [thread overview]
Message-ID: <56589313.80401@redhat.com> (raw)
In-Reply-To: <87h9k7nze2.fsf@blackfin.pond.sub.org>
On 27/11/2015 18:08, Markus Armbruster wrote:
>> > evt_encrypt_change 4 5
> Used in bt_hci_event_encrypt_change(). I figure it makes bt_hci_event()
> overrun the destination by one byte.
Yes, and Coverity complains.
> Kernel has
>
> struct hci_ev_encrypt_change {
> __u8 status;
> __le16 handle;
> __u8 encrypt;
> } __packed;
>
> You changed this one. Plausible, but I don't want to have my R-by on it
> all the same.
Shall I proceed with this patch, just without R-by? Or only modify the
one where Coverity complains? I picked this one because it matches a
bluez patch.
Paolo
next prev parent reply other threads:[~2015-11-27 17:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-27 12:08 [Qemu-trivial] [PATCH for-2.5] bt: fix two struct sizes Paolo Bonzini
2015-11-27 12:08 ` [Qemu-devel] " Paolo Bonzini
2015-11-27 14:39 ` [Qemu-trivial] " Markus Armbruster
2015-11-27 14:39 ` Markus Armbruster
2015-11-27 14:41 ` [Qemu-trivial] " Paolo Bonzini
2015-11-27 14:41 ` Paolo Bonzini
2015-11-27 15:16 ` [Qemu-trivial] " Markus Armbruster
2015-11-27 15:16 ` Markus Armbruster
2015-11-27 16:14 ` [Qemu-trivial] " Paolo Bonzini
2015-11-27 16:14 ` Paolo Bonzini
2015-11-27 16:30 ` [Qemu-trivial] " Markus Armbruster
2015-11-27 16:30 ` Markus Armbruster
2015-11-27 17:08 ` [Qemu-trivial] " Markus Armbruster
2015-11-27 17:08 ` Markus Armbruster
2015-11-27 17:29 ` Paolo Bonzini [this message]
2015-11-27 17:29 ` Paolo Bonzini
2015-11-27 17:42 ` [Qemu-trivial] " Markus Armbruster
2015-11-27 17:42 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56589313.80401@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.