* [Qemu-trivial] [PATCH for-2.5] bt: avoid unintended sign extension
@ 2015-11-27 12:08 ` Paolo Bonzini
0 siblings, 0 replies; 6+ messages in thread
From: Paolo Bonzini @ 2015-11-27 12:08 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial
In the case of a 4-byte length, shifting a value by 24 may cause
an unintended sign extension when converting from int to size_t.
Use a uint32_t variable instead.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
hw/bt/sdp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/bt/sdp.c b/hw/bt/sdp.c
index b9bcdcc..04eaeca 100644
--- a/hw/bt/sdp.c
+++ b/hw/bt/sdp.c
@@ -42,7 +42,7 @@ struct bt_l2cap_sdp_state_s {
static ssize_t sdp_datalen(const uint8_t **element, ssize_t *left)
{
- size_t len = *(*element) ++ & SDP_DSIZE_MASK;
+ uint32_t len = *(*element) ++ & SDP_DSIZE_MASK;
if (!*left)
return -1;
--
2.5.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Qemu-devel] [PATCH for-2.5] bt: avoid unintended sign extension
@ 2015-11-27 12:08 ` Paolo Bonzini
0 siblings, 0 replies; 6+ messages in thread
From: Paolo Bonzini @ 2015-11-27 12:08 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial
In the case of a 4-byte length, shifting a value by 24 may cause
an unintended sign extension when converting from int to size_t.
Use a uint32_t variable instead.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
hw/bt/sdp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/bt/sdp.c b/hw/bt/sdp.c
index b9bcdcc..04eaeca 100644
--- a/hw/bt/sdp.c
+++ b/hw/bt/sdp.c
@@ -42,7 +42,7 @@ struct bt_l2cap_sdp_state_s {
static ssize_t sdp_datalen(const uint8_t **element, ssize_t *left)
{
- size_t len = *(*element) ++ & SDP_DSIZE_MASK;
+ uint32_t len = *(*element) ++ & SDP_DSIZE_MASK;
if (!*left)
return -1;
--
2.5.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Qemu-trivial] [Qemu-devel] [PATCH for-2.5] bt: avoid unintended sign extension
2015-11-27 12:08 ` [Qemu-devel] " Paolo Bonzini
@ 2015-11-27 14:36 ` Markus Armbruster
-1 siblings, 0 replies; 6+ messages in thread
From: Markus Armbruster @ 2015-11-27 14:36 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-trivial, qemu-devel
Paolo Bonzini <pbonzini@redhat.com> writes:
> In the case of a 4-byte length, shifting a value by 24 may cause
> an unintended sign extension when converting from int to size_t.
> Use a uint32_t variable instead.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
For 32 bit ssize_t, lengths > 0x7fffffff go to negative, same as before.
*shrug*
Reviewed-by: Markus Armbruster <armbru@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH for-2.5] bt: avoid unintended sign extension
@ 2015-11-27 14:36 ` Markus Armbruster
0 siblings, 0 replies; 6+ messages in thread
From: Markus Armbruster @ 2015-11-27 14:36 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-trivial, qemu-devel
Paolo Bonzini <pbonzini@redhat.com> writes:
> In the case of a 4-byte length, shifting a value by 24 may cause
> an unintended sign extension when converting from int to size_t.
> Use a uint32_t variable instead.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
For 32 bit ssize_t, lengths > 0x7fffffff go to negative, same as before.
*shrug*
Reviewed-by: Markus Armbruster <armbru@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-trivial] [PATCH for-2.5] bt: avoid unintended sign extension
2015-11-27 12:08 ` [Qemu-devel] " Paolo Bonzini
@ 2015-11-29 10:37 ` Michael Tokarev
-1 siblings, 0 replies; 6+ messages in thread
From: Michael Tokarev @ 2015-11-29 10:37 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel; +Cc: qemu-trivial
27.11.2015 15:08, Paolo Bonzini wrote:
> In the case of a 4-byte length, shifting a value by 24 may cause
> an unintended sign extension when converting from int to size_t.
> Use a uint32_t variable instead.
Applied to -trivial, thank you!
/mjt
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-11-29 10:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-27 12:08 [Qemu-trivial] [PATCH for-2.5] bt: avoid unintended sign extension Paolo Bonzini
2015-11-27 12:08 ` [Qemu-devel] " Paolo Bonzini
2015-11-27 14:36 ` [Qemu-trivial] " Markus Armbruster
2015-11-27 14:36 ` Markus Armbruster
2015-11-29 10:37 ` [Qemu-trivial] " Michael Tokarev
2015-11-29 10:37 ` [Qemu-devel] " Michael Tokarev
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.