[Qemu-trivial] [PATCH] configure: Diagnose broken linkers directly

[Qemu-trivial] [PATCH] configure: Diagnose broken linkers directly

[Peter Maydell]

Currently if the user's compiler works for creating .o files but
their linker is broken such that compiling an executable from a
C file does not work, we will report a misleading error message
about the compiler not supporting __thread (since that happens
to be the first test we run which requires a working linker).
Explicitly check that compile_prog works as well as compile_object,
so that people whose toolchain setup is broken get a more helpful
error message.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 configure | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/configure b/configure
index 71d6cbc..21a8536 100755
--- a/configure
+++ b/configure
@@ -1426,6 +1426,9 @@ if compile_object ; then
 else
     error_exit "\"$cc\" either does not exist or does not work"
 fi
+if ! compile_prog ; then
+    error_exit "\"$cc\" cannot build an executable (is your linker broken?)"
+fi
 
 # Check that the C++ compiler exists and works with the C compiler
 if has $cxx; then
-- 
1.9.1

[Qemu-devel] [PATCH] configure: Diagnose broken linkers directly

[Peter Maydell]

Currently if the user's compiler works for creating .o files but
their linker is broken such that compiling an executable from a
C file does not work, we will report a misleading error message
about the compiler not supporting __thread (since that happens
to be the first test we run which requires a working linker).
Explicitly check that compile_prog works as well as compile_object,
so that people whose toolchain setup is broken get a more helpful
error message.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 configure | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/configure b/configure
index 71d6cbc..21a8536 100755
--- a/configure
+++ b/configure
@@ -1426,6 +1426,9 @@ if compile_object ; then
 else
     error_exit "\"$cc\" either does not exist or does not work"
 fi
+if ! compile_prog ; then
+    error_exit "\"$cc\" cannot build an executable (is your linker broken?)"
+fi
 
 # Check that the C++ compiler exists and works with the C compiler
 if has $cxx; then
-- 
1.9.1

Re: [Qemu-trivial] [PATCH] configure: Diagnose broken linkers directly

[Michael Tokarev]

24.11.2015 17:55, Peter Maydell wrote:
> Currently if the user's compiler works for creating .o files but
> their linker is broken such that compiling an executable from a
> C file does not work, we will report a misleading error message
> about the compiler not supporting __thread (since that happens
> to be the first test we run which requires a working linker).
> Explicitly check that compile_prog works as well as compile_object,
> so that people whose toolchain setup is broken get a more helpful
> error message.

Applied to -trivial, thanks!

/mjt

Re: [Qemu-devel] [PATCH] configure: Diagnose broken linkers directly

[Michael Tokarev]

24.11.2015 17:55, Peter Maydell wrote:
> Currently if the user's compiler works for creating .o files but
> their linker is broken such that compiling an executable from a
> C file does not work, we will report a misleading error message
> about the compiler not supporting __thread (since that happens
> to be the first test we run which requires a working linker).
> Explicitly check that compile_prog works as well as compile_object,
> so that people whose toolchain setup is broken get a more helpful
> error message.

Applied to -trivial, thanks!

/mjt