All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] rilmodem: fix set_call_barring reply trace (mako)
@ 2015-11-25  0:18 Tony Espy
  2015-11-29 21:51 ` Denis Kenzior
  0 siblings, 1 reply; 2+ messages in thread
From: Tony Espy @ 2015-11-25  0:18 UTC (permalink / raw)
  To: ofono

[-- Attachment #1: Type: text/plain, Size: 1034 bytes --]

This change restores the trace output for a reply to a
REQUEST_SET_FACILITY_LOCK used by the set function.
---
 drivers/rilmodem/call-barring.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/rilmodem/call-barring.c b/drivers/rilmodem/call-barring.c
index 70b0b56..719bbe1 100644
--- a/drivers/rilmodem/call-barring.c
+++ b/drivers/rilmodem/call-barring.c
@@ -119,7 +119,7 @@ static void ril_call_barring_set_cb(struct ril_msg *message, gpointer user_data)
 	ofono_call_barring_set_cb_t cb = cbd->cb;
 	struct barring_data *bd = cbd->user;
 	struct parcel rilp;
-	int retries;
+	int retries = -1;
 
 	if (message->error != RIL_E_SUCCESS)
 		goto error;
@@ -138,10 +138,10 @@ static void ril_call_barring_set_cb(struct ril_msg *message, gpointer user_data)
 	if (rilp.malformed)
 		goto error;
 
+done:
 	g_ril_append_print_buf(bd->ril, "{%d}", retries);
 	g_ril_print_response(bd->ril, message);
 
-done:
 	CALLBACK_WITH_SUCCESS(cb, cbd->data);
 	return;
 
-- 
2.1.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] rilmodem: fix set_call_barring reply trace (mako)
  2015-11-25  0:18 [PATCH] rilmodem: fix set_call_barring reply trace (mako) Tony Espy
@ 2015-11-29 21:51 ` Denis Kenzior
  0 siblings, 0 replies; 2+ messages in thread
From: Denis Kenzior @ 2015-11-29 21:51 UTC (permalink / raw)
  To: ofono

[-- Attachment #1: Type: text/plain, Size: 318 bytes --]

Hi Tony,

On 11/24/2015 06:18 PM, Tony Espy wrote:
> This change restores the trace output for a reply to a
> REQUEST_SET_FACILITY_LOCK used by the set function.
> ---
>   drivers/rilmodem/call-barring.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>

Applied, thanks.

Regards,
-Denis


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-11-29 21:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-25  0:18 [PATCH] rilmodem: fix set_call_barring reply trace (mako) Tony Espy
2015-11-29 21:51 ` Denis Kenzior

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.