* [PATCH] CLK: s3c2410: removed unneeded code in s3c24xx_clkout_set_parent
@ 2015-11-30 7:01 ` Mutharaju, Prasanna (P.)
0 siblings, 0 replies; 5+ messages in thread
From: Mutharaju, Prasanna (P.) @ 2015-11-30 7:01 UTC (permalink / raw)
To: Kukjin Kim, Krzysztof Kozlowski, Sylwester Nawrocki, Tomasz Figa,
Michael Turquette, Stephen Boyd
Cc: linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
From: Prasanna Karthik <mkarthi3@visteon.com>
Remove unneeded variable used to store return value.
Signed-off-by: Prasanna Karthik <mkarthi3@visteon.com>
---
drivers/clk/samsung/clk-s3c2410-dclk.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/clk/samsung/clk-s3c2410-dclk.c b/drivers/clk/samsung/c=
lk-s3c2410-dclk.c
index e9eb935..ec6fb14 100644
--- a/drivers/clk/samsung/clk-s3c2410-dclk.c
+++ b/drivers/clk/samsung/clk-s3c2410-dclk.c
@@ -77,12 +77,11 @@ static u8 s3c24xx_clkout_get_parent(struct clk_hw *hw)
static int s3c24xx_clkout_set_parent(struct clk_hw *hw, u8 index)
{
struct s3c24xx_clkout *clkout =3D to_s3c24xx_clkout(hw);
- int ret =3D 0;
=20
s3c2410_modify_misccr((clkout->mask << clkout->shift),
(index << clkout->shift));
=20
- return ret;
+ return 0;
}
=20
static const struct clk_ops s3c24xx_clkout_ops =3D {
--=20
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] CLK: s3c2410: removed unneeded code in s3c24xx_clkout_set_parent
@ 2015-11-30 7:01 ` Mutharaju, Prasanna (P.)
0 siblings, 0 replies; 5+ messages in thread
From: Mutharaju, Prasanna (P.) @ 2015-11-30 7:01 UTC (permalink / raw)
To: Kukjin Kim, Krzysztof Kozlowski, Sylwester Nawrocki, Tomasz Figa,
Michael Turquette, Stephen Boyd
Cc: linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
From: Prasanna Karthik <mkarthi3@visteon.com>
Remove unneeded variable used to store return value.
Signed-off-by: Prasanna Karthik <mkarthi3@visteon.com>
---
drivers/clk/samsung/clk-s3c2410-dclk.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/clk/samsung/clk-s3c2410-dclk.c b/drivers/clk/samsung/clk-s3c2410-dclk.c
index e9eb935..ec6fb14 100644
--- a/drivers/clk/samsung/clk-s3c2410-dclk.c
+++ b/drivers/clk/samsung/clk-s3c2410-dclk.c
@@ -77,12 +77,11 @@ static u8 s3c24xx_clkout_get_parent(struct clk_hw *hw)
static int s3c24xx_clkout_set_parent(struct clk_hw *hw, u8 index)
{
struct s3c24xx_clkout *clkout = to_s3c24xx_clkout(hw);
- int ret = 0;
s3c2410_modify_misccr((clkout->mask << clkout->shift),
(index << clkout->shift));
- return ret;
+ return 0;
}
static const struct clk_ops s3c24xx_clkout_ops = {
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] CLK: s3c2410: removed unneeded code in s3c24xx_clkout_set_parent
@ 2015-11-30 7:01 ` Mutharaju, Prasanna (P.)
0 siblings, 0 replies; 5+ messages in thread
From: Mutharaju, Prasanna (P.) @ 2015-11-30 7:01 UTC (permalink / raw)
To: linux-arm-kernel
From: Prasanna Karthik <mkarthi3@visteon.com>
Remove unneeded variable used to store return value.
Signed-off-by: Prasanna Karthik <mkarthi3@visteon.com>
---
drivers/clk/samsung/clk-s3c2410-dclk.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/clk/samsung/clk-s3c2410-dclk.c b/drivers/clk/samsung/clk-s3c2410-dclk.c
index e9eb935..ec6fb14 100644
--- a/drivers/clk/samsung/clk-s3c2410-dclk.c
+++ b/drivers/clk/samsung/clk-s3c2410-dclk.c
@@ -77,12 +77,11 @@ static u8 s3c24xx_clkout_get_parent(struct clk_hw *hw)
static int s3c24xx_clkout_set_parent(struct clk_hw *hw, u8 index)
{
struct s3c24xx_clkout *clkout = to_s3c24xx_clkout(hw);
- int ret = 0;
s3c2410_modify_misccr((clkout->mask << clkout->shift),
(index << clkout->shift));
- return ret;
+ return 0;
}
static const struct clk_ops s3c24xx_clkout_ops = {
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] CLK: s3c2410: removed unneeded code in s3c24xx_clkout_set_parent
2015-11-30 7:01 ` Mutharaju, Prasanna (P.)
@ 2015-11-30 7:10 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2015-11-30 7:10 UTC (permalink / raw)
To: Mutharaju, Prasanna (P.), Kukjin Kim, Sylwester Nawrocki,
Tomasz Figa, Michael Turquette, Stephen Boyd
Cc: linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
On 30.11.2015 16:01, Mutharaju, Prasanna (P.) wrote:
> From: Prasanna Karthik <mkarthi3@visteon.com>
>
> Remove unneeded variable used to store return value.
>
> Signed-off-by: Prasanna Karthik <mkarthi3@visteon.com>
You need to sign it off too.
The prefix in subject should be lowercase 'clk:' and you are removing
rather a variable, not code.
The patch looks good, so with these changes:
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
> ---
> drivers/clk/samsung/clk-s3c2410-dclk.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/clk/samsung/clk-s3c2410-dclk.c b/drivers/clk/samsung/clk-s3c2410-dclk.c
> index e9eb935..ec6fb14 100644
> --- a/drivers/clk/samsung/clk-s3c2410-dclk.c
> +++ b/drivers/clk/samsung/clk-s3c2410-dclk.c
> @@ -77,12 +77,11 @@ static u8 s3c24xx_clkout_get_parent(struct clk_hw *hw)
> static int s3c24xx_clkout_set_parent(struct clk_hw *hw, u8 index)
> {
> struct s3c24xx_clkout *clkout = to_s3c24xx_clkout(hw);
> - int ret = 0;
>
> s3c2410_modify_misccr((clkout->mask << clkout->shift),
> (index << clkout->shift));
>
> - return ret;
> + return 0;
> }
>
> static const struct clk_ops s3c24xx_clkout_ops = {
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] CLK: s3c2410: removed unneeded code in s3c24xx_clkout_set_parent
@ 2015-11-30 7:10 ` Krzysztof Kozlowski
0 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2015-11-30 7:10 UTC (permalink / raw)
To: linux-arm-kernel
On 30.11.2015 16:01, Mutharaju, Prasanna (P.) wrote:
> From: Prasanna Karthik <mkarthi3@visteon.com>
>
> Remove unneeded variable used to store return value.
>
> Signed-off-by: Prasanna Karthik <mkarthi3@visteon.com>
You need to sign it off too.
The prefix in subject should be lowercase 'clk:' and you are removing
rather a variable, not code.
The patch looks good, so with these changes:
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
> ---
> drivers/clk/samsung/clk-s3c2410-dclk.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/clk/samsung/clk-s3c2410-dclk.c b/drivers/clk/samsung/clk-s3c2410-dclk.c
> index e9eb935..ec6fb14 100644
> --- a/drivers/clk/samsung/clk-s3c2410-dclk.c
> +++ b/drivers/clk/samsung/clk-s3c2410-dclk.c
> @@ -77,12 +77,11 @@ static u8 s3c24xx_clkout_get_parent(struct clk_hw *hw)
> static int s3c24xx_clkout_set_parent(struct clk_hw *hw, u8 index)
> {
> struct s3c24xx_clkout *clkout = to_s3c24xx_clkout(hw);
> - int ret = 0;
>
> s3c2410_modify_misccr((clkout->mask << clkout->shift),
> (index << clkout->shift));
>
> - return ret;
> + return 0;
> }
>
> static const struct clk_ops s3c24xx_clkout_ops = {
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-11-30 7:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-30 7:01 [PATCH] CLK: s3c2410: removed unneeded code in s3c24xx_clkout_set_parent Mutharaju, Prasanna (P.)
2015-11-30 7:01 ` Mutharaju, Prasanna (P.)
2015-11-30 7:01 ` Mutharaju, Prasanna (P.)
2015-11-30 7:10 ` Krzysztof Kozlowski
2015-11-30 7:10 ` Krzysztof Kozlowski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.