Re: [PATCH v2 1/2] ACPI / scan: Fix acpi_bus_id_list bookkeeping

[Hanjun Guo <guohanjun@huawei.com>]

On 2015/11/30 14:27, Hanjun Guo wrote:
> Hi Lucas,
>
> Sorry for the late reply, please see comments below.
>
> On 2015/11/26 4:19, Lukas Wunner wrote:
>> acpi_device_add() allocates and adds an element to acpi_bus_id_list
>> (or increments the instance count if the device's HID is already
>> present in the list), but the element is never deleted from the list
>> nor freed. Fix it.
> Hmm, I didn't get it here. Seems the device's ID already freed in device core:
>
>  In acpi_add_single_object(), acpi_device_release() registered as a callback,
> ...
>   result = acpi_device_add(device, acpi_device_release);
> ...
>
> And in acpi_device_release(), it will call acpi_free_pnp_ids() to free the
> IDs, did I miss some something?

Sorry, I misread the code, I thought it was the pnn ids connect to the ACPI device,
actually you are referring to HIDs connecting to acpi_bus_id_list, sorry for the noise.

Hanjun