All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hanjun Guo <guohanjun@huawei.com>
To: Lukas Wunner <lukas@wunner.de>,
	linux-acpi@vger.kernel.org,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Len Brown <lenb@kernel.org>
Cc: devel@acpica.org, Robert Moore <robert.moore@intel.com>,
	Mark Brown <broonie@kernel.org>,
	Hui Wang <hui.wang@canonical.com>,
	Darren Hart <dvhart@infradead.org>
Subject: Re: [PATCH v2 1/2] ACPI / scan: Fix acpi_bus_id_list bookkeeping
Date: Mon, 30 Nov 2015 14:27:49 +0800	[thread overview]
Message-ID: <565BEC65.90409@huawei.com> (raw)
In-Reply-To: <994278b96189033970d0a2add95645110c716fbb.1448480385.git.lukas@wunner.de>

Hi Lucas,

Sorry for the late reply, please see comments below.

On 2015/11/26 4:19, Lukas Wunner wrote:
> acpi_device_add() allocates and adds an element to acpi_bus_id_list
> (or increments the instance count if the device's HID is already
> present in the list), but the element is never deleted from the list
> nor freed. Fix it.

Hmm, I didn't get it here. Seems the device's ID already freed in device core:

 In acpi_add_single_object(), acpi_device_release() registered as a callback,
...
  result = acpi_device_add(device, acpi_device_release);
...

And in acpi_device_release(), it will call acpi_free_pnp_ids() to free the
IDs, did I miss some something?

Thanks
Hanjun


  reply	other threads:[~2015-11-30  6:29 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-25 20:19 [Devel] [PATCH v2 0/2] Add acpi_dev_present Lukas Wunner
2015-11-25 20:19 ` Lukas Wunner
2015-11-25 20:19 ` [Devel] [PATCH v2 1/2] ACPI / scan: Fix acpi_bus_id_list bookkeeping Lukas Wunner
2015-11-25 20:19   ` Lukas Wunner
2015-11-30  6:27   ` Hanjun Guo [this message]
2015-11-30  8:14     ` Hanjun Guo
2015-12-01 13:08       ` [Devel] " Lukas Wunner
2015-12-01 13:08         ` Lukas Wunner
2015-12-02  8:56         ` Hanjun Guo
2015-12-06 21:09           ` [Devel] " Lukas Wunner
2015-12-06 21:09             ` Lukas Wunner
2015-12-07  1:39             ` Rafael J. Wysocki
2015-11-25 20:19 ` [Devel] [PATCH v2 2/2] ACPI / utils: Add acpi_dev_present() Lukas Wunner
2015-11-25 20:19   ` Lukas Wunner
2015-11-30  8:27   ` Hanjun Guo
2015-12-01 12:58     ` [Devel] " Lukas Wunner
2015-12-01 12:58       ` Lukas Wunner
2015-12-02  8:26       ` Hanjun Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=565BEC65.90409@huawei.com \
    --to=guohanjun@huawei.com \
    --cc=broonie@kernel.org \
    --cc=devel@acpica.org \
    --cc=dvhart@infradead.org \
    --cc=hui.wang@canonical.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=rjw@rjwysocki.net \
    --cc=robert.moore@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.