All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mn10300: Select CONFIG_HAVE_UID16 to fix build failure
@ 2015-11-28 16:57 Guenter Roeck
  2015-11-30  9:14 ` Arnd Bergmann
  2015-11-30 13:40 ` David Howells
  0 siblings, 2 replies; 5+ messages in thread
From: Guenter Roeck @ 2015-11-28 16:57 UTC (permalink / raw)
  To: David Howells
  Cc: Koichi Yasutake, linux-am33-list, linux-kernel, Guenter Roeck,
	Arnd Bergmann

mn10300 builds fail with

fs/stat.c: In function 'cp_old_stat':
fs/stat.c:163:2: error: 'old_uid_t' undeclared

ipc/util.c: In function 'ipc64_perm_to_ipc_perm':
ipc/util.c:540:2: error: 'old_uid_t' undeclared

Select CONFIG_HAVE_UID16 and remove local definition of CONFIG_UID16
to fix the problem.

Fixes: fbc416ff8618 ("arm64: fix building without CONFIG_UID16")
Cc: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 arch/mn10300/Kconfig | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/arch/mn10300/Kconfig b/arch/mn10300/Kconfig
index 4434b54e1d87..78ae5552fdb8 100644
--- a/arch/mn10300/Kconfig
+++ b/arch/mn10300/Kconfig
@@ -1,6 +1,7 @@
 config MN10300
 	def_bool y
 	select HAVE_OPROFILE
+	select HAVE_UID16
 	select GENERIC_IRQ_SHOW
 	select ARCH_WANT_IPC_PARSE_VERSION
 	select HAVE_ARCH_TRACEHOOK
@@ -37,9 +38,6 @@ config HIGHMEM
 config NUMA
 	def_bool n
 
-config UID16
-	def_bool y
-
 config RWSEM_GENERIC_SPINLOCK
 	def_bool y
 
-- 
2.1.4


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] mn10300: Select CONFIG_HAVE_UID16 to fix build failure
  2015-11-28 16:57 [PATCH] mn10300: Select CONFIG_HAVE_UID16 to fix build failure Guenter Roeck
@ 2015-11-30  9:14 ` Arnd Bergmann
  2015-11-30 13:40 ` David Howells
  1 sibling, 0 replies; 5+ messages in thread
From: Arnd Bergmann @ 2015-11-30  9:14 UTC (permalink / raw)
  To: Guenter Roeck
  Cc: David Howells, Koichi Yasutake, linux-am33-list, linux-kernel

On Saturday 28 November 2015 08:57:57 Guenter Roeck wrote:
> mn10300 builds fail with
> 
> fs/stat.c: In function 'cp_old_stat':
> fs/stat.c:163:2: error: 'old_uid_t' undeclared
> 
> ipc/util.c: In function 'ipc64_perm_to_ipc_perm':
> ipc/util.c:540:2: error: 'old_uid_t' undeclared
> 
> Select CONFIG_HAVE_UID16 and remove local definition of CONFIG_UID16
> to fix the problem.
> 
> Fixes: fbc416ff8618 ("arm64: fix building without CONFIG_UID16")
> Cc: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> 

Acked-by: Arnd Bergmann <arnd@arndb.de>

sorry about causing this.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] mn10300: Select CONFIG_HAVE_UID16 to fix build failure
  2015-11-28 16:57 [PATCH] mn10300: Select CONFIG_HAVE_UID16 to fix build failure Guenter Roeck
  2015-11-30  9:14 ` Arnd Bergmann
@ 2015-11-30 13:40 ` David Howells
  2015-11-30 14:46   ` Guenter Roeck
  1 sibling, 1 reply; 5+ messages in thread
From: David Howells @ 2015-11-30 13:40 UTC (permalink / raw)
  To: Guenter Roeck
  Cc: dhowells, Koichi Yasutake, linux-am33-list, linux-kernel,
	Arnd Bergmann

Guenter Roeck <linux@roeck-us.net> wrote:

> mn10300 builds fail with
> 
> fs/stat.c: In function 'cp_old_stat':
> fs/stat.c:163:2: error: 'old_uid_t' undeclared
> 
> ipc/util.c: In function 'ipc64_perm_to_ipc_perm':
> ipc/util.c:540:2: error: 'old_uid_t' undeclared
> 
> Select CONFIG_HAVE_UID16 and remove local definition of CONFIG_UID16
> to fix the problem.
> 
> Fixes: fbc416ff8618 ("arm64: fix building without CONFIG_UID16")
> Cc: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

Acked-by: David Howells <dhowells@redhat.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] mn10300: Select CONFIG_HAVE_UID16 to fix build failure
  2015-11-30 13:40 ` David Howells
@ 2015-11-30 14:46   ` Guenter Roeck
  2015-11-30 14:52     ` David Howells
  0 siblings, 1 reply; 5+ messages in thread
From: Guenter Roeck @ 2015-11-30 14:46 UTC (permalink / raw)
  To: David Howells
  Cc: Koichi Yasutake, linux-am33-list, linux-kernel, Arnd Bergmann

On 11/30/2015 05:40 AM, David Howells wrote:
> Guenter Roeck <linux@roeck-us.net> wrote:
>
>> mn10300 builds fail with
>>
>> fs/stat.c: In function 'cp_old_stat':
>> fs/stat.c:163:2: error: 'old_uid_t' undeclared
>>
>> ipc/util.c: In function 'ipc64_perm_to_ipc_perm':
>> ipc/util.c:540:2: error: 'old_uid_t' undeclared
>>
>> Select CONFIG_HAVE_UID16 and remove local definition of CONFIG_UID16
>> to fix the problem.
>>
>> Fixes: fbc416ff8618 ("arm64: fix building without CONFIG_UID16")
>> Cc: Arnd Bergmann <arnd@arndb.de>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>
> Acked-by: David Howells <dhowells@redhat.com>
>

David,

your Acked-by: seems to suggest that you don't plan to send this
patch to Linus. At the same time, it looks like Koichi Yasutake's
e-mail address is no longer valid.

Do you want me to send it directly ?

Thanks,
Guenter


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] mn10300: Select CONFIG_HAVE_UID16 to fix build failure
  2015-11-30 14:46   ` Guenter Roeck
@ 2015-11-30 14:52     ` David Howells
  0 siblings, 0 replies; 5+ messages in thread
From: David Howells @ 2015-11-30 14:52 UTC (permalink / raw)
  To: Guenter Roeck
  Cc: dhowells, Koichi Yasutake, linux-am33-list, linux-kernel,
	Arnd Bergmann

Guenter Roeck <linux@roeck-us.net> wrote:

> your Acked-by: seems to suggest that you don't plan to send this
> patch to Linus. At the same time, it looks like Koichi Yasutake's
> e-mail address is no longer valid.
> 
> Do you want me to send it directly ?

Please do.

Thanks,
David

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2015-11-30 14:52 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-28 16:57 [PATCH] mn10300: Select CONFIG_HAVE_UID16 to fix build failure Guenter Roeck
2015-11-30  9:14 ` Arnd Bergmann
2015-11-30 13:40 ` David Howells
2015-11-30 14:46   ` Guenter Roeck
2015-11-30 14:52     ` David Howells

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.