All of lore.kernel.org
 help / color / mirror / Atom feed
From: Austin S Hemmelgarn <ahferroin7@gmail.com>
To: Jeff Mahoney <jeffm@suse.com>,
	Christoph Anton Mitterer <calestyo@scientia.net>,
	linux-btrfs@vger.kernel.org
Subject: Re: shall distros run btrfsck on boot?
Date: Mon, 30 Nov 2015 10:06:57 -0500	[thread overview]
Message-ID: <565C6611.1000405@gmail.com> (raw)
In-Reply-To: <5659DBD9.1070802@suse.com>

[-- Attachment #1: Type: text/plain, Size: 1623 bytes --]

On 2015-11-28 11:52, Jeff Mahoney wrote:
> On 11/23/15 11:02 PM, Christoph Anton Mitterer wrote:
>> Hey.
>>
>> Short question since that came up on debian-devel.
>>
>> Now that btrfs check get's more and more useful, are the
>> developers going to recommend running it periodically on boot (of
>> course that wouldn't work right now, as it would *always* check)?
>
> Running fsck on boot is a holdover from an era where non-journaling
> file systems were the norm.  It persists in the ext* world mostly due
> to inertia, but it shouldn't be run on boot with ext3 or ext4 either.
>   As Eric noted, fsck.xfs is a no-op.  We have something similar for
> btrfs and have no intention of ever running fsck on boot with btrfs
> except in the case of a mount failure of the root file system.
The bit about ext* is debatable, the code doesn't appear to do any 
automatic repairs on an online filesystem like XFS does (and BTRFS does 
when you scrub it), which would indicate to me that it should be run, 
but not forced on boot for ext3/4, assuming the FS is configured sanely 
(which means on the systems I manage, it only gets run at most once 
every 24 hours unless I break into the boot sequence and force it manually).
>
>> Plus... is btrfs check (without any arguments) non-desctructive, or
>> are there corner-cases where it may lead to any changes on the
>> devices?
>
> I haven't reviewed it in detail, but a quick glance makes it look like
> it will, minimally, create transactions even in check-only mode.
I agree with Qu here, if this is the case, it's a bug that needs to be 
fixed.



[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 3019 bytes --]

      parent reply	other threads:[~2015-11-30 15:07 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-24  4:02 shall distros run btrfsck on boot? Christoph Anton Mitterer
2015-11-24  4:31 ` Wang Shilong
2015-11-24  4:35 ` Duncan
2015-11-24  4:40   ` Eric Sandeen
2015-11-24  4:43   ` Christoph Anton Mitterer
2015-11-24  5:33     ` Qu Wenruo
2015-11-24  6:46     ` Duncan
2015-11-24  6:56       ` Duncan
2015-11-24 17:14         ` Eric Sandeen
2015-11-24 17:23           ` Christoph Anton Mitterer
2015-11-24 20:38             ` Austin S Hemmelgarn
2015-11-24 22:26               ` Eric Sandeen
2015-11-24 22:33                 ` Hugo Mills
2015-11-24 23:01                   ` Christoph Anton Mitterer
2015-11-24 23:06                     ` Hugo Mills
2015-11-25  1:59                   ` shall distros run btrfsck on boot?(Off topic, btrfs per-inode tree idea) Qu Wenruo
2015-11-25 12:32                 ` shall distros run btrfsck on boot? Austin S Hemmelgarn
2015-11-25 15:26                   ` Martin Steigerwald
2015-11-28 16:52 ` Jeff Mahoney
2015-11-30  1:59   ` Qu Wenruo
2015-11-30 19:27     ` Jeff Mahoney
2015-11-30 15:06   ` Austin S Hemmelgarn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=565C6611.1000405@gmail.com \
    --to=ahferroin7@gmail.com \
    --cc=calestyo@scientia.net \
    --cc=jeffm@suse.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.