From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Brendan Gregg <bgregg@netflix.com>, xen-devel@lists.xen.org
Cc: dietmar.hahn@ts.fujitsu.com
Subject: Re: [PATCH v3] x86/VPMU: implement ipc and arch filter flags
Date: Mon, 30 Nov 2015 14:56:03 -0500 [thread overview]
Message-ID: <565CA9D3.9030808@oracle.com> (raw)
In-Reply-To: <1448499732-3891-1-git-send-email-bgregg@netflix.com>
On 11/25/2015 08:02 PM, Brendan Gregg wrote:
> This introduces a way to have a restricted VPMU, by specifying one of two
> predefined groups of PMCs to make available. For secure environments, this
> allows the VPMU to be used without needing to enable all PMCs.
>
> Signed-off-by: Brendan Gregg <bgregg@netflix.com>
> ---
> Changes in v3:
> * addressing review comments from Boris:
> * ensure final flag is validated
> * code tidy
>
> Changes in v2:
> * feature flags can now be combined (eg, "vpmu=ipc,bts")
> * addressing review comments from Boris:
> * restrict DS_AREA and PEBS_ENABLE access when filters are in use
> * better variable types
> * include MSR_IA32_CMT_EVTSEL_UE_MASK flag
> ---
> docs/misc/xen-command-line.markdown | 14 +++++++++-
> xen/arch/x86/cpu/vpmu.c | 51 +++++++++++++++++++++++++++++--------
> xen/arch/x86/cpu/vpmu_intel.c | 49 +++++++++++++++++++++++++++++++++++
> xen/include/asm-x86/msr-index.h | 1 +
> xen/include/public/pmu.h | 14 ++++++++--
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
prev parent reply other threads:[~2015-11-30 19:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-26 1:02 [PATCH v3] x86/VPMU: implement ipc and arch filter flags Brendan Gregg
2015-11-30 19:56 ` Boris Ostrovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565CA9D3.9030808@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=bgregg@netflix.com \
--cc=dietmar.hahn@ts.fujitsu.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.