From: xuejiancheng@huawei.com (xuejiancheng)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/5] ARM: hisi: enable Hi3519 soc
Date: Tue, 1 Dec 2015 10:56:04 +0800 [thread overview]
Message-ID: <565D0C44.6010502@huawei.com> (raw)
In-Reply-To: <7hlh9f828y.fsf@deeprootsystems.com>
Hi Kevin,
Thank you for your suggestions.
On 2015/12/1 8:02, Kevin Hilman wrote:
> Jiancheng Xue <xuejiancheng@huawei.com> writes:
>
>> Hi3519 SOC is mainly used for ip camera and sport dv
>> solutions.
>>
>> Signed-off-by: Jiancheng Xue <xuejiancheng@huawei.com>
>> ---
>> arch/arm/mach-hisi/Kconfig | 9 +++++++++
>> arch/arm/mach-hisi/hisilicon.c | 9 +++++++++
>> 2 files changed, 18 insertions(+)
>>
>> diff --git a/arch/arm/mach-hisi/Kconfig b/arch/arm/mach-hisi/Kconfig
>> index 83061ad..6bb822c 100644
>> --- a/arch/arm/mach-hisi/Kconfig
>> +++ b/arch/arm/mach-hisi/Kconfig
>> @@ -48,6 +48,15 @@ config ARCH_HIX5HD2
>> select PINCTRL_SINGLE
>> help
>> Support for Hisilicon HIX5HD2 SoC family
>> +
>> +config ARCH_HI3519
>
> Please keep these sorted alphabetically.
Sorry about that. I will correct it in next version.
>
> Speaking of which, there is already an existing ARCH_HI3xxx entry.
> Should this be included in that family? If not, maybe the HI3xxx
> should be renamed HI36xx ?
ARCH_HI3xxx just represents Hi36xx mobile soc family. Hi3519 is not included.
It's good advice to rename HI3xxx to HI36xx.
> Kevin
>
> .
>
Many thanks,
Jiacheng
WARNING: multiple messages have this Message-ID (diff)
From: xuejiancheng <xuejiancheng@huawei.com>
To: Kevin Hilman <khilman@kernel.org>
Cc: <linux@arm.linux.org.uk>, <arnd@arndb.de>, <olof@lixom.net>,
<xuwei5@hisilicon.com>, <haojian.zhuang@linaro.org>,
<zhangfei.gao@linaro.org>, <bintian.wang@huawei.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linuxarm@huawei.com>,
<yanhaifeng@hisilicon.com>, <yanghongwei@hisilicon.com>,
<suwenping@hisilicon.com>, <ml.yang@hisilicon.com>
Subject: Re: [PATCH 2/5] ARM: hisi: enable Hi3519 soc
Date: Tue, 1 Dec 2015 10:56:04 +0800 [thread overview]
Message-ID: <565D0C44.6010502@huawei.com> (raw)
In-Reply-To: <7hlh9f828y.fsf@deeprootsystems.com>
Hi Kevin,
Thank you for your suggestions.
On 2015/12/1 8:02, Kevin Hilman wrote:
> Jiancheng Xue <xuejiancheng@huawei.com> writes:
>
>> Hi3519 SOC is mainly used for ip camera and sport dv
>> solutions.
>>
>> Signed-off-by: Jiancheng Xue <xuejiancheng@huawei.com>
>> ---
>> arch/arm/mach-hisi/Kconfig | 9 +++++++++
>> arch/arm/mach-hisi/hisilicon.c | 9 +++++++++
>> 2 files changed, 18 insertions(+)
>>
>> diff --git a/arch/arm/mach-hisi/Kconfig b/arch/arm/mach-hisi/Kconfig
>> index 83061ad..6bb822c 100644
>> --- a/arch/arm/mach-hisi/Kconfig
>> +++ b/arch/arm/mach-hisi/Kconfig
>> @@ -48,6 +48,15 @@ config ARCH_HIX5HD2
>> select PINCTRL_SINGLE
>> help
>> Support for Hisilicon HIX5HD2 SoC family
>> +
>> +config ARCH_HI3519
>
> Please keep these sorted alphabetically.
Sorry about that. I will correct it in next version.
>
> Speaking of which, there is already an existing ARCH_HI3xxx entry.
> Should this be included in that family? If not, maybe the HI3xxx
> should be renamed HI36xx ?
ARCH_HI3xxx just represents Hi36xx mobile soc family. Hi3519 is not included.
It's good advice to rename HI3xxx to HI36xx.
> Kevin
>
> .
>
Many thanks,
Jiacheng
next prev parent reply other threads:[~2015-12-01 2:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-28 7:15 [PATCH 2/5] ARM: hisi: enable Hi3519 soc Jiancheng Xue
2015-11-28 7:15 ` Jiancheng Xue
2015-12-01 0:02 ` Kevin Hilman
2015-12-01 0:02 ` Kevin Hilman
2015-12-01 2:56 ` xuejiancheng [this message]
2015-12-01 2:56 ` xuejiancheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565D0C44.6010502@huawei.com \
--to=xuejiancheng@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.