[PATCH] toolchain-scripts.bbclass: unset command_not_found_handle

[PATCH] toolchain-scripts.bbclass: unset command_not_found_handle

[Fang Jia]

On Ubuntu-system, When sourcing the env.sh from an exported sdk, and
running a bogus linux command (for example "asd"), a core dump of
python is usually generated.

Unset the command_not_found_handle to fix it.

Signed-off-by: Fang Jia <fang.jia@windriver.com>
---
 meta/classes/toolchain-scripts.bbclass | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/classes/toolchain-scripts.bbclass b/meta/classes/toolchain-scripts.bbclass
index d0b2b91..ab4feb0 100644
--- a/meta/classes/toolchain-scripts.bbclass
+++ b/meta/classes/toolchain-scripts.bbclass
@@ -32,6 +32,7 @@ toolchain_create_sdk_env_script () {
 	echo 'export OECORE_TARGET_SYSROOT="$SDKTARGETSYSROOT"' >> $script
 	echo "export OECORE_ACLOCAL_OPTS=\"-I $sdkpathnative/usr/share/aclocal\"" >> $script
 	echo "export PYTHONHOME=$sdkpathnative$prefix" >> $script
+	echo 'unset command_not_found_handle' >> $script
 
 	toolchain_shared_env_script
 }
-- 
1.9.1

Re: [PATCH] toolchain-scripts.bbclass: unset command_not_found_handle

[Christopher Larson]

[-- Attachment #1: Type: text/plain, Size: 694 bytes --]

On Mon, Nov 30, 2015 at 3:50 AM, Fang Jia <fang.jia@windriver.com> wrote:

> On Ubuntu-system, When sourcing the env.sh from an exported sdk, and
> running a bogus linux command (for example "asd"), a core dump of
> python is usually generated.
>
> Unset the command_not_found_handle to fix it.
>
> Signed-off-by: Fang Jia <fang.jia@windriver.com>
>

Will this syntax be valid for non-bash environments? What about dash and
zsh? You have to be careful to use portable constructs in a script which is
sourced like this.
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics

[-- Attachment #2: Type: text/html, Size: 1154 bytes --]

Re: [PATCH] toolchain-scripts.bbclass: unset command_not_found_handle

[Robert Yang]

On 12/01/2015 11:48 AM, Christopher Larson wrote:
> On Mon, Nov 30, 2015 at 3:50 AM, Fang Jia <fang.jia@windriver.com
> <mailto:fang.jia@windriver.com>> wrote:
>
>     On Ubuntu-system, When sourcing the env.sh from an exported sdk, and
>     running a bogus linux command (for example "asd"), a core dump of
>     python is usually generated.
>
>     Unset the command_not_found_handle to fix it.
>
>     Signed-off-by: Fang Jia <fang.jia@windriver.com <mailto:fang.jia@windriver.com>>
>
>
> Will this syntax be valid for non-bash environments? What about dash and zsh?

unset is part of posix shell, I think it's fine to use it here.

// Robert

> You have to be careful to use portable constructs in a script which is sourced
> like this.
> --
> Christopher Larson
> clarson at kergoth dot com
> Founder - BitBake, OpenEmbedded, OpenZaurus
> Maintainer - Tslib
> Senior Software Engineer, Mentor Graphics
>
>

Re: [PATCH] toolchain-scripts.bbclass: unset command_not_found_handle

[Christopher Larson]

[-- Attachment #1: Type: text/plain, Size: 1043 bytes --]

On Mon, Nov 30, 2015 at 11:04 PM, Robert Yang <liezhi.yang@windriver.com>
wrote:

> On 12/01/2015 11:48 AM, Christopher Larson wrote:
>
>> On Mon, Nov 30, 2015 at 3:50 AM, Fang Jia <fang.jia@windriver.com
>> <mailto:fang.jia@windriver.com>> wrote:
>>
>>     On Ubuntu-system, When sourcing the env.sh from an exported sdk, and
>>     running a bogus linux command (for example "asd"), a core dump of
>>     python is usually generated.
>>
>>     Unset the command_not_found_handle to fix it.
>>
>>     Signed-off-by: Fang Jia <fang.jia@windriver.com <mailto:
>> fang.jia@windriver.com>>
>>
>>
>> Will this syntax be valid for non-bash environments? What about dash and
>> zsh?
>>
>
> unset is part of posix shell, I think it's fine to use it here.


Ah, good point, for some reason I read it as unsetopt, but yes, clearly
unset is portable, ignore me. :)
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics

[-- Attachment #2: Type: text/html, Size: 1882 bytes --]