All of lore.kernel.org
 help / color / mirror / Atom feed
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/6] net: thunderx: Force to load octeon-mdio before bgx driver.
Date: Tue, 1 Dec 2015 16:17:56 +0300	[thread overview]
Message-ID: <565D9E04.8010203@cogentembedded.com> (raw)
In-Reply-To: <1448961223-41888-2-git-send-email-sunil.kovvuri@gmail.com>

Hello.

On 12/1/2015 12:13 PM, Sunil Goutham wrote:

> From: Thanneeru Srinivasulu <tsrinivasulu@caviumnetworks.com>
>
> Signed-off-by: Thanneeru Srinivasulu <tsrinivasulu@caviumnetworks.com>
> Signed-off-by: Sunil Goutham <sgoutham@cavium.com>
> ---
>   drivers/net/ethernet/cavium/thunder/thunder_bgx.c |    3 +++
>   drivers/net/ethernet/cavium/thunder/thunder_bgx.h |    1 +
>   2 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
> index 180aa9f..1fb72dd 100644
> --- a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
> +++ b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
> @@ -1009,6 +1009,9 @@ static int bgx_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>   	struct bgx *bgx = NULL;
>   	u8 lmac;
>
> +	/*Load octeon mdio driver*/

    Please insert spaces after /* and before */ (unless it's a common comment 
style in this driver).

[...]

MBR, Sergei

WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Sunil Goutham <sunil.kovvuri@gmail.com>, netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Sunil.Goutham@caviumnetworks.com,
	Thanneeru Srinivasulu <tsrinivasulu@caviumnetworks.com>,
	Sunil Goutham <sgoutham@cavium.com>
Subject: Re: [PATCH 1/6] net: thunderx: Force to load octeon-mdio before bgx driver.
Date: Tue, 1 Dec 2015 16:17:56 +0300	[thread overview]
Message-ID: <565D9E04.8010203@cogentembedded.com> (raw)
In-Reply-To: <1448961223-41888-2-git-send-email-sunil.kovvuri@gmail.com>

Hello.

On 12/1/2015 12:13 PM, Sunil Goutham wrote:

> From: Thanneeru Srinivasulu <tsrinivasulu@caviumnetworks.com>
>
> Signed-off-by: Thanneeru Srinivasulu <tsrinivasulu@caviumnetworks.com>
> Signed-off-by: Sunil Goutham <sgoutham@cavium.com>
> ---
>   drivers/net/ethernet/cavium/thunder/thunder_bgx.c |    3 +++
>   drivers/net/ethernet/cavium/thunder/thunder_bgx.h |    1 +
>   2 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
> index 180aa9f..1fb72dd 100644
> --- a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
> +++ b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
> @@ -1009,6 +1009,9 @@ static int bgx_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>   	struct bgx *bgx = NULL;
>   	u8 lmac;
>
> +	/*Load octeon mdio driver*/

    Please insert spaces after /* and before */ (unless it's a common comment 
style in this driver).

[...]

MBR, Sergei


  reply	other threads:[~2015-12-01 13:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-01  9:13 [PATCH 1/6] net: thunderx: Force to load octeon-mdio before bgx driver Sunil Goutham
2015-12-01  9:13 ` Sunil Goutham
2015-12-01 13:17 ` Sergei Shtylyov [this message]
2015-12-01 13:17   ` Sergei Shtylyov
2015-12-01 16:24   ` Sunil Kovvuri
2015-12-01 16:24     ` Sunil Kovvuri

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=565D9E04.8010203@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.