From: Loic Dachary <loic@dachary.org>
To: Wido den Hollander <wido@42on.com>,
"ceph-devel@vger.kernel.org" <ceph-devel@vger.kernel.org>
Subject: Re: CodingStyle on existing code
Date: Tue, 1 Dec 2015 14:47:47 +0100 [thread overview]
Message-ID: <565DA503.9000401@dachary.org> (raw)
In-Reply-To: <565D9C37.3060903@42on.com>
[-- Attachment #1: Type: text/plain, Size: 833 bytes --]
On 01/12/2015 14:10, Wido den Hollander wrote:
> Hi,
>
> While working on mon/PGMonitor.cc I see that there is a lot of
> inconsistency on the code.
>
> A lot of whitespaces, indentation which is not correct, well, a lot of
> things.
>
> Is this something we want to fix? With some scripts we can probably do
> this easily, but it might cause merge hell with people working on features.
A sane (but long) way to do that is to cleanup when fixing a bug or adding a feature. With (a lot) of patience, it will eventually be better :-)
My 2cts.
> Wido
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Loïc Dachary, Artisan Logiciel Libre
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2015-12-01 13:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-01 13:10 CodingStyle on existing code Wido den Hollander
2015-12-01 13:47 ` Loic Dachary [this message]
2015-12-01 15:00 ` Gregory Farnum
2015-12-01 15:16 ` Wido den Hollander
2015-12-01 15:18 ` Sage Weil
2015-12-03 11:12 ` Joao Eduardo Luis
2015-12-09 23:16 ` Wido den Hollander
2015-12-09 23:28 ` Joao Eduardo Luis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565DA503.9000401@dachary.org \
--to=loic@dachary.org \
--cc=ceph-devel@vger.kernel.org \
--cc=wido@42on.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.