Re: [Qemu-devel] [PATCH v13 00/14] qapi member collision (post-introspection cleanups, subset D)

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1189 bytes --]

On 11/27/2015 02:56 AM, Markus Armbruster wrote:
> Eric Blake <eblake@redhat.com> writes:
> 
>> Pending prerequisites:
>> + Markus' "typedefs: Put them back into alphabetical order"
>> https://lists.gnu.org/archive/html/qemu-devel/2015-11/msg04417.html
>> + Markus' qapi-next branch
>> http://repo.or.cz/qemu/armbru.git/shortlog/refs/heads/qapi-next
>>
>> Also available as a tag at this location:
>> git fetch git://repo.or.cz/qemu/ericb.git qapi-cleanupv13d
>>
>> and will soon be part of my branch with the rest of the v5 series, at:
>> http://repo.or.cz/qemu/ericb.git/shortlog/refs/heads/qapi
> 
> I'm not too fond of PATCH 11, but can't see a better way to do what it
> does.  However, I don't yet understand why doing it is useful.  I
> inquired about its use in PATCH 12, perhaps you can enlighten me there.

Hopefully I've done just that in my reply on 12; but I will also try and
enhance the commit messages to call things out.

> 
> Other than that, just a few nitpicks.  One more respin should take care
> of them.

Coming up later today.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]