Re: [Qemu-devel] [PATCH v13 12/14] qapi: Enforce (or whitelist) case conventions on qapi members

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 959 bytes --]

On 12/02/2015 01:20 AM, Markus Armbruster wrote:

> Hmm, this shows my use of "qapi-introspect.py -u" to find the externally
> visible part of QAPI is flawed.
> 
> To make it work, we'd need QOM introspection, which we might want
> anyway.
> 
> Additionally, a way to output just JSON rather than JSON encoded in C
> would be nice.

'qapi-introspect.py -u' is already for debugging purposes.  Would it be
sufficient to have it do this in qmp-introspect.c?

const char qmp_schema_json[] = "["
    "{\"arg-type\": \":obj-ACPI_DVICE_OST-arg\", \"meta-type\":
\"event\", \"name\": \"ACPI_DEVICE_OST\"}, "
...
";

/* The same, as straight JSON:

[
    {"arg-type": ":obj-ACPI_DVICE_OST-arg", "meta-type": "event",
"name": "ACPI_DEVICE_OST"},
...
]

*/

If so, that's an easy patch (just visit things twice under -u mode).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]