From: salil.mehta@huawei.com (Salil Mehta)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V5 net-next 1/5] net:hns: Add support of Hip06 SoC to the Hislicon Network Subsystem
Date: Wed, 2 Dec 2015 17:02:08 +0000 [thread overview]
Message-ID: <565F2410.9040607@huawei.com> (raw)
In-Reply-To: <20151130.145057.216796732457000987.davem@davemloft.net>
On 11/30/2015 7:50 PM, David Miller wrote:
> From: Salil Mehta <salil.mehta@huawei.com>
> Date: Thu, 26 Nov 2015 07:14:06 +0000
>
>> -#define ENABLE (0x1)
>> -#define DISABLE (0x0)
>> +#define ENABLE 0x1
>> +#define DISABLE 0x0
> Defining such common macros names for such incredibly simple boolean values
> is asking for trouble, in particular it can possibly collide with other
> defines in the global namespace.
>
> Use "true", "false", and the "bool" type, because that is exactly how you
> are using these values.
>
> Thanks.
Hi David,
Thanks for your suggestions. I have worked upon the comments and removed
these macros
and introduced the 'bool' type here as well. I think I missed this in my
earlier rework. Thanks
again for pointing it out. I have floated new V6 patch for your
consideration.
Best Regards
Salil
>
WARNING: multiple messages have this Message-ID (diff)
From: Salil Mehta <salil.mehta@huawei.com>
To: David Miller <davem@davemloft.net>
Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
paul.gortmaker@windriver.com, ijc+devicetree@hellion.org.uk,
galak@codeaurora.org, catalin.marinas@arm.com,
will.deacon@arm.com, arnd@arndb.de, liguozhu@hisilicon.com,
yisen.zhuang@huawei.com, dingtianhong@huawei.com,
zhangfei.gao@linaro.org, huangdaode@hisilicon.com,
kenneth-lee-2012@foxmail.com, mehta.salil.lnk@gmail.com,
xuwei5@hisilicon.com, lisheng011@huawei.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
linuxarm@huawei.com, yankejian@huawei.com, lipeng321@huawei.com,
fengguang.wu@intel.com
Subject: Re: [PATCH V5 net-next 1/5] net:hns: Add support of Hip06 SoC to the Hislicon Network Subsystem
Date: Wed, 2 Dec 2015 17:02:08 +0000 [thread overview]
Message-ID: <565F2410.9040607@huawei.com> (raw)
In-Reply-To: <20151130.145057.216796732457000987.davem@davemloft.net>
On 11/30/2015 7:50 PM, David Miller wrote:
> From: Salil Mehta <salil.mehta@huawei.com>
> Date: Thu, 26 Nov 2015 07:14:06 +0000
>
>> -#define ENABLE (0x1)
>> -#define DISABLE (0x0)
>> +#define ENABLE 0x1
>> +#define DISABLE 0x0
> Defining such common macros names for such incredibly simple boolean values
> is asking for trouble, in particular it can possibly collide with other
> defines in the global namespace.
>
> Use "true", "false", and the "bool" type, because that is exactly how you
> are using these values.
>
> Thanks.
Hi David,
Thanks for your suggestions. I have worked upon the comments and removed
these macros
and introduced the 'bool' type here as well. I think I missed this in my
earlier rework. Thanks
again for pointing it out. I have floated new V6 patch for your
consideration.
Best Regards
Salil
>
WARNING: multiple messages have this Message-ID (diff)
From: Salil Mehta <salil.mehta@huawei.com>
To: David Miller <davem@davemloft.net>
Cc: <robh+dt@kernel.org>, <pawel.moll@arm.com>,
<mark.rutland@arm.com>, <paul.gortmaker@windriver.com>,
<ijc+devicetree@hellion.org.uk>, <galak@codeaurora.org>,
<catalin.marinas@arm.com>, <will.deacon@arm.com>, <arnd@arndb.de>,
<liguozhu@hisilicon.com>, <yisen.zhuang@huawei.com>,
<dingtianhong@huawei.com>, <zhangfei.gao@linaro.org>,
<huangdaode@hisilicon.com>, <kenneth-lee-2012@foxmail.com>,
<mehta.salil.lnk@gmail.com>, <xuwei5@hisilicon.com>,
<lisheng011@huawei.com>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <netdev@vger.kernel.org>,
<linuxarm@huawei.com>, <yankejian@huawei.com>,
<lipeng321@huawei.com>, <fengguang.wu@intel.com>
Subject: Re: [PATCH V5 net-next 1/5] net:hns: Add support of Hip06 SoC to the Hislicon Network Subsystem
Date: Wed, 2 Dec 2015 17:02:08 +0000 [thread overview]
Message-ID: <565F2410.9040607@huawei.com> (raw)
In-Reply-To: <20151130.145057.216796732457000987.davem@davemloft.net>
On 11/30/2015 7:50 PM, David Miller wrote:
> From: Salil Mehta <salil.mehta@huawei.com>
> Date: Thu, 26 Nov 2015 07:14:06 +0000
>
>> -#define ENABLE (0x1)
>> -#define DISABLE (0x0)
>> +#define ENABLE 0x1
>> +#define DISABLE 0x0
> Defining such common macros names for such incredibly simple boolean values
> is asking for trouble, in particular it can possibly collide with other
> defines in the global namespace.
>
> Use "true", "false", and the "bool" type, because that is exactly how you
> are using these values.
>
> Thanks.
Hi David,
Thanks for your suggestions. I have worked upon the comments and removed
these macros
and introduced the 'bool' type here as well. I think I missed this in my
earlier rework. Thanks
again for pointing it out. I have floated new V6 patch for your
consideration.
Best Regards
Salil
>
next prev parent reply other threads:[~2015-12-02 17:02 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-26 7:14 [PATCH V5 net-next 0/5] net:hns: Add support of Hip06 SoC to the Hislicon Network Subsystem Salil Mehta
2015-11-26 7:14 ` Salil Mehta
2015-11-26 7:14 ` Salil Mehta
2015-11-26 7:14 ` Salil Mehta
2015-11-26 7:14 ` [PATCH V5 net-next 1/5] " Salil Mehta
2015-11-26 7:14 ` Salil Mehta
2015-11-26 7:14 ` Salil Mehta
2015-11-30 19:50 ` David Miller
2015-11-30 19:50 ` David Miller
2015-11-30 19:50 ` David Miller
2015-12-02 17:02 ` Salil Mehta [this message]
2015-12-02 17:02 ` Salil Mehta
2015-12-02 17:02 ` Salil Mehta
2015-11-26 7:14 ` [PATCH V5 net-next 2/5] net:hns: Add Hip06 "RSS(Receive Side Scaling)" support to HNS Driver Salil Mehta
2015-11-26 7:14 ` Salil Mehta
2015-11-26 7:14 ` Salil Mehta
2015-11-26 7:14 ` Salil Mehta
2015-11-26 7:14 ` [PATCH V5 net-next 3/5] net:hns: Add Hip06 "TSO(TCP Segment Offload)" support " Salil Mehta
2015-11-26 7:14 ` Salil Mehta
2015-11-26 7:14 ` Salil Mehta
2015-11-26 7:14 ` [PATCH V5 net-next 4/5] net:hns: Add support of ethtool TSO set option for Hip06 in HNS Salil Mehta
2015-11-26 7:14 ` Salil Mehta
2015-11-26 7:14 ` Salil Mehta
2015-11-26 7:14 ` [PATCH V5 net-next 5/5] net:hns: Add the init code to disable Hip06 "Hardware VLAN assist" Salil Mehta
2015-11-26 7:14 ` Salil Mehta
2015-11-26 7:14 ` Salil Mehta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565F2410.9040607@huawei.com \
--to=salil.mehta@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.