All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Wahren <stefan.wahren@i2se.com>
To: Eric Anholt <eric@anholt.net>,
	Thierry Reding <thierry.reding@gmail.com>,
	Stephen Warren <swarren@wwwdotorg.org>,
	Lee Jones <lee@kernel.org>
Cc: Remi Pommarel <repk@triplefau.lt>,
	linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rpi-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] pwm: bcm2835: prevent division by zero
Date: Wed, 2 Dec 2015 18:08:45 +0100	[thread overview]
Message-ID: <565F259D.6060905@i2se.com> (raw)
In-Reply-To: <87h9k1yd2z.fsf@eliezer.anholt.net>

Am 02.12.2015 um 00:16 schrieb Eric Anholt:
> Stefan Wahren <stefan.wahren@i2se.com> writes:
>
>> It's possible that the pwm clock become an orphan. So better
>> check the result of clk_get_rate in order to prevent a division
>> by zero.
> How would we lose our clock when we're keeping the clock enabled from
> driver probe until remove?

It's not the problem that we lose the clock inside this driver. The pwm
clock could be initial assigned to a unregistered parent clock like "GND".

I'm refering to this discussion:

http://lists.infradead.org/pipermail/linux-rpi-kernel/2015-November/002603.html

>
> Patches 1 and 3 are:
>
> Reviewed-by: Eric Anholt <eric@anholt.net>

WARNING: multiple messages have this Message-ID (diff)
From: stefan.wahren@i2se.com (Stefan Wahren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] pwm: bcm2835: prevent division by zero
Date: Wed, 2 Dec 2015 18:08:45 +0100	[thread overview]
Message-ID: <565F259D.6060905@i2se.com> (raw)
In-Reply-To: <87h9k1yd2z.fsf@eliezer.anholt.net>

Am 02.12.2015 um 00:16 schrieb Eric Anholt:
> Stefan Wahren <stefan.wahren@i2se.com> writes:
>
>> It's possible that the pwm clock become an orphan. So better
>> check the result of clk_get_rate in order to prevent a division
>> by zero.
> How would we lose our clock when we're keeping the clock enabled from
> driver probe until remove?

It's not the problem that we lose the clock inside this driver. The pwm
clock could be initial assigned to a unregistered parent clock like "GND".

I'm refering to this discussion:

http://lists.infradead.org/pipermail/linux-rpi-kernel/2015-November/002603.html

>
> Patches 1 and 3 are:
>
> Reviewed-by: Eric Anholt <eric@anholt.net>

  reply	other threads:[~2015-12-02 17:09 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-01 22:55 [PATCH 0/3] pwm: bcm2835: improve clock handling Stefan Wahren
2015-12-01 22:55 ` Stefan Wahren
2015-12-01 22:55 ` [PATCH 1/3] pwm: bcm2835: calculate scaler in pwm_config Stefan Wahren
2015-12-01 22:55   ` Stefan Wahren
2015-12-01 22:55 ` [PATCH 2/3] pwm: bcm2835: prevent division by zero Stefan Wahren
2015-12-01 22:55   ` Stefan Wahren
2015-12-01 23:16   ` Eric Anholt
2015-12-01 23:16     ` Eric Anholt
2015-12-02 17:08     ` Stefan Wahren [this message]
2015-12-02 17:08       ` Stefan Wahren
2015-12-02 19:43       ` Eric Anholt
2015-12-02 19:43         ` Eric Anholt
2015-12-02 15:23   ` Mathieu Poirier
2015-12-02 15:23     ` Mathieu Poirier
2015-12-02 19:41     ` Eric Anholt
2015-12-02 19:41       ` Eric Anholt
2015-12-01 22:55 ` [PATCH 3/3] pwm: bcm2835: fix email address specifiction Stefan Wahren
2015-12-01 22:55   ` Stefan Wahren
2015-12-15 17:59 ` [PATCH 0/3] pwm: bcm2835: improve clock handling Stefan Wahren
2015-12-15 17:59   ` Stefan Wahren
2015-12-15 18:24   ` Eric Anholt
2015-12-15 18:24     ` Eric Anholt
2015-12-16 15:38 ` Thierry Reding
2015-12-16 15:38   ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=565F259D.6060905@i2se.com \
    --to=stefan.wahren@i2se.com \
    --cc=eric@anholt.net \
    --cc=lee@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=repk@triplefau.lt \
    --cc=swarren@wwwdotorg.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.