From: Qais Yousef <qais.yousef@imgtec.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
<linux-kernel@vger.kernel.org>
Cc: <tglx@linutronix.de>, <jason@lakedaemon.net>,
<marc.zyngier@arm.com>, <jiang.liu@linux.intel.com>,
<ralf@linux-mips.org>, <linux-mips@linux-mips.org>
Subject: Re: [PATCH v3 14/19] irqchip/mips-gic: Use gic_vpes instead of NR_CPUS
Date: Thu, 3 Dec 2015 09:52:01 +0000 [thread overview]
Message-ID: <566010C1.1000506@imgtec.com> (raw)
In-Reply-To: <565F3869.4020603@cogentembedded.com>
On 12/02/2015 06:28 PM, Sergei Shtylyov wrote:
>
>> @@ -1084,7 +1084,7 @@ static void __init __gic_init(unsigned long
>> gic_base_addr,
>> gic_ipi_domain->bus_token = DOMAIN_BUS_IPI;
>>
>> /* Make the last 2 * NR_CPUS available for IPIs */
>
> Looks like you forgot to also change this comment...
This code changes again in a later patch with the correct comment on.
I'll fix it in the next series.
Thanks,
Qais
WARNING: multiple messages have this Message-ID (diff)
From: Qais Yousef <qais.yousef@imgtec.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
linux-kernel@vger.kernel.org
Cc: tglx@linutronix.de, jason@lakedaemon.net, marc.zyngier@arm.com,
jiang.liu@linux.intel.com, ralf@linux-mips.org,
linux-mips@linux-mips.org
Subject: Re: [PATCH v3 14/19] irqchip/mips-gic: Use gic_vpes instead of NR_CPUS
Date: Thu, 3 Dec 2015 09:52:01 +0000 [thread overview]
Message-ID: <566010C1.1000506@imgtec.com> (raw)
Message-ID: <20151203095201.88x-8uLPUQeOzBbhyIXcgythhgn0B84SYpVwNRhI0HE@z> (raw)
In-Reply-To: <565F3869.4020603@cogentembedded.com>
On 12/02/2015 06:28 PM, Sergei Shtylyov wrote:
>
>> @@ -1084,7 +1084,7 @@ static void __init __gic_init(unsigned long
>> gic_base_addr,
>> gic_ipi_domain->bus_token = DOMAIN_BUS_IPI;
>>
>> /* Make the last 2 * NR_CPUS available for IPIs */
>
> Looks like you forgot to also change this comment...
This code changes again in a later patch with the correct comment on.
I'll fix it in the next series.
Thanks,
Qais
next prev parent reply other threads:[~2015-12-03 9:52 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-02 12:21 [PATCH v3 00/19] Implement generic IPI support mechanism Qais Yousef
2015-12-02 12:21 ` Qais Yousef
2015-12-02 12:21 ` [PATCH v3 01/19] genirq: Add new IRQ_DOMAIN_FLAGS_IPI Qais Yousef
2015-12-02 12:21 ` Qais Yousef
2015-12-02 12:21 ` [PATCH v3 02/19] genirq: Add DOMAIN_BUS_IPI Qais Yousef
2015-12-02 12:21 ` Qais Yousef
2015-12-02 12:21 ` [PATCH v3 03/19] genirq: Add GENERIC_IRQ_IPI Kconfig symbol Qais Yousef
2015-12-02 12:21 ` Qais Yousef
2015-12-02 12:21 ` [PATCH v3 04/19] genirq: Add struct ipi_mapping and its helper functions Qais Yousef
2015-12-02 12:21 ` Qais Yousef
2015-12-02 12:21 ` [PATCH v3 05/19] genirq: Add ipi_offset to irq_common_data Qais Yousef
2015-12-02 12:21 ` Qais Yousef
2015-12-02 12:21 ` [PATCH v3 06/19] genirq: Add an extra comment about the use of affinity in irq_common_data Qais Yousef
2015-12-02 12:21 ` Qais Yousef
2015-12-02 12:21 ` [PATCH v3 07/19] genirq: Make irq_domain_alloc_descs() non static Qais Yousef
2015-12-02 12:21 ` Qais Yousef
2015-12-02 12:21 ` [PATCH v3 08/19] genirq: Add a new generic IPI reservation code to irq core Qais Yousef
2015-12-02 12:21 ` Qais Yousef
2015-12-02 12:21 ` [PATCH v3 09/19] genirq: Add a new function to get IPI reverse mapping Qais Yousef
2015-12-02 12:21 ` Qais Yousef
2015-12-02 12:21 ` [PATCH v3 10/19] genirq: Add a new irq_send_ipi() to irq_chip Qais Yousef
2015-12-02 12:21 ` Qais Yousef
2015-12-02 12:21 ` [PATCH v3 11/19] genirq: Implement ipi_send_{mask, single}() Qais Yousef
2015-12-02 12:21 ` Qais Yousef
2015-12-02 12:21 ` [PATCH v3 12/19] irqchip/mips-gic: Add a IPI hierarchy domain Qais Yousef
2015-12-02 12:21 ` Qais Yousef
2015-12-02 12:21 ` [PATCH v3 13/19] irqchip/mips-gic: Add device " Qais Yousef
2015-12-02 12:21 ` Qais Yousef
2015-12-02 12:21 ` [PATCH v3 14/19] irqchip/mips-gic: Use gic_vpes instead of NR_CPUS Qais Yousef
2015-12-02 12:21 ` Qais Yousef
2015-12-02 18:28 ` Sergei Shtylyov
2015-12-03 9:52 ` Qais Yousef [this message]
2015-12-03 9:52 ` Qais Yousef
2015-12-02 12:21 ` [PATCH v3 15/19] irqchip/mips-gic: Clear percpu_masks correctly when mapping Qais Yousef
2015-12-02 12:21 ` Qais Yousef
2015-12-02 12:21 ` [PATCH v3 16/19] MIPS: Add generic SMP IPI support Qais Yousef
2015-12-02 12:21 ` Qais Yousef
2015-12-02 12:21 ` [PATCH v3 17/19] MIPS: Make smp CMP, CPS and MT use the new generic IPI functions Qais Yousef
2015-12-02 12:21 ` Qais Yousef
2015-12-02 12:21 ` [PATCH v3 18/19] MIPS: Delete smp-gic.c Qais Yousef
2015-12-02 12:21 ` Qais Yousef
2015-12-02 12:22 ` [PATCH v3 19/19] irqchip/mips-gic: Add new DT property to reserve IPIs Qais Yousef
2015-12-02 12:22 ` Qais Yousef
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566010C1.1000506@imgtec.com \
--to=qais.yousef@imgtec.com \
--cc=jason@lakedaemon.net \
--cc=jiang.liu@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=marc.zyngier@arm.com \
--cc=ralf@linux-mips.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.