From: Anna Schumaker <Anna.Schumaker@netapp.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: fstests@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: sys_copy_file_range tests
Date: Thu, 3 Dec 2015 15:43:32 -0500 [thread overview]
Message-ID: <5660A974.3010200@Netapp.com> (raw)
In-Reply-To: <20151201181011.GA6202@infradead.org>
Hi Christoph,
On 12/01/2015 01:10 PM, Christoph Hellwig wrote:
> Hi Anna,
>
> I recently looked into allowing sys_copy_file_range to use the
> clone_file_range operation so that file systems don't have to support
> two methods if they only support clone-like features, and one thing
> I noticed is that unlike for clone there are no tests for
> clone_file_range in xfstests, and I couldn't find a testsuite anywhere
> else either. Do you have any good tests available to verify the
> implementation?
>
Sadly, I don't have very good tests and I was mostly using the example program from the man page under various filesystems and setups. At LPC, Darrick made it sound like he was going to work on adding vfs_copy_file_range() tests to xfstests but that probably turned into the reflink/dedupe ioctl tests.
I can try to find time to write something for xfstests if that would be useful!
Anna
WARNING: multiple messages have this Message-ID (diff)
From: Anna Schumaker <Anna.Schumaker@netapp.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: <fstests@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>
Subject: Re: sys_copy_file_range tests
Date: Thu, 3 Dec 2015 15:43:32 -0500 [thread overview]
Message-ID: <5660A974.3010200@Netapp.com> (raw)
In-Reply-To: <20151201181011.GA6202@infradead.org>
Hi Christoph,
On 12/01/2015 01:10 PM, Christoph Hellwig wrote:
> Hi Anna,
>
> I recently looked into allowing sys_copy_file_range to use the
> clone_file_range operation so that file systems don't have to support
> two methods if they only support clone-like features, and one thing
> I noticed is that unlike for clone there are no tests for
> clone_file_range in xfstests, and I couldn't find a testsuite anywhere
> else either. Do you have any good tests available to verify the
> implementation?
>
Sadly, I don't have very good tests and I was mostly using the example program from the man page under various filesystems and setups. At LPC, Darrick made it sound like he was going to work on adding vfs_copy_file_range() tests to xfstests but that probably turned into the reflink/dedupe ioctl tests.
I can try to find time to write something for xfstests if that would be useful!
Anna
next prev parent reply other threads:[~2015-12-03 20:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-01 18:10 sys_copy_file_range tests Christoph Hellwig
2015-12-03 20:43 ` Anna Schumaker [this message]
2015-12-03 20:43 ` Anna Schumaker
2015-12-04 8:28 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5660A974.3010200@Netapp.com \
--to=anna.schumaker@netapp.com \
--cc=fstests@vger.kernel.org \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.