All of lore.kernel.org
 help / color / mirror / Atom feed
From: f.fainelli@gmail.com (Florian Fainelli)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 2/5] ARM: BCM: Clean up SMP support for Broadcom Kona
Date: Fri, 04 Dec 2015 15:07:15 -0800	[thread overview]
Message-ID: <56621CA3.3090903@gmail.com> (raw)
In-Reply-To: <1449260611-24417-3-git-send-email-kapilh@broadcom.com>

On 04/12/15 12:23, Kapil Hali wrote:
> These changes cleans up SMP implementaion for Broadcom's
> Kona SoC which are required for handling SMP for iProc
> family of SoCs at a single place for BCM NSP and BCM Kona.
> 
> Signed-off-by: Kapil Hali <kapilh@broadcom.com>
> ---
>  arch/arm/boot/dts/bcm11351.dtsi |  2 +-
>  arch/arm/boot/dts/bcm21664.dtsi |  2 +-
>  arch/arm/mach-bcm/kona_smp.c    | 82 +++++++++++++++++++++++++++--------------
>  3 files changed, 56 insertions(+), 30 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arch/arm/boot/dts/bcm11351.dtsi
> index 2ddaa51..3dc7a8c 100644
> --- a/arch/arm/boot/dts/bcm11351.dtsi
> +++ b/arch/arm/boot/dts/bcm11351.dtsi
> @@ -31,7 +31,6 @@
>  		#address-cells = <1>;
>  		#size-cells = <0>;
>  		enable-method = "brcm,bcm11351-cpu-method";
> -		secondary-boot-reg = <0x3500417c>;

I would expect the 'enable-method' to be moved as well to be consistent
with what you are adding for NSP later on.

>  
>  		cpu0: cpu at 0 {
>  			device_type = "cpu";
> @@ -42,6 +41,7 @@
>  		cpu1: cpu at 1 {
>  			device_type = "cpu";
>  			compatible = "arm,cortex-a9";
> +			secondary-boot-reg = <0x3500417c>;
>  			reg = <1>;
>  		};
-- 
Florian

WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli@gmail.com>
To: Kapil Hali <kapilh@broadcom.com>,
	Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Russell King <linux@arm.linux.org.uk>,
	Ray Jui <rjui@broadcom.com>,
	Scott Branden <sbranden@broadcom.com>,
	Jon Mason <jonmason@broadcom.com>,
	Florian Fainelli <f.fainelli@gmail.com>
Cc: Gregory Fong <gregory.0xf0@gmail.com>, Lee Jones <lee@kernel.org>,
	Hauke Mehrtens <hauke@hauke-m.de>,
	Kever Yang <kever.yang@rock-chips.com>,
	Maxime Ripard <maxime.ripard@free-electrons.com>,
	Olof Johansson <olof@lixom.net>, Paul Walmsley <paul@pwsan.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Chen-Yu Tsai <wens@csie.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH v5 2/5] ARM: BCM: Clean up SMP support for Broadcom Kona
Date: Fri, 04 Dec 2015 15:07:15 -0800	[thread overview]
Message-ID: <56621CA3.3090903@gmail.com> (raw)
In-Reply-To: <1449260611-24417-3-git-send-email-kapilh@broadcom.com>

On 04/12/15 12:23, Kapil Hali wrote:
> These changes cleans up SMP implementaion for Broadcom's
> Kona SoC which are required for handling SMP for iProc
> family of SoCs at a single place for BCM NSP and BCM Kona.
> 
> Signed-off-by: Kapil Hali <kapilh@broadcom.com>
> ---
>  arch/arm/boot/dts/bcm11351.dtsi |  2 +-
>  arch/arm/boot/dts/bcm21664.dtsi |  2 +-
>  arch/arm/mach-bcm/kona_smp.c    | 82 +++++++++++++++++++++++++++--------------
>  3 files changed, 56 insertions(+), 30 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arch/arm/boot/dts/bcm11351.dtsi
> index 2ddaa51..3dc7a8c 100644
> --- a/arch/arm/boot/dts/bcm11351.dtsi
> +++ b/arch/arm/boot/dts/bcm11351.dtsi
> @@ -31,7 +31,6 @@
>  		#address-cells = <1>;
>  		#size-cells = <0>;
>  		enable-method = "brcm,bcm11351-cpu-method";
> -		secondary-boot-reg = <0x3500417c>;

I would expect the 'enable-method' to be moved as well to be consistent
with what you are adding for NSP later on.

>  
>  		cpu0: cpu@0 {
>  			device_type = "cpu";
> @@ -42,6 +41,7 @@
>  		cpu1: cpu@1 {
>  			device_type = "cpu";
>  			compatible = "arm,cortex-a9";
> +			secondary-boot-reg = <0x3500417c>;
>  			reg = <1>;
>  		};
-- 
Florian

  reply	other threads:[~2015-12-04 23:07 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-04 20:23 [PATCH v5 0/5] SMP support for Broadcom NSP Kapil Hali
2015-12-04 20:23 ` Kapil Hali
2015-12-04 20:23 ` Kapil Hali
2015-12-04 20:23 ` [PATCH v5 1/5] dt-bindings: add SMP enable-method " Kapil Hali
2015-12-04 20:23   ` Kapil Hali
2015-12-04 20:23   ` Kapil Hali
2015-12-04 23:06   ` Florian Fainelli
2015-12-04 23:06     ` Florian Fainelli
2015-12-05 11:55     ` Kapil Hali
2015-12-05 11:55       ` Kapil Hali
2015-12-05 11:55       ` Kapil Hali
2015-12-04 20:23 ` [PATCH v5 2/5] ARM: BCM: Clean up SMP support for Broadcom Kona Kapil Hali
2015-12-04 20:23   ` Kapil Hali
2015-12-04 20:23   ` Kapil Hali
2015-12-04 23:07   ` Florian Fainelli [this message]
2015-12-04 23:07     ` Florian Fainelli
2015-12-05 11:56     ` Kapil Hali
2015-12-05 11:56       ` Kapil Hali
2015-12-05 11:56       ` Kapil Hali
2015-12-04 20:23 ` [PATCH v5 3/5] ARM: dts: Add SMP support for Broadcom NSP Kapil Hali
2015-12-04 20:23   ` Kapil Hali
2015-12-04 20:23   ` Kapil Hali
2015-12-04 20:23 ` [PATCH v5 4/5] ARM: BCM: " Kapil Hali
2015-12-04 20:23   ` Kapil Hali
2015-12-04 20:23   ` Kapil Hali
2015-12-04 20:23 ` [PATCH v5 5/5] ARM: BCM: Add SMP support for Broadcom 4708 Kapil Hali
2015-12-04 20:23   ` Kapil Hali
2015-12-04 20:23   ` Kapil Hali

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56621CA3.3090903@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.