From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Yoshihiro Kaneko <ykaneko0929@gmail.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
Linux-sh list <linux-sh@vger.kernel.org>
Subject: Re: [PATCH net] ravb: Remove clear unhandled interrupt
Date: Mon, 07 Dec 2015 17:44:32 +0000 [thread overview]
Message-ID: <5665C580.2090202@cogentembedded.com> (raw)
In-Reply-To: <CAH1o70LeSfwpcFicV=CCip=W1QOeYE3VioEv7L-XZCyMBgnTrA@mail.gmail.com>
Hello.
On 12/07/2015 07:59 PM, Yoshihiro Kaneko wrote:
>>> From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
>>>
>>> AVB-DMAC Reception Warning interrupt is not enabled, so it is not
>>> necessary to clear the interrupt.
>>>
>>> Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
>>> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
>>
>>
>> In principle I agree but perhaps we should clear RIC1 in probe() to not
>> depend on a state left from a bootloader?
>
> I think that it is a good idea.
> I'll add it to v2.
Perhaps the ndo_open() method would be a better place...
>> MBR, Sergei
> Thanks,
> Kaneko
MBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Yoshihiro Kaneko <ykaneko0929@gmail.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
Linux-sh list <linux-sh@vger.kernel.org>
Subject: Re: [PATCH net] ravb: Remove clear unhandled interrupt
Date: Mon, 7 Dec 2015 20:44:32 +0300 [thread overview]
Message-ID: <5665C580.2090202@cogentembedded.com> (raw)
In-Reply-To: <CAH1o70LeSfwpcFicV=CCip=W1QOeYE3VioEv7L-XZCyMBgnTrA@mail.gmail.com>
Hello.
On 12/07/2015 07:59 PM, Yoshihiro Kaneko wrote:
>>> From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
>>>
>>> AVB-DMAC Reception Warning interrupt is not enabled, so it is not
>>> necessary to clear the interrupt.
>>>
>>> Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
>>> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
>>
>>
>> In principle I agree but perhaps we should clear RIC1 in probe() to not
>> depend on a state left from a bootloader?
>
> I think that it is a good idea.
> I'll add it to v2.
Perhaps the ndo_open() method would be a better place...
>> MBR, Sergei
> Thanks,
> Kaneko
MBR, Sergei
next prev parent reply other threads:[~2015-12-07 17:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-06 11:42 [PATCH net] ravb: Remove clear unhandled interrupt Yoshihiro Kaneko
2015-12-06 11:42 ` Yoshihiro Kaneko
2015-12-06 19:18 ` Sergei Shtylyov
2015-12-06 19:18 ` Sergei Shtylyov
2015-12-07 16:59 ` Yoshihiro Kaneko
2015-12-07 16:59 ` Yoshihiro Kaneko
2015-12-07 17:44 ` Sergei Shtylyov [this message]
2015-12-07 17:44 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5665C580.2090202@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=horms@verge.net.au \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=ykaneko0929@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.