All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andrew F. Davis" <afd@ti.com>
To: Mark Brown <broonie@kernel.org>, Lee Jones <lee.jones@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Alexandre Courbot <gnurou@gmail.com>,
	Samuel Ortiz <sameo@linux.intel.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	devicetree@vger.kernel.org, linux-gpio@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 0/5] mfd: tps65912: Driver rewrite with DT support
Date: Mon, 7 Dec 2015 13:58:47 -0600	[thread overview]
Message-ID: <5665E4F7.1070707@ti.com> (raw)
In-Reply-To: <20151204120240.GW26072@sirena.org.uk>

On 12/04/2015 06:02 AM, Mark Brown wrote:
> On Tue, Nov 24, 2015 at 04:26:24PM +0000, Lee Jones wrote:
>> On Wed, 18 Nov 2015, Andrew F. Davis wrote:
>
>>>   Documentation/devicetree/bindings/mfd/tps65912.txt |  50 ++
>>>   drivers/gpio/Kconfig                               |   2 +-
>>>   drivers/gpio/gpio-tps65912.c                       | 317 ++++-----
>>>   drivers/mfd/Kconfig                                |  20 +-
>>>   drivers/mfd/Makefile                               |   3 +-
>>>   drivers/mfd/tps65912-core.c                        | 290 ++++-----
>>>   drivers/mfd/tps65912-i2c.c                         | 219 +++----
>>>   drivers/mfd/tps65912-irq.c                         | 217 -------
>>>   drivers/mfd/tps65912-spi.c                         | 219 +++----
>>>   drivers/regulator/Kconfig                          |   2 +-
>>>   drivers/regulator/tps65912-regulator.c             | 710 +++++----------------
>>>   include/linux/mfd/tps65912.h                       | 208 +++---
>
>> Just waiting for the regulator Ack now, right?
>
> No, you also need to work out what to do about the GPIO driver not
> building in -next due to interface changes in gpiolib.
>

As all of this driver should be taken though the MFD tree how
can this gpiolib change be handled? If we have gpio.parent it
will not build on MFD, with gpio.dev it will fail to build when
the changes are merged from the gpio subsystem. As the change
has not been merged into linux-next as far a I can tell maybe
this should be taken as is, then when the gpiolib change is
made this can be changed with all the other drivers?

WARNING: multiple messages have this Message-ID (diff)
From: "Andrew F. Davis" <afd@ti.com>
To: Mark Brown <broonie@kernel.org>, Lee Jones <lee.jones@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Alexandre Courbot <gnurou@gmail.com>,
	Samuel Ortiz <sameo@linux.intel.com>,
	Liam Girdwood <lgirdwood@gmail.com>, <devicetree@vger.kernel.org>,
	<linux-gpio@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v7 0/5] mfd: tps65912: Driver rewrite with DT support
Date: Mon, 7 Dec 2015 13:58:47 -0600	[thread overview]
Message-ID: <5665E4F7.1070707@ti.com> (raw)
In-Reply-To: <20151204120240.GW26072@sirena.org.uk>

On 12/04/2015 06:02 AM, Mark Brown wrote:
> On Tue, Nov 24, 2015 at 04:26:24PM +0000, Lee Jones wrote:
>> On Wed, 18 Nov 2015, Andrew F. Davis wrote:
>
>>>   Documentation/devicetree/bindings/mfd/tps65912.txt |  50 ++
>>>   drivers/gpio/Kconfig                               |   2 +-
>>>   drivers/gpio/gpio-tps65912.c                       | 317 ++++-----
>>>   drivers/mfd/Kconfig                                |  20 +-
>>>   drivers/mfd/Makefile                               |   3 +-
>>>   drivers/mfd/tps65912-core.c                        | 290 ++++-----
>>>   drivers/mfd/tps65912-i2c.c                         | 219 +++----
>>>   drivers/mfd/tps65912-irq.c                         | 217 -------
>>>   drivers/mfd/tps65912-spi.c                         | 219 +++----
>>>   drivers/regulator/Kconfig                          |   2 +-
>>>   drivers/regulator/tps65912-regulator.c             | 710 +++++----------------
>>>   include/linux/mfd/tps65912.h                       | 208 +++---
>
>> Just waiting for the regulator Ack now, right?
>
> No, you also need to work out what to do about the GPIO driver not
> building in -next due to interface changes in gpiolib.
>

As all of this driver should be taken though the MFD tree how
can this gpiolib change be handled? If we have gpio.parent it
will not build on MFD, with gpio.dev it will fail to build when
the changes are merged from the gpio subsystem. As the change
has not been merged into linux-next as far a I can tell maybe
this should be taken as is, then when the gpiolib change is
made this can be changed with all the other drivers?

  reply	other threads:[~2015-12-07 19:59 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-18 17:59 [PATCH v7 0/5] mfd: tps65912: Driver rewrite with DT support Andrew F. Davis
2015-11-18 17:59 ` Andrew F. Davis
     [not found] ` <1447869580-10416-1-git-send-email-afd-l0cyMroinI0@public.gmane.org>
2015-11-18 17:59   ` [PATCH v7 1/5] Documentation: tps65912: Add DT bindings for the TPS65912 PMIC Andrew F. Davis
2015-11-18 17:59     ` Andrew F. Davis
2015-11-18 21:14     ` Rob Herring
2015-11-24 16:25     ` Lee Jones
2015-11-24 16:25       ` Lee Jones
     [not found]     ` <1447869580-10416-2-git-send-email-afd-l0cyMroinI0@public.gmane.org>
2015-12-01  9:56       ` Linus Walleij
2015-12-01  9:56         ` Linus Walleij
2015-11-18 17:59   ` [PATCH v7 2/5] mfd: tps65912: Remove old driver in preparation for new driver Andrew F. Davis
2015-11-18 17:59     ` Andrew F. Davis
2015-11-18 17:59   ` [PATCH v7 4/5] regulator: tps65912: Add regulator driver for the TPS65912 PMIC Andrew F. Davis
2015-11-18 17:59     ` Andrew F. Davis
2015-11-18 17:59 ` [PATCH v7 3/5] mfd: tps65912: Add " Andrew F. Davis
2015-11-18 17:59   ` Andrew F. Davis
2015-11-18 17:59 ` [PATCH v7 5/5] gpio: tps65912: Add GPIO " Andrew F. Davis
2015-11-18 17:59   ` Andrew F. Davis
2015-11-30  8:26   ` Linus Walleij
2015-12-01 19:40     ` Andrew F. Davis
     [not found]       ` <565DF7BD.6010204-l0cyMroinI0@public.gmane.org>
2015-12-10 17:34         ` Linus Walleij
2015-12-10 17:34           ` Linus Walleij
2015-11-24 16:26 ` [PATCH v7 0/5] mfd: tps65912: Driver rewrite with DT support Lee Jones
2015-11-24 16:26   ` Lee Jones
2015-12-03 15:52   ` Andrew F. Davis
2015-12-03 15:52     ` Andrew F. Davis
2015-12-04  8:43     ` Lee Jones
2015-12-04  8:43       ` Lee Jones
2015-12-04 12:02   ` Mark Brown
2015-12-07 19:58     ` Andrew F. Davis [this message]
2015-12-07 19:58       ` Andrew F. Davis
2015-12-08 19:16       ` Mark Brown
2015-12-09 12:35         ` Linus Walleij
2015-12-15 16:16           ` Andrew F. Davis
2015-12-22  9:13             ` Linus Walleij
     [not found]               ` <CACRpkdYxBkuRcE6_VvChO=kKHTd0TS1kKAutL=8hFA4-15h3nA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-01-11  7:38                 ` Lee Jones
2016-01-11  7:38                   ` Lee Jones
2016-01-14  8:54                   ` Linus Walleij
2016-01-14  8:54                     ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5665E4F7.1070707@ti.com \
    --to=afd@ti.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=gnurou@gmail.com \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=lee.jones@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.