From: Damien Horsley <Damien.Horsley-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Liam Girdwood <lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Jaroslav Kysela <perex-/Fr2/VpizcU@public.gmane.org>,
Takashi Iwai <tiwai-IBi9RG/b67k@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [alsa-devel] [PATCH 2/2] ASoC: img: Add driver for Pistachio internal DAC
Date: Tue, 8 Dec 2015 16:04:02 +0000 [thread overview]
Message-ID: <5666FF72.7010206@imgtec.com> (raw)
In-Reply-To: <20151125124728.GT1929-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
On 25/11/15 12:47, Mark Brown wrote:
> On Mon, Nov 23, 2015 at 05:24:59PM +0000, Damien Horsley wrote:
>
>> + /* The mute state as set by alsa using the digital_mute callback */
>> + bool alsa_mute_state;
>> + /* The mute state as set by the userspace mute control */
>> + bool control_mute_state;
>> + /* The actual mute state is equal to an OR of the above */
>
> Does the device *need* the digital mute to avoid noise? If there's no
> strong need for it then just don't bother which simplifies the code a
> lot.
>
> Otherwise this looks good.
>
It does not seem to make a difference. I will remove and repost.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Damien Horsley <Damien.Horsley@imgtec.com>
To: Mark Brown <broonie@kernel.org>
Cc: <alsa-devel@alsa-project.org>, Rob Herring <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [alsa-devel] [PATCH 2/2] ASoC: img: Add driver for Pistachio internal DAC
Date: Tue, 8 Dec 2015 16:04:02 +0000 [thread overview]
Message-ID: <5666FF72.7010206@imgtec.com> (raw)
In-Reply-To: <20151125124728.GT1929@sirena.org.uk>
On 25/11/15 12:47, Mark Brown wrote:
> On Mon, Nov 23, 2015 at 05:24:59PM +0000, Damien Horsley wrote:
>
>> + /* The mute state as set by alsa using the digital_mute callback */
>> + bool alsa_mute_state;
>> + /* The mute state as set by the userspace mute control */
>> + bool control_mute_state;
>> + /* The actual mute state is equal to an OR of the above */
>
> Does the device *need* the digital mute to avoid noise? If there's no
> strong need for it then just don't bother which simplifies the code a
> lot.
>
> Otherwise this looks good.
>
It does not seem to make a difference. I will remove and repost.
next prev parent reply other threads:[~2015-12-08 16:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-23 17:24 [PATCH 0/2] Add support for Pistachio internal DAC Damien Horsley
2015-11-23 17:24 ` [PATCH 1/2] ASoC: img: Add binding document " Damien Horsley
2015-12-12 23:07 ` Applied "ASoC: img: Add binding document for Pistachio internal DAC" to the asoc tree Mark Brown
2015-11-23 17:24 ` [PATCH 2/2] ASoC: img: Add driver for Pistachio internal DAC Damien Horsley
2015-11-25 12:47 ` Mark Brown
2015-11-25 12:47 ` [alsa-devel] " Mark Brown
[not found] ` <20151125124728.GT1929-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-12-08 16:04 ` Damien Horsley [this message]
2015-12-08 16:04 ` Damien Horsley
2015-11-25 12:40 ` [PATCH 0/2] Add support " Mark Brown
2015-11-25 12:40 ` [alsa-devel] " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5666FF72.7010206@imgtec.com \
--to=damien.horsley-1axoqhu6uovqt0dzr+alfa@public.gmane.org \
--cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=perex-/Fr2/VpizcU@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=tiwai-IBi9RG/b67k@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.