From: santosh.shilimkar@oracle.com (santosh shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] soc: TI knav_qmss: fix dma_addr_t printing
Date: Tue, 8 Dec 2015 14:28:17 -0800 [thread overview]
Message-ID: <56675981.5060206@oracle.com> (raw)
In-Reply-To: <18371096.H4qt47cWYH@wuerfel>
On 12/8/2015 1:34 PM, Arnd Bergmann wrote:
> On Tuesday 08 December 2015 08:53:53 santosh shilimkar wrote:
>> On 12/8/2015 7:30 AM, Arnd Bergmann wrote:
>>> The knav_qmss driver is currently broken when CONFIG_LPAE is
>>> set, which is a bit surprising because I'd expect that any serious
>>> users of this platforms would have more than 2GB of RAM and require
>>> LPAE.
>>>
>> Well it has been working with LPAE enable always. The production
>> systems do but IIRC, some of the Eval board were still build with
>> just 2 GB memory.
>
> Maybe that just means that the debug code is never used and we can remove
> all the dev_dbg instead? That might actually be nicer as it would reduce
> the amount of code in your driver (slightly).
>
It was added in intention so that it is useful. I agree if it is not
used or useful, we should remove it.
Regards,
Santosh
WARNING: multiple messages have this Message-ID (diff)
From: santosh shilimkar <santosh.shilimkar@oracle.com>
To: Arnd Bergmann <arnd@arndb.de>, linux-arm-kernel@lists.infradead.org
Cc: Murali Karicheri <m-karicheri2@ti.com>,
"Kwok, WingMan" <w-kwok2@ti.com>,
linux-kernel@vger.kernel.org,
Santosh Shilimkar <ssantosh@kernel.org>
Subject: Re: [PATCH] soc: TI knav_qmss: fix dma_addr_t printing
Date: Tue, 8 Dec 2015 14:28:17 -0800 [thread overview]
Message-ID: <56675981.5060206@oracle.com> (raw)
In-Reply-To: <18371096.H4qt47cWYH@wuerfel>
On 12/8/2015 1:34 PM, Arnd Bergmann wrote:
> On Tuesday 08 December 2015 08:53:53 santosh shilimkar wrote:
>> On 12/8/2015 7:30 AM, Arnd Bergmann wrote:
>>> The knav_qmss driver is currently broken when CONFIG_LPAE is
>>> set, which is a bit surprising because I'd expect that any serious
>>> users of this platforms would have more than 2GB of RAM and require
>>> LPAE.
>>>
>> Well it has been working with LPAE enable always. The production
>> systems do but IIRC, some of the Eval board were still build with
>> just 2 GB memory.
>
> Maybe that just means that the debug code is never used and we can remove
> all the dev_dbg instead? That might actually be nicer as it would reduce
> the amount of code in your driver (slightly).
>
It was added in intention so that it is useful. I agree if it is not
used or useful, we should remove it.
Regards,
Santosh
next prev parent reply other threads:[~2015-12-08 22:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 15:30 [PATCH] soc: TI knav_qmss: fix dma_addr_t printing Arnd Bergmann
2015-12-08 15:30 ` Arnd Bergmann
2015-12-08 16:53 ` santosh shilimkar
2015-12-08 16:53 ` santosh shilimkar
2015-12-08 21:34 ` Arnd Bergmann
2015-12-08 21:34 ` Arnd Bergmann
2015-12-08 22:28 ` santosh shilimkar [this message]
2015-12-08 22:28 ` santosh shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56675981.5060206@oracle.com \
--to=santosh.shilimkar@oracle.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.