From: Qais Yousef <qais.yousef@imgtec.com>
To: Mel Gorman <mgorman@techsingularity.net>,
Andrew Morton <akpm@linux-foundation.org>
Cc: <linux-mips@linux-mips.org>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>, <ralf@linux-mips.org>
Subject: Re: [PATCH] MIPS: Fix DMA contiguous allocation
Date: Wed, 9 Dec 2015 14:32:46 +0000 [thread overview]
Message-ID: <56683B8E.2000600@imgtec.com> (raw)
In-Reply-To: <20151209113635.GA15910@techsingularity.net>
On 12/09/2015 11:36 AM, Mel Gorman wrote:
> On Tue, Dec 08, 2015 at 02:19:39PM -0800, Andrew Morton wrote:
>> On Tue, 8 Dec 2015 10:18:50 +0000 Qais Yousef <qais.yousef@imgtec.com> wrote:
>>
>>> --- a/arch/mips/mm/dma-default.c
>>> +++ b/arch/mips/mm/dma-default.c
>>> @@ -145,7 +145,7 @@ static void *mips_dma_alloc_coherent(struct device *dev, size_t size,
>>>
>>> gfp = massage_gfp_flags(dev, gfp);
>>>
>>> - if (IS_ENABLED(CONFIG_DMA_CMA) && !(gfp & GFP_ATOMIC))
>>> + if (IS_ENABLED(CONFIG_DMA_CMA) && ((gfp & GFP_ATOMIC) != GFP_ATOMIC))
>>> page = dma_alloc_from_contiguous(dev,
>>> count, get_order(size));
>>> if (!page)
>> hm. It seems that the code is asking "can I do a potentially-sleeping
>> memory allocation"?
>>
>> The way to do that under the new regime is
>>
>> if (IS_ENABLED(CONFIG_DMA_CMA) && gfpflags_allow_blocking(gfp))
>>
>> Mel, can you please confirm?
> Yes, this is the correct way it should be checked. The full flags cover
> watermark and kswapd treatment which potentially could be altered by
> the caller.
>
OK thanks both. I'll send a revised version with this change.
Thanks,
Qais
WARNING: multiple messages have this Message-ID (diff)
From: Qais Yousef <qais.yousef@imgtec.com>
To: Mel Gorman <mgorman@techsingularity.net>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mips@linux-mips.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, ralf@linux-mips.org
Subject: Re: [PATCH] MIPS: Fix DMA contiguous allocation
Date: Wed, 9 Dec 2015 14:32:46 +0000 [thread overview]
Message-ID: <56683B8E.2000600@imgtec.com> (raw)
Message-ID: <20151209143246.nnrffxMSUV6jX7avZY18PwBovKaRi-IorSd0YgwYbco@z> (raw)
In-Reply-To: <20151209113635.GA15910@techsingularity.net>
On 12/09/2015 11:36 AM, Mel Gorman wrote:
> On Tue, Dec 08, 2015 at 02:19:39PM -0800, Andrew Morton wrote:
>> On Tue, 8 Dec 2015 10:18:50 +0000 Qais Yousef <qais.yousef@imgtec.com> wrote:
>>
>>> --- a/arch/mips/mm/dma-default.c
>>> +++ b/arch/mips/mm/dma-default.c
>>> @@ -145,7 +145,7 @@ static void *mips_dma_alloc_coherent(struct device *dev, size_t size,
>>>
>>> gfp = massage_gfp_flags(dev, gfp);
>>>
>>> - if (IS_ENABLED(CONFIG_DMA_CMA) && !(gfp & GFP_ATOMIC))
>>> + if (IS_ENABLED(CONFIG_DMA_CMA) && ((gfp & GFP_ATOMIC) != GFP_ATOMIC))
>>> page = dma_alloc_from_contiguous(dev,
>>> count, get_order(size));
>>> if (!page)
>> hm. It seems that the code is asking "can I do a potentially-sleeping
>> memory allocation"?
>>
>> The way to do that under the new regime is
>>
>> if (IS_ENABLED(CONFIG_DMA_CMA) && gfpflags_allow_blocking(gfp))
>>
>> Mel, can you please confirm?
> Yes, this is the correct way it should be checked. The full flags cover
> watermark and kswapd treatment which potentially could be altered by
> the caller.
>
OK thanks both. I'll send a revised version with this change.
Thanks,
Qais
WARNING: multiple messages have this Message-ID (diff)
From: Qais Yousef <qais.yousef@imgtec.com>
To: Mel Gorman <mgorman@techsingularity.net>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mips@linux-mips.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, ralf@linux-mips.org
Subject: Re: [PATCH] MIPS: Fix DMA contiguous allocation
Date: Wed, 9 Dec 2015 14:32:46 +0000 [thread overview]
Message-ID: <56683B8E.2000600@imgtec.com> (raw)
In-Reply-To: <20151209113635.GA15910@techsingularity.net>
On 12/09/2015 11:36 AM, Mel Gorman wrote:
> On Tue, Dec 08, 2015 at 02:19:39PM -0800, Andrew Morton wrote:
>> On Tue, 8 Dec 2015 10:18:50 +0000 Qais Yousef <qais.yousef@imgtec.com> wrote:
>>
>>> --- a/arch/mips/mm/dma-default.c
>>> +++ b/arch/mips/mm/dma-default.c
>>> @@ -145,7 +145,7 @@ static void *mips_dma_alloc_coherent(struct device *dev, size_t size,
>>>
>>> gfp = massage_gfp_flags(dev, gfp);
>>>
>>> - if (IS_ENABLED(CONFIG_DMA_CMA) && !(gfp & GFP_ATOMIC))
>>> + if (IS_ENABLED(CONFIG_DMA_CMA) && ((gfp & GFP_ATOMIC) != GFP_ATOMIC))
>>> page = dma_alloc_from_contiguous(dev,
>>> count, get_order(size));
>>> if (!page)
>> hm. It seems that the code is asking "can I do a potentially-sleeping
>> memory allocation"?
>>
>> The way to do that under the new regime is
>>
>> if (IS_ENABLED(CONFIG_DMA_CMA) && gfpflags_allow_blocking(gfp))
>>
>> Mel, can you please confirm?
> Yes, this is the correct way it should be checked. The full flags cover
> watermark and kswapd treatment which potentially could be altered by
> the caller.
>
OK thanks both. I'll send a revised version with this change.
Thanks,
Qais
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-12-09 14:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 10:18 [PATCH] MIPS: Fix DMA contiguous allocation Qais Yousef
2015-12-08 10:18 ` Qais Yousef
2015-12-08 10:18 ` Qais Yousef
2015-12-08 10:18 ` Qais Yousef
2015-12-08 12:12 ` Sergei Shtylyov
2015-12-08 12:12 ` Sergei Shtylyov
2015-12-08 22:19 ` Andrew Morton
2015-12-08 22:19 ` Andrew Morton
2015-12-08 22:19 ` Andrew Morton
2015-12-09 11:36 ` Mel Gorman
2015-12-09 11:36 ` Mel Gorman
2015-12-09 14:32 ` Qais Yousef [this message]
2015-12-09 14:32 ` Qais Yousef
2015-12-09 14:32 ` Qais Yousef
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56683B8E.2000600@imgtec.com \
--to=qais.yousef@imgtec.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.