From: Eric Blake <eblake@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>,
QEMU <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] configure: remove bashism (since 2010)
Date: Wed, 9 Dec 2015 19:52:32 -0700 [thread overview]
Message-ID: <5668E8F0.4060202@redhat.com> (raw)
In-Reply-To: <CAJ+F1CJG9pZQWgfnDex6eL1SFrjdcu_E0=SJcjJNVEyjMHNwBA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 839 bytes --]
On 12/09/2015 05:57 PM, Marc-André Lureau wrote:
> Hi
>
> On Thu, Dec 10, 2015 at 1:53 AM, <marcandre.lureau@redhat.com> wrote:
>> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>>
>> "type" is not POSIX shell, but a bashism. (found thanks to shellcheck)
>>
>
> A subsidiary question is whether qemu really care about using POSIX
> shell, or we can just depend on bashism. That would help with
> simplifying some Makefile lines too.
Debian uses dash, not bash, as /bin/sh. As both 'configure' and
'Makefile' depend on '/bin/sh', then yes, we care about POSIX compliance.
Only in scripts that explicitly require /bin/bash, such as much of the
scripts under tests/, can we get away with bashisms.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-12-10 2:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-10 0:53 [Qemu-devel] [PATCH] configure: remove bashism (since 2010) marcandre.lureau
2015-12-10 0:57 ` Marc-André Lureau
2015-12-10 2:52 ` Eric Blake [this message]
2015-12-10 2:51 ` Eric Blake
2015-12-10 9:46 ` Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5668E8F0.4060202@redhat.com \
--to=eblake@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.