From: Eric Blake <eblake@redhat.com>
To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH 2/2] configure: fix trace backend check
Date: Wed, 9 Dec 2015 20:01:25 -0700 [thread overview]
Message-ID: <5668EB05.7050008@redhat.com> (raw)
In-Reply-To: <1449708466-13366-2-git-send-email-marcandre.lureau@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 934 bytes --]
On 12/09/2015 05:47 PM, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Found thanks to shellcheck!
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> diff --git a/configure b/configure
> index 6a971a2..ba57b3f 100755
> --- a/configure
> +++ b/configure
> @@ -4816,7 +4816,7 @@ echo "libcap-ng support $cap_ng"
> echo "vhost-net support $vhost_net"
> echo "vhost-scsi support $vhost_scsi"
> echo "Trace backends $trace_backends"
> -if test "$trace_backend" = "simple"; then
> +if have_backend "simple"; then
> echo "Trace output file $trace_file-<pid>"
> fi
> if test "$spice" = "yes"; then
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Eric Blake <eblake@redhat.com>
To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] configure: fix trace backend check
Date: Wed, 9 Dec 2015 20:01:25 -0700 [thread overview]
Message-ID: <5668EB05.7050008@redhat.com> (raw)
In-Reply-To: <1449708466-13366-2-git-send-email-marcandre.lureau@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 934 bytes --]
On 12/09/2015 05:47 PM, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Found thanks to shellcheck!
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> diff --git a/configure b/configure
> index 6a971a2..ba57b3f 100755
> --- a/configure
> +++ b/configure
> @@ -4816,7 +4816,7 @@ echo "libcap-ng support $cap_ng"
> echo "vhost-net support $vhost_net"
> echo "vhost-scsi support $vhost_scsi"
> echo "Trace backends $trace_backends"
> -if test "$trace_backend" = "simple"; then
> +if have_backend "simple"; then
> echo "Trace output file $trace_file-<pid>"
> fi
> if test "$spice" = "yes"; then
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-12-10 3:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-10 0:47 [Qemu-trivial] [PATCH 1/2] configure: remove unused or undefined variables marcandre.lureau
2015-12-10 0:47 ` [Qemu-devel] " marcandre.lureau
2015-12-10 0:47 ` [Qemu-trivial] [PATCH 2/2] configure: fix trace backend check marcandre.lureau
2015-12-10 0:47 ` [Qemu-devel] " marcandre.lureau
2015-12-10 3:01 ` Eric Blake [this message]
2015-12-10 3:01 ` Eric Blake
2016-01-10 18:00 ` [Qemu-trivial] " Michael Tokarev
2016-01-10 18:00 ` [Qemu-devel] " Michael Tokarev
2015-12-10 2:56 ` [Qemu-trivial] [Qemu-devel] [PATCH 1/2] configure: remove unused or undefined variables Eric Blake
2015-12-10 2:56 ` Eric Blake
2016-01-10 17:58 ` [Qemu-trivial] " Michael Tokarev
2016-01-10 17:58 ` [Qemu-devel] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5668EB05.7050008@redhat.com \
--to=eblake@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.