From: Vignesh R <vigneshr@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Brian Norris <computersforpeace@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Russell King <linux@arm.linux.org.uk>,
"hramrach@gmail.com" <hramrach@gmail.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>
Subject: Re: [PATCH v4 4/5] ARM: dts: DRA7: add entry for qspi mmap region
Date: Thu, 10 Dec 2015 10:34:23 +0530 [thread overview]
Message-ID: <566907D7.6040003@ti.com> (raw)
In-Reply-To: <566017A8.5040106@ti.com>
On 12/03/2015 03:51 PM, Vignesh R wrote:
>
>
> On 12/01/2015 10:09 PM, Tony Lindgren wrote:
>> * Vignesh R <vigneshr@ti.com> [151130 20:46]:
>>> On 12/01/2015 04:04 AM, Tony Lindgren wrote:
>>>>
...
>>
>> OK. They are both on L3 main so that won't cause any issues for separate
>> interconnect driver instances. As they are still separate targets flushing
>> a posted write to one area will not flush anything to the other.
>>
>
> I didn't quite understand what you meant by interconnect driver instance.
> qspi_base and qspi_mmap region are tightly bound to each other and both
> needs to be accessed by ti-qspi driver (though different targets).
> Besides qspi_mmap region is only used to read data, there will not be
> any write accesses to this target. Are you saying this binding is not
> viable?
>
As I stated above qspi_base and qspi_mmap region are tightly bound,
there is no way to use qspi_mmap region w/o accessing qspi_base. So I am
planning to keep them as it is. I will move qspi_ctrlmod to use syscon.
Something like:
qspi: qspi@4b300000 {
compatible = "ti,dra7xxx-qspi";
reg = <0x4b300000 0x100>,
<0x5c000000 0x4000000>,
reg-names = "qspi_base", "qspi_mmap";
syscon-chipselects = <&scm_conf 0x558>;
#address-cells = <1>;
#size-cells = <0>;
spi-max-frequency = <48000000>;
ti,hwmods = "qspi";
};
Do you think this is not viable in future?
--
Regards
Vignesh
WARNING: multiple messages have this Message-ID (diff)
From: Vignesh R <vigneshr-l0cyMroinI0@public.gmane.org>
To: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
Cc: Brian Norris
<computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
"hramrach-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org"
<hramrach-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v4 4/5] ARM: dts: DRA7: add entry for qspi mmap region
Date: Thu, 10 Dec 2015 10:34:23 +0530 [thread overview]
Message-ID: <566907D7.6040003@ti.com> (raw)
In-Reply-To: <566017A8.5040106-l0cyMroinI0@public.gmane.org>
On 12/03/2015 03:51 PM, Vignesh R wrote:
>
>
> On 12/01/2015 10:09 PM, Tony Lindgren wrote:
>> * Vignesh R <vigneshr-l0cyMroinI0@public.gmane.org> [151130 20:46]:
>>> On 12/01/2015 04:04 AM, Tony Lindgren wrote:
>>>>
...
>>
>> OK. They are both on L3 main so that won't cause any issues for separate
>> interconnect driver instances. As they are still separate targets flushing
>> a posted write to one area will not flush anything to the other.
>>
>
> I didn't quite understand what you meant by interconnect driver instance.
> qspi_base and qspi_mmap region are tightly bound to each other and both
> needs to be accessed by ti-qspi driver (though different targets).
> Besides qspi_mmap region is only used to read data, there will not be
> any write accesses to this target. Are you saying this binding is not
> viable?
>
As I stated above qspi_base and qspi_mmap region are tightly bound,
there is no way to use qspi_mmap region w/o accessing qspi_base. So I am
planning to keep them as it is. I will move qspi_ctrlmod to use syscon.
Something like:
qspi: qspi@4b300000 {
compatible = "ti,dra7xxx-qspi";
reg = <0x4b300000 0x100>,
<0x5c000000 0x4000000>,
reg-names = "qspi_base", "qspi_mmap";
syscon-chipselects = <&scm_conf 0x558>;
#address-cells = <1>;
#size-cells = <0>;
spi-max-frequency = <48000000>;
ti,hwmods = "qspi";
};
Do you think this is not viable in future?
--
Regards
Vignesh
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: vigneshr@ti.com (Vignesh R)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 4/5] ARM: dts: DRA7: add entry for qspi mmap region
Date: Thu, 10 Dec 2015 10:34:23 +0530 [thread overview]
Message-ID: <566907D7.6040003@ti.com> (raw)
In-Reply-To: <566017A8.5040106@ti.com>
On 12/03/2015 03:51 PM, Vignesh R wrote:
>
>
> On 12/01/2015 10:09 PM, Tony Lindgren wrote:
>> * Vignesh R <vigneshr@ti.com> [151130 20:46]:
>>> On 12/01/2015 04:04 AM, Tony Lindgren wrote:
>>>>
...
>>
>> OK. They are both on L3 main so that won't cause any issues for separate
>> interconnect driver instances. As they are still separate targets flushing
>> a posted write to one area will not flush anything to the other.
>>
>
> I didn't quite understand what you meant by interconnect driver instance.
> qspi_base and qspi_mmap region are tightly bound to each other and both
> needs to be accessed by ti-qspi driver (though different targets).
> Besides qspi_mmap region is only used to read data, there will not be
> any write accesses to this target. Are you saying this binding is not
> viable?
>
As I stated above qspi_base and qspi_mmap region are tightly bound,
there is no way to use qspi_mmap region w/o accessing qspi_base. So I am
planning to keep them as it is. I will move qspi_ctrlmod to use syscon.
Something like:
qspi: qspi at 4b300000 {
compatible = "ti,dra7xxx-qspi";
reg = <0x4b300000 0x100>,
<0x5c000000 0x4000000>,
reg-names = "qspi_base", "qspi_mmap";
syscon-chipselects = <&scm_conf 0x558>;
#address-cells = <1>;
#size-cells = <0>;
spi-max-frequency = <48000000>;
ti,hwmods = "qspi";
};
Do you think this is not viable in future?
--
Regards
Vignesh
next prev parent reply other threads:[~2015-12-10 5:04 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-30 5:15 [PATCH v4 0/5] Add memory mapped read support for ti-qspi Vignesh R
2015-11-30 5:15 ` Vignesh R
2015-11-30 5:15 ` Vignesh R
2015-11-30 5:15 ` Vignesh R
2015-11-30 5:15 ` [PATCH v4 1/5] spi: introduce accelerated read support for spi flash devices Vignesh R
2015-11-30 5:15 ` Vignesh R
2015-11-30 5:15 ` Vignesh R
2015-12-02 19:41 ` Mark Brown
2015-12-02 19:41 ` Mark Brown
2015-12-02 19:41 ` Mark Brown
[not found] ` <1448860515-28336-2-git-send-email-vigneshr-l0cyMroinI0@public.gmane.org>
2016-02-09 19:43 ` Applied "spi: introduce accelerated read support for spi flash devices" to the spi tree Mark Brown
2015-11-30 5:15 ` [PATCH v4 2/5] spi: spi-ti-qspi: add mmap mode read support Vignesh R
2015-11-30 5:15 ` Vignesh R
2015-11-30 5:15 ` Vignesh R
2015-11-30 22:35 ` Felipe Balbi
2015-11-30 22:35 ` Felipe Balbi
2015-11-30 22:35 ` Felipe Balbi
2015-11-30 22:35 ` Felipe Balbi
2015-12-01 7:44 ` Vignesh R
2015-12-01 7:44 ` Vignesh R
2015-11-30 5:15 ` [PATCH v4 3/5] mtd: devices: m25p80: add support for mmap read request Vignesh R
2015-11-30 5:15 ` Vignesh R
2015-11-30 5:15 ` Vignesh R
2015-11-30 5:15 ` Vignesh R
2015-12-03 9:42 ` Cyrille Pitchen
2015-12-03 9:42 ` Cyrille Pitchen
2015-12-03 9:42 ` Cyrille Pitchen
2015-12-03 11:23 ` Vignesh R
2015-12-03 11:23 ` Vignesh R
2015-12-03 11:23 ` Vignesh R
2015-11-30 5:15 ` [PATCH v4 4/5] ARM: dts: DRA7: add entry for qspi mmap region Vignesh R
2015-11-30 5:15 ` Vignesh R
2015-11-30 5:15 ` Vignesh R
2015-11-30 5:15 ` Vignesh R
2015-11-30 22:01 ` Tony Lindgren
2015-11-30 22:01 ` Tony Lindgren
2015-11-30 22:01 ` Tony Lindgren
2015-11-30 22:34 ` Tony Lindgren
2015-11-30 22:34 ` Tony Lindgren
2015-11-30 22:34 ` Tony Lindgren
2015-11-30 22:34 ` Tony Lindgren
2015-11-30 22:34 ` Tony Lindgren
2015-12-01 4:45 ` Vignesh R
2015-12-01 4:45 ` Vignesh R
2015-12-01 4:45 ` Vignesh R
2015-12-01 16:39 ` Tony Lindgren
2015-12-01 16:39 ` Tony Lindgren
2015-12-03 10:21 ` Vignesh R
2015-12-03 10:21 ` Vignesh R
2015-12-10 5:04 ` Vignesh R [this message]
2015-12-10 5:04 ` Vignesh R
2015-12-10 5:04 ` Vignesh R
2015-12-10 17:44 ` Tony Lindgren
2015-12-10 17:44 ` Tony Lindgren
2015-12-10 17:44 ` Tony Lindgren
2015-11-30 5:15 ` [PATCH v4 5/5] ARM: dts: AM4372: " Vignesh R
2015-11-30 5:15 ` Vignesh R
2015-11-30 5:15 ` Vignesh R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566907D7.6040003@ti.com \
--to=vigneshr@ti.com \
--cc=broonie@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=hramrach@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.