All of lore.kernel.org
 help / color / mirror / Atom feed
From: xuejiancheng@huawei.com (xuejiancheng)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 4/9] ARM: dts: add dts files for hi3519-demb board
Date: Thu, 10 Dec 2015 16:59:14 +0800	[thread overview]
Message-ID: <56693EE2.20501@huawei.com> (raw)
In-Reply-To: <2721289.3GUub5trUg@wuerfel>



On 2015/12/10 16:04, Arnd Bergmann wrote:
> On Thursday 10 December 2015 14:32:05 xuejiancheng wrote:
>>>
>>> This is not what I meant. You have to use "syscon" as the most generic
>>> "compatible" value here, but should add a machine specific string
>>> as a more specific one. "hisilicon,sysctrl" is not appropriate because
>>> it does not identify the IP block uniquely, you can only use that
>>> in combination with another more specific string.
>>
>> OK. I will use "hisilicon,hi3519-syscon" and "syscon" as the compatible value
>> for the sysctrl node in hi3519.dtsi.
>>
> 
> Why hisilicon,hi3519-syscon instead of hisilicon,hi3519-sysctrl?

> Is this not called a sysctrl at all in the datasheet then?

It is OK to use hisilicon,hi3519-sysctrl.

I thought syscon was more commonly used as abbr. of system-controller in the kernel code.

> 	Arnd
> 
> .
> 

WARNING: multiple messages have this Message-ID (diff)
From: xuejiancheng <xuejiancheng-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
To: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	pawel.moll-5wv7dgnIgG8@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
	galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org,
	khilman-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org,
	xuwei5-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org,
	haojian.zhuang-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	bintian.wang-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
	suwenping-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	yanhaifeng-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org,
	gaofei-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org,
	ml.yang-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org,
	yanghongwei-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org
Subject: Re: [PATCH v2 4/9] ARM: dts: add dts files for hi3519-demb board
Date: Thu, 10 Dec 2015 16:59:14 +0800	[thread overview]
Message-ID: <56693EE2.20501@huawei.com> (raw)
In-Reply-To: <2721289.3GUub5trUg@wuerfel>



On 2015/12/10 16:04, Arnd Bergmann wrote:
> On Thursday 10 December 2015 14:32:05 xuejiancheng wrote:
>>>
>>> This is not what I meant. You have to use "syscon" as the most generic
>>> "compatible" value here, but should add a machine specific string
>>> as a more specific one. "hisilicon,sysctrl" is not appropriate because
>>> it does not identify the IP block uniquely, you can only use that
>>> in combination with another more specific string.
>>
>> OK. I will use "hisilicon,hi3519-syscon" and "syscon" as the compatible value
>> for the sysctrl node in hi3519.dtsi.
>>
> 
> Why hisilicon,hi3519-syscon instead of hisilicon,hi3519-sysctrl?

> Is this not called a sysctrl at all in the datasheet then?

It is OK to use hisilicon,hi3519-sysctrl.

I thought syscon was more commonly used as abbr. of system-controller in the kernel code.

> 	Arnd
> 
> .
> 

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: xuejiancheng <xuejiancheng@huawei.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: <linux-arm-kernel@lists.infradead.org>, <robh+dt@kernel.org>,
	<pawel.moll@arm.com>, <mark.rutland@arm.com>,
	<ijc+devicetree@hellion.org.uk>, <galak@codeaurora.org>,
	<linux@arm.linux.org.uk>, <khilman@linaro.org>, <olof@lixom.net>,
	<xuwei5@hisilicon.com>, <haojian.zhuang@linaro.org>,
	<zhangfei.gao@linaro.org>, <bintian.wang@huawei.com>,
	<suwenping@hisilicon.com>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <yanhaifeng@hisilicon.com>,
	<gaofei@hisilicon.com>, <ml.yang@hisilicon.com>,
	<yanghongwei@hisilicon.com>
Subject: Re: [PATCH v2 4/9] ARM: dts: add dts files for hi3519-demb board
Date: Thu, 10 Dec 2015 16:59:14 +0800	[thread overview]
Message-ID: <56693EE2.20501@huawei.com> (raw)
In-Reply-To: <2721289.3GUub5trUg@wuerfel>



On 2015/12/10 16:04, Arnd Bergmann wrote:
> On Thursday 10 December 2015 14:32:05 xuejiancheng wrote:
>>>
>>> This is not what I meant. You have to use "syscon" as the most generic
>>> "compatible" value here, but should add a machine specific string
>>> as a more specific one. "hisilicon,sysctrl" is not appropriate because
>>> it does not identify the IP block uniquely, you can only use that
>>> in combination with another more specific string.
>>
>> OK. I will use "hisilicon,hi3519-syscon" and "syscon" as the compatible value
>> for the sysctrl node in hi3519.dtsi.
>>
> 
> Why hisilicon,hi3519-syscon instead of hisilicon,hi3519-sysctrl?

> Is this not called a sysctrl at all in the datasheet then?

It is OK to use hisilicon,hi3519-sysctrl.

I thought syscon was more commonly used as abbr. of system-controller in the kernel code.

> 	Arnd
> 
> .
> 


  reply	other threads:[~2015-12-10  8:59 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-03  2:44 [PATCH v2 4/9] ARM: dts: add dts files for hi3519-demb board Jiancheng Xue
2015-12-03  2:44 ` Jiancheng Xue
2015-12-03  2:44 ` Jiancheng Xue
2015-12-03  9:36 ` Arnd Bergmann
2015-12-03  9:36   ` Arnd Bergmann
2015-12-03  9:36   ` Arnd Bergmann
2015-12-04  2:27   ` xuejiancheng
2015-12-04  2:27     ` xuejiancheng
2015-12-04  2:27     ` xuejiancheng
2015-12-04 10:49     ` Arnd Bergmann
2015-12-04 10:49       ` Arnd Bergmann
2015-12-07  6:37       ` xuejiancheng
2015-12-07  6:37         ` xuejiancheng
2015-12-07  6:37         ` xuejiancheng
2015-12-08  3:28         ` zhangfei
2015-12-08  3:28           ` zhangfei
2015-12-08  3:28           ` zhangfei
2015-12-08  3:54         ` xuejiancheng
2015-12-08  3:54           ` xuejiancheng
2015-12-08  3:54           ` xuejiancheng
2015-12-09 15:31           ` Arnd Bergmann
2015-12-09 15:31             ` Arnd Bergmann
2015-12-10  6:32             ` xuejiancheng
2015-12-10  6:32               ` xuejiancheng
2015-12-10  6:32               ` xuejiancheng
2015-12-10  8:04               ` Arnd Bergmann
2015-12-10  8:04                 ` Arnd Bergmann
2015-12-10  8:59                 ` xuejiancheng [this message]
2015-12-10  8:59                   ` xuejiancheng
2015-12-10  8:59                   ` xuejiancheng
2015-12-10  9:13                   ` Arnd Bergmann
2015-12-10  9:13                     ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56693EE2.20501@huawei.com \
    --to=xuejiancheng@huawei.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.