Re: [PATCH v2 1/2] usb: renesas_usbhs: add fallback compatibility strings

[Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>]

Hello.

On 12/10/2015 8:40 AM, Simon Horman wrote:

> Add fallback compatibility strings for R-Car Gen2 and Gen3.
> This is in keeping with the fallback scheme being adopted wherever
> appropriate for drivers for Renesas SoCs.
>
> Also add SoC names.
>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
> v2
> * Add R-Car Gen2 and Gen3 fallback compatibility strings rather than
>    a single compatibility string for all of R-Car.
> ---
>   .../devicetree/bindings/usb/renesas_usbhs.txt          | 18 +++++++++++++-----
>   drivers/usb/renesas_usbhs/common.c                     |  9 +++++++++
>   2 files changed, 22 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> index 7d48f63db44e..b959059826cd 100644
> --- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> +++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
[...]
> @@ -22,7 +30,7 @@ Optional properties:
>
>   Example:
>   	usbhs: usb@e6590000 {
> -		compatible = "renesas,usbhs-r8a7790";
> +		compatible = "renesas,usbhs-r8a7790", "renesas,rcar-usbhs";

    You forgot "gen2-" here.

[...]

MBR, Sergei