From: Andrew Price <anprice@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] mkfs.gfs2: Always validate the locktable option
Date: Thu, 10 Dec 2015 14:19:55 +0000 [thread overview]
Message-ID: <56698A0B.1010609@redhat.com> (raw)
In-Reply-To: <2007062394.31800161.1449753620789.JavaMail.zimbra@redhat.com>
Hi Bob,
On 10/12/15 13:20, Bob Peterson wrote:
> Hi Andy,
>
> The patch looks good. The only thing that caught my eye was that
> this statement looks kinda messy and could use a few more parentheses:
>
> (snip)
>> + if (strcmp(opts->lockproto, "lock_nolock") != 0 && !table_required)
>
> The logic looks right, but I usually add more parens than necessary, for clarity.
Fair point. Changed and pushed.
Thanks!
Andy
prev parent reply other threads:[~2015-12-10 14:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-10 13:05 [Cluster-devel] [PATCH] mkfs.gfs2: Always validate the locktable option Andrew Price
2015-12-10 13:20 ` Bob Peterson
2015-12-10 14:19 ` Andrew Price [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56698A0B.1010609@redhat.com \
--to=anprice@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.