[PATCH libibcm] cmpost.c: Handle ibv_get_device_list returning no IB devices in init()

[PATCH libibcm] cmpost.c: Handle ibv_get_device_list returning no IB devices in init()

[Hal Rosenstock]

Also, print message when init fails

Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
diff --git a/examples/cmpost.c b/examples/cmpost.c
index 1b0edf8..f7833f5 100644
--- a/examples/cmpost.c
+++ b/examples/cmpost.c
@@ -447,6 +447,8 @@ static int init(void)
 	test.disconnects_left = connections;
 
 	dev_list = ibv_get_device_list(NULL);
+	if (!dev_list)
+		return -1;
 	test.device = dev_list[0];
 	if (!test.device)
 		return -1;
@@ -756,8 +758,10 @@ int main(int argc, char **argv)
 	}
 
 	is_server = (argc == 1);
-	if (init())
+	if (init()) {
+		printf("init failed\n");
 		exit(1);
+	}
 
 	if (is_server)
 		run_server();
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH libibcm] cmpost.c: Handle ibv_get_device_list returning no IB devices in init()

[Hefty, Sean]

Merged - thanks.

This is the first patch against the libibcm in over 4 years.  Is there a reason why this is being used instead of the librdmacm?  I ask because I assumed that the libibcm was basically deprecated.  The last release was over 6 years ago.

- Sean

Re: [PATCH libibcm] cmpost.c: Handle ibv_get_device_list returning no IB devices in init()

[Hal Rosenstock]

On 11/5/2015 7:46 PM, Hefty, Sean wrote:
> Merged - thanks.
> 
> This is the first patch against the libibcm in over 4 years.  Is there a reason why this is being used instead of the librdmacm?  I ask because I assumed that the libibcm was basically deprecated.  The last release was over 6 years ago.

I started trying to use this test program to try to reproduce a CM bug.
More to follow after some additional verification.

-- Hal

> - Sean
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH libibcm] cmpost.c: Handle ibv_get_device_list returning no IB devices in init()

[Doug Ledford]

[-- Attachment #1: Type: text/plain, Size: 616 bytes --]

On 11/05/2015 12:46 PM, Hefty, Sean wrote:
> Merged - thanks.
> 
> This is the first patch against the libibcm in over 4 years.  Is there a reason why this is being used instead of the librdmacm?  I ask because I assumed that the libibcm was basically deprecated.  The last release was over 6 years ago.

Not to mention the fact that libibcm is completely lacking all
documentation if I recall correctly.  No man pages or anything like
that.  We've considered it deprecated for quite some time.


-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
              GPG KeyID: 0E572FDD



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]