From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>,
linux-media@vger.kernel.org, linux-sh@vger.kernel.org
Cc: magnus.damm@gmail.com, laurent.pinchart@ideasonboard.com,
hans.verkuil@cisco.com, ian.molton@codethink.co.uk,
lars@metafoo.de, william.towle@codethink.co.uk
Subject: Re: [PATCH 3/3] media: adv7604: update timings on change of input signal
Date: Fri, 11 Dec 2015 18:15:18 +0000 [thread overview]
Message-ID: <566B12B6.6020408@cogentembedded.com> (raw)
In-Reply-To: <1449849893-14865-4-git-send-email-ulrich.hecht+renesas@gmail.com>
Hello.
On 12/11/2015 07:04 PM, Ulrich Hecht wrote:
> Without this, g_crop will always return the boot-time state.
>
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> ---
> drivers/media/i2c/adv7604.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/media/i2c/adv7604.c b/drivers/media/i2c/adv7604.c
> index 1bfa9f3..d7d0bb7 100644
> --- a/drivers/media/i2c/adv7604.c
> +++ b/drivers/media/i2c/adv7604.c
> @@ -1975,6 +1975,15 @@ static int adv76xx_isr(struct v4l2_subdev *sd, u32 status, bool *handled)
>
> v4l2_subdev_notify_event(sd, &adv76xx_ev_fmt);
>
> + /* update timings */
> + if (adv76xx_query_dv_timings(sd, &state->timings)
> + = -ENOLINK) {
Please don't put the binary operators on the continuation line, leave them
at the end of he broken up line.
[...]
MBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>,
linux-media@vger.kernel.org, linux-sh@vger.kernel.org
Cc: magnus.damm@gmail.com, laurent.pinchart@ideasonboard.com,
hans.verkuil@cisco.com, ian.molton@codethink.co.uk,
lars@metafoo.de, william.towle@codethink.co.uk
Subject: Re: [PATCH 3/3] media: adv7604: update timings on change of input signal
Date: Fri, 11 Dec 2015 21:15:18 +0300 [thread overview]
Message-ID: <566B12B6.6020408@cogentembedded.com> (raw)
In-Reply-To: <1449849893-14865-4-git-send-email-ulrich.hecht+renesas@gmail.com>
Hello.
On 12/11/2015 07:04 PM, Ulrich Hecht wrote:
> Without this, g_crop will always return the boot-time state.
>
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> ---
> drivers/media/i2c/adv7604.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/media/i2c/adv7604.c b/drivers/media/i2c/adv7604.c
> index 1bfa9f3..d7d0bb7 100644
> --- a/drivers/media/i2c/adv7604.c
> +++ b/drivers/media/i2c/adv7604.c
> @@ -1975,6 +1975,15 @@ static int adv76xx_isr(struct v4l2_subdev *sd, u32 status, bool *handled)
>
> v4l2_subdev_notify_event(sd, &adv76xx_ev_fmt);
>
> + /* update timings */
> + if (adv76xx_query_dv_timings(sd, &state->timings)
> + == -ENOLINK) {
Please don't put the binary operators on the continuation line, leave them
at the end of he broken up line.
[...]
MBR, Sergei
next prev parent reply other threads:[~2015-12-11 18:15 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-11 16:04 [PATCH 0/3] adv7604: .g_crop and .cropcap support Ulrich Hecht
2015-12-11 16:04 ` Ulrich Hecht
2015-12-11 16:04 ` [PATCH 1/3] media: adv7604: implement g_crop Ulrich Hecht
2015-12-11 16:04 ` Ulrich Hecht
2015-12-13 18:18 ` Laurent Pinchart
2015-12-13 18:18 ` Laurent Pinchart
2015-12-11 16:04 ` [PATCH 2/3] media: adv7604: implement cropcap Ulrich Hecht
2015-12-11 16:04 ` Ulrich Hecht
2015-12-13 18:22 ` Laurent Pinchart
2015-12-13 18:22 ` Laurent Pinchart
2015-12-11 16:04 ` [PATCH 3/3] media: adv7604: update timings on change of input signal Ulrich Hecht
2015-12-11 16:04 ` Ulrich Hecht
2015-12-11 18:15 ` Sergei Shtylyov [this message]
2015-12-11 18:15 ` Sergei Shtylyov
2015-12-13 18:30 ` Laurent Pinchart
2015-12-13 18:30 ` Laurent Pinchart
2015-12-11 16:25 ` [PATCH 0/3] adv7604: .g_crop and .cropcap support Hans Verkuil
2015-12-11 16:25 ` Hans Verkuil
2015-12-13 18:10 ` Laurent Pinchart
2015-12-13 18:10 ` Laurent Pinchart
2015-12-14 10:34 ` Hans Verkuil
2015-12-14 10:34 ` Hans Verkuil
2015-12-14 10:33 ` Hans Verkuil
2015-12-14 10:33 ` Hans Verkuil
2015-12-14 12:55 ` Ulrich Hecht
2015-12-14 12:55 ` Ulrich Hecht
2015-12-14 13:02 ` Hans Verkuil
2015-12-14 13:02 ` Hans Verkuil
2015-12-14 15:41 ` Ulrich Hecht
2015-12-14 15:41 ` Ulrich Hecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566B12B6.6020408@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=hans.verkuil@cisco.com \
--cc=ian.molton@codethink.co.uk \
--cc=lars@metafoo.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=ulrich.hecht+renesas@gmail.com \
--cc=william.towle@codethink.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.