From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, yashi@atmark-techno.com,
linux-sh@vger.kernel.org
Subject: Re: [PATCH v3] sh_eth: fix kernel oops in skb_put()
Date: Sat, 12 Dec 2015 15:17:45 +0000 [thread overview]
Message-ID: <566C3A99.2000103@cogentembedded.com> (raw)
In-Reply-To: <20151205.174648.1064779484509050839.davem@davemloft.net>
Hello.
On 12/6/2015 1:46 AM, David Miller wrote:
>> In a low memory situation the following kernel oops occurs:
>>
>> Unable to handle kernel NULL pointer dereference at virtual address 00000050
>> pgd = 8490c000
>> [00000050] *pgdF51e831, *pte\0000000, *ppte\0000000
>> Internal error: Oops: 17 [#1] PREEMPT ARM
>> Modules linked in:
>> CPU: 0 Not tainted (3.4-at16 #9)
>> PC is at skb_put+0x10/0x98
>> LR is at sh_eth_poll+0x2c8/0xa10
>> pc : [<8035f780>] lr : [<8028bf50>] psr: 60000113
>> sp : 84eb1a90 ip : 84eb1ac8 fp : 84eb1ac4
>> r10: 0000003f r9 : 000005ea r8 : 00000000
>> r7 : 00000000 r6 : 940453b0 r5 : 00030000 r4 : 9381b180
>> r3 : 00000000 r2 : 00000000 r1 : 000005ea r0 : 00000000
>> Flags: nZCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment user
>> Control: 10c53c7d Table: 4248c059 DAC: 00000015
>> Process klogd (pid: 2046, stack limit = 0x84eb02e8)
>> [...]
>>
>> This is because netdev_alloc_skb() fails and 'mdp->rx_skbuff[entry]' is left
>> NULL but sh_eth_rx() later uses it without checking. Add such check...
>>
>> Reported-by: Yasushi SHOJI <yashi@atmark-techno.com>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Applied.
Could you also queue this for the stable kernels?
MBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, yashi@atmark-techno.com,
linux-sh@vger.kernel.org
Subject: Re: [PATCH v3] sh_eth: fix kernel oops in skb_put()
Date: Sat, 12 Dec 2015 18:17:45 +0300 [thread overview]
Message-ID: <566C3A99.2000103@cogentembedded.com> (raw)
In-Reply-To: <20151205.174648.1064779484509050839.davem@davemloft.net>
Hello.
On 12/6/2015 1:46 AM, David Miller wrote:
>> In a low memory situation the following kernel oops occurs:
>>
>> Unable to handle kernel NULL pointer dereference at virtual address 00000050
>> pgd = 8490c000
>> [00000050] *pgd=4651e831, *pte=00000000, *ppte=00000000
>> Internal error: Oops: 17 [#1] PREEMPT ARM
>> Modules linked in:
>> CPU: 0 Not tainted (3.4-at16 #9)
>> PC is at skb_put+0x10/0x98
>> LR is at sh_eth_poll+0x2c8/0xa10
>> pc : [<8035f780>] lr : [<8028bf50>] psr: 60000113
>> sp : 84eb1a90 ip : 84eb1ac8 fp : 84eb1ac4
>> r10: 0000003f r9 : 000005ea r8 : 00000000
>> r7 : 00000000 r6 : 940453b0 r5 : 00030000 r4 : 9381b180
>> r3 : 00000000 r2 : 00000000 r1 : 000005ea r0 : 00000000
>> Flags: nZCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment user
>> Control: 10c53c7d Table: 4248c059 DAC: 00000015
>> Process klogd (pid: 2046, stack limit = 0x84eb02e8)
>> [...]
>>
>> This is because netdev_alloc_skb() fails and 'mdp->rx_skbuff[entry]' is left
>> NULL but sh_eth_rx() later uses it without checking. Add such check...
>>
>> Reported-by: Yasushi SHOJI <yashi@atmark-techno.com>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Applied.
Could you also queue this for the stable kernels?
MBR, Sergei
next prev parent reply other threads:[~2015-12-12 15:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-03 22:45 [PATCH v3] sh_eth: fix kernel oops in skb_put() Sergei Shtylyov
2015-12-03 22:45 ` Sergei Shtylyov
2015-12-05 22:46 ` David Miller
2015-12-05 22:46 ` David Miller
2015-12-12 15:17 ` Sergei Shtylyov [this message]
2015-12-12 15:17 ` Sergei Shtylyov
2015-12-14 21:24 ` David Miller
2015-12-14 21:24 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566C3A99.2000103@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=linux-sh@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yashi@atmark-techno.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.