All of lore.kernel.org
 help / color / mirror / Atom feed
From: dcashman@android.com (Daniel Cashman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 3/4] arm64: mm: support ARCH_MMAP_RND_BITS.
Date: Mon, 14 Dec 2015 12:45:17 -0800	[thread overview]
Message-ID: <566F2A5D.6010100@android.com> (raw)
In-Reply-To: <20151214111949.GD6992@arm.com>

On 12/14/2015 03:19 AM, Will Deacon wrote:
>> +# max bits determined by the following formula:
>> +#  VA_BITS - PAGE_SHIFT - 3
> 
> Now that we have this comment, I think we can drop the unsupported
> combinations from the list below. That means we just end up with:
> 
>> +config ARCH_MMAP_RND_BITS_MAX
>> +       default 19 if ARM64_VA_BITS=36
>> +       default 24 if ARM64_VA_BITS=39
>> +       default 27 if ARM64_VA_BITS=42
>> +       default 30 if ARM64_VA_BITS=47
>> +       default 29 if ARM64_VA_BITS=48 && ARM64_64K_PAGES
>> +       default 31 if ARM64_VA_BITS=48 && ARM64_16K_PAGES
>> +       default 33 if ARM64_VA_BITS=48

Unless you object, I'd like to keep the last 3 as well, to mirror the
min bits, should any new configurations be added but not reflected here:
+       default 15 if ARM64_64K_PAGES
+       default 17 if ARM64_16K_PAGES
+       default 18

The first two of these three should be changed as well to 14 and 16.

Thanks,
Dan

WARNING: multiple messages have this Message-ID (diff)
From: Daniel Cashman <dcashman@android.com>
To: Will Deacon <will.deacon@arm.com>
Cc: linux-kernel@vger.kernel.org, linux@arm.linux.org.uk,
	akpm@linux-foundation.org, keescook@chromium.org,
	mingo@kernel.org, linux-arm-kernel@lists.infradead.org,
	corbet@lwn.net, dzickus@redhat.com, ebiederm@xmission.com,
	xypron.glpk@gmx.de, jpoimboe@redhat.com,
	kirill.shutemov@linux.intel.com, n-horiguchi@ah.jp.nec.com,
	aarcange@redhat.com, mgorman@suse.de, tglx@linutronix.de,
	rientjes@google.com, linux-mm@kvack.org,
	linux-doc@vger.kernel.org, salyzyn@android.com, jeffv@google.com,
	nnk@google.com, catalin.marinas@arm.com, hpa@zytor.com,
	x86@kernel.org, hecmargi@upv.es, bp@suse.de, dcashman@google.com,
	arnd@arndb.de, jonathanh@nvidia.com
Subject: Re: [PATCH v6 3/4] arm64: mm: support ARCH_MMAP_RND_BITS.
Date: Mon, 14 Dec 2015 12:45:17 -0800	[thread overview]
Message-ID: <566F2A5D.6010100@android.com> (raw)
In-Reply-To: <20151214111949.GD6992@arm.com>

On 12/14/2015 03:19 AM, Will Deacon wrote:
>> +# max bits determined by the following formula:
>> +#  VA_BITS - PAGE_SHIFT - 3
> 
> Now that we have this comment, I think we can drop the unsupported
> combinations from the list below. That means we just end up with:
> 
>> +config ARCH_MMAP_RND_BITS_MAX
>> +       default 19 if ARM64_VA_BITS=36
>> +       default 24 if ARM64_VA_BITS=39
>> +       default 27 if ARM64_VA_BITS=42
>> +       default 30 if ARM64_VA_BITS=47
>> +       default 29 if ARM64_VA_BITS=48 && ARM64_64K_PAGES
>> +       default 31 if ARM64_VA_BITS=48 && ARM64_16K_PAGES
>> +       default 33 if ARM64_VA_BITS=48

Unless you object, I'd like to keep the last 3 as well, to mirror the
min bits, should any new configurations be added but not reflected here:
+       default 15 if ARM64_64K_PAGES
+       default 17 if ARM64_16K_PAGES
+       default 18

The first two of these three should be changed as well to 14 and 16.

Thanks,
Dan

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Daniel Cashman <dcashman@android.com>
To: Will Deacon <will.deacon@arm.com>
Cc: linux-kernel@vger.kernel.org, linux@arm.linux.org.uk,
	akpm@linux-foundation.org, keescook@chromium.org,
	mingo@kernel.org, linux-arm-kernel@lists.infradead.org,
	corbet@lwn.net, dzickus@redhat.com, ebiederm@xmission.com,
	xypron.glpk@gmx.de, jpoimboe@redhat.com,
	kirill.shutemov@linux.intel.com, n-horiguchi@ah.jp.nec.com,
	aarcange@redhat.com, mgorman@suse.de, tglx@linutronix.de,
	rientjes@google.com, linux-mm@kvack.org,
	linux-doc@vger.kernel.org, salyzyn@android.com, jeffv@google.com,
	nnk@google.com, catalin.marinas@arm.com, hpa@zytor.com,
	x86@kernel.org, hecmargi@upv.es, bp@suse.de, dcashman@google.com,
	arnd@arndb.de, jonathanh@nvidia.com
Subject: Re: [PATCH v6 3/4] arm64: mm: support ARCH_MMAP_RND_BITS.
Date: Mon, 14 Dec 2015 12:45:17 -0800	[thread overview]
Message-ID: <566F2A5D.6010100@android.com> (raw)
In-Reply-To: <20151214111949.GD6992@arm.com>

On 12/14/2015 03:19 AM, Will Deacon wrote:
>> +# max bits determined by the following formula:
>> +#  VA_BITS - PAGE_SHIFT - 3
> 
> Now that we have this comment, I think we can drop the unsupported
> combinations from the list below. That means we just end up with:
> 
>> +config ARCH_MMAP_RND_BITS_MAX
>> +       default 19 if ARM64_VA_BITS=36
>> +       default 24 if ARM64_VA_BITS=39
>> +       default 27 if ARM64_VA_BITS=42
>> +       default 30 if ARM64_VA_BITS=47
>> +       default 29 if ARM64_VA_BITS=48 && ARM64_64K_PAGES
>> +       default 31 if ARM64_VA_BITS=48 && ARM64_16K_PAGES
>> +       default 33 if ARM64_VA_BITS=48

Unless you object, I'd like to keep the last 3 as well, to mirror the
min bits, should any new configurations be added but not reflected here:
+       default 15 if ARM64_64K_PAGES
+       default 17 if ARM64_16K_PAGES
+       default 18

The first two of these three should be changed as well to 14 and 16.

Thanks,
Dan

  reply	other threads:[~2015-12-14 20:45 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-11 17:52 [PATCH v6 0/4] Allow customizable random offset to mmap_base address Daniel Cashman
2015-12-11 17:52 ` Daniel Cashman
2015-12-11 17:52 ` Daniel Cashman
2015-12-11 17:52 ` [PATCH v6 1/4] mm: mmap: Add new /proc tunable for mmap_base ASLR Daniel Cashman
2015-12-11 17:52   ` Daniel Cashman
2015-12-11 17:52   ` Daniel Cashman
2015-12-11 17:52   ` [PATCH v6 2/4] arm: mm: support ARCH_MMAP_RND_BITS Daniel Cashman
2015-12-11 17:52     ` Daniel Cashman
2015-12-11 17:52     ` Daniel Cashman
2015-12-11 17:52     ` [PATCH v6 3/4] arm64: " Daniel Cashman
2015-12-11 17:52       ` Daniel Cashman
2015-12-11 17:52       ` Daniel Cashman
2015-12-11 17:52       ` [PATCH v6 4/4] x86: " Daniel Cashman
2015-12-11 17:52         ` Daniel Cashman
2015-12-11 17:52         ` Daniel Cashman
2015-12-14 18:58         ` H. Peter Anvin
2015-12-14 18:58           ` H. Peter Anvin
2015-12-14 18:58           ` H. Peter Anvin
2015-12-14 20:51           ` Daniel Cashman
2015-12-14 20:51             ` Daniel Cashman
2015-12-14 20:51             ` Daniel Cashman
2015-12-14 11:19       ` [PATCH v6 3/4] arm64: " Will Deacon
2015-12-14 11:19         ` Will Deacon
2015-12-14 11:19         ` Will Deacon
2015-12-14 20:45         ` Daniel Cashman [this message]
2015-12-14 20:45           ` Daniel Cashman
2015-12-14 20:45           ` Daniel Cashman
2015-12-11 21:02 ` [PATCH v6 0/4] Allow customizable random offset to mmap_base address Kees Cook
2015-12-11 21:02   ` Kees Cook
2015-12-11 21:02   ` Kees Cook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=566F2A5D.6010100@android.com \
    --to=dcashman@android.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.