From: Shannon Zhao <shannon.zhao@linaro.org>
To: Marc Zyngier <marc.zyngier@arm.com>,
Shannon Zhao <zhaoshenglong@huawei.com>,
kvmarm@lists.cs.columbia.edu, christoffer.dall@linaro.org
Cc: kvm@vger.kernel.org, will.deacon@arm.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v7 01/19] ARM64: Move PMU register related defines to asm/pmu.h
Date: Tue, 15 Dec 2015 19:44:56 +0800 [thread overview]
Message-ID: <566FFD38.7060803@linaro.org> (raw)
In-Reply-To: <566FFAB6.8060604@arm.com>
On 2015/12/15 19:34, Marc Zyngier wrote:
> On 15/12/15 08:49, Shannon Zhao wrote:
>> From: Shannon Zhao <shannon.zhao@linaro.org>
>>
>> To use the ARMv8 PMU related register defines from the KVM code,
>> we move the relevant definitions to asm/pmu.h header file.
>>
>> Signed-off-by: Anup Patel <anup.patel@linaro.org>
>> Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
>> ---
>> arch/arm64/include/asm/pmu.h | 64 ++++++++++++++++++++++++++++++++++++++++++
>> arch/arm64/kernel/perf_event.c | 36 +-----------------------
>> 2 files changed, 65 insertions(+), 35 deletions(-)
>> create mode 100644 arch/arm64/include/asm/pmu.h
>>
>> diff --git a/arch/arm64/include/asm/pmu.h b/arch/arm64/include/asm/pmu.h
>> new file mode 100644
>> index 0000000..4264ea0
>> --- /dev/null
>> +++ b/arch/arm64/include/asm/pmu.h
>> @@ -0,0 +1,64 @@
>> +/*
>> + * Copyright (C) 2015 Linaro Ltd, Shannon Zhao
>
> Erm, not quite. You're simply moving existing code from one file to
> another. That doesn't change the copyright of said code, which reads:
>
> * PMU support
> *
> * Copyright (C) 2012 ARM Limited
> * Author: Will Deacon <will.deacon@arm.com>
>
> Please keep this mention in place.
>
Sure, will fix this. Thanks.
--
Shannon
WARNING: multiple messages have this Message-ID (diff)
From: shannon.zhao@linaro.org (Shannon Zhao)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 01/19] ARM64: Move PMU register related defines to asm/pmu.h
Date: Tue, 15 Dec 2015 19:44:56 +0800 [thread overview]
Message-ID: <566FFD38.7060803@linaro.org> (raw)
In-Reply-To: <566FFAB6.8060604@arm.com>
On 2015/12/15 19:34, Marc Zyngier wrote:
> On 15/12/15 08:49, Shannon Zhao wrote:
>> From: Shannon Zhao <shannon.zhao@linaro.org>
>>
>> To use the ARMv8 PMU related register defines from the KVM code,
>> we move the relevant definitions to asm/pmu.h header file.
>>
>> Signed-off-by: Anup Patel <anup.patel@linaro.org>
>> Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
>> ---
>> arch/arm64/include/asm/pmu.h | 64 ++++++++++++++++++++++++++++++++++++++++++
>> arch/arm64/kernel/perf_event.c | 36 +-----------------------
>> 2 files changed, 65 insertions(+), 35 deletions(-)
>> create mode 100644 arch/arm64/include/asm/pmu.h
>>
>> diff --git a/arch/arm64/include/asm/pmu.h b/arch/arm64/include/asm/pmu.h
>> new file mode 100644
>> index 0000000..4264ea0
>> --- /dev/null
>> +++ b/arch/arm64/include/asm/pmu.h
>> @@ -0,0 +1,64 @@
>> +/*
>> + * Copyright (C) 2015 Linaro Ltd, Shannon Zhao
>
> Erm, not quite. You're simply moving existing code from one file to
> another. That doesn't change the copyright of said code, which reads:
>
> * PMU support
> *
> * Copyright (C) 2012 ARM Limited
> * Author: Will Deacon <will.deacon@arm.com>
>
> Please keep this mention in place.
>
Sure, will fix this. Thanks.
--
Shannon
next prev parent reply other threads:[~2015-12-15 11:42 UTC|newest]
Thread overview: 135+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-15 8:49 [PATCH v7 00/19] KVM: ARM64: Add guest PMU support Shannon Zhao
2015-12-15 8:49 ` Shannon Zhao
2015-12-15 8:49 ` Shannon Zhao
2015-12-15 8:49 ` [PATCH v7 01/19] ARM64: Move PMU register related defines to asm/pmu.h Shannon Zhao
2015-12-15 8:49 ` Shannon Zhao
2015-12-15 8:49 ` Shannon Zhao
2015-12-15 11:34 ` Marc Zyngier
2015-12-15 11:34 ` Marc Zyngier
2015-12-15 11:44 ` Shannon Zhao [this message]
2015-12-15 11:44 ` Shannon Zhao
2015-12-15 8:49 ` [PATCH v7 02/19] KVM: ARM64: Define PMU data structure for each vcpu Shannon Zhao
2015-12-15 8:49 ` Shannon Zhao
2015-12-15 8:49 ` Shannon Zhao
2015-12-15 8:49 ` [PATCH v7 03/19] KVM: ARM64: Add offset defines for PMU registers Shannon Zhao
2015-12-15 8:49 ` Shannon Zhao
2015-12-15 8:49 ` Shannon Zhao
2015-12-15 8:49 ` [PATCH v7 04/19] KVM: ARM64: Add access handler for PMCR register Shannon Zhao
2015-12-15 8:49 ` Shannon Zhao
2015-12-15 8:49 ` Shannon Zhao
2015-12-15 8:49 ` [PATCH v7 05/19] KVM: ARM64: Add access handler for PMSELR register Shannon Zhao
2015-12-15 8:49 ` Shannon Zhao
2015-12-15 8:49 ` Shannon Zhao
2015-12-15 8:49 ` [PATCH v7 06/19] KVM: ARM64: Add access handler for PMCEID0 and PMCEID1 register Shannon Zhao
2015-12-15 8:49 ` Shannon Zhao
2015-12-15 8:49 ` Shannon Zhao
2015-12-15 14:20 ` Marc Zyngier
2015-12-15 14:20 ` Marc Zyngier
2015-12-15 8:49 ` [PATCH v7 07/19] KVM: ARM64: PMU: Add perf event map and introduce perf event creating function Shannon Zhao
2015-12-15 8:49 ` Shannon Zhao
2015-12-15 8:49 ` Shannon Zhao
2015-12-17 15:22 ` Mark Rutland
2015-12-17 15:22 ` Mark Rutland
2015-12-17 15:30 ` Marc Zyngier
2015-12-17 15:30 ` Marc Zyngier
2015-12-15 8:49 ` [PATCH v7 08/19] KVM: ARM64: Add access handler for event typer register Shannon Zhao
2015-12-15 8:49 ` Shannon Zhao
2015-12-15 8:49 ` Shannon Zhao
2015-12-15 13:43 ` Marc Zyngier
2015-12-15 13:43 ` Marc Zyngier
2015-12-15 14:26 ` Marc Zyngier
2015-12-15 14:26 ` Marc Zyngier
2015-12-15 8:49 ` [PATCH v7 09/19] KVM: ARM64: Add access handler for event counter register Shannon Zhao
2015-12-15 8:49 ` Shannon Zhao
2015-12-15 8:49 ` Shannon Zhao
2015-12-15 13:44 ` Marc Zyngier
2015-12-15 13:44 ` Marc Zyngier
2015-12-15 8:49 ` [PATCH v7 10/19] KVM: ARM64: Add access handler for PMCNTENSET and PMCNTENCLR register Shannon Zhao
2015-12-15 8:49 ` Shannon Zhao
2015-12-15 8:49 ` Shannon Zhao
2015-12-15 13:56 ` Marc Zyngier
2015-12-15 13:56 ` Marc Zyngier
2015-12-15 8:49 ` [PATCH v7 11/19] KVM: ARM64: Add access handler for PMINTENSET and PMINTENCLR register Shannon Zhao
2015-12-15 8:49 ` Shannon Zhao
2015-12-15 8:49 ` Shannon Zhao
2015-12-15 14:02 ` Marc Zyngier
2015-12-15 14:02 ` Marc Zyngier
2015-12-15 8:49 ` [PATCH v7 12/19] KVM: ARM64: Add access handler for PMOVSSET and PMOVSCLR register Shannon Zhao
2015-12-15 8:49 ` Shannon Zhao
2015-12-15 8:49 ` Shannon Zhao
2015-12-15 14:06 ` Marc Zyngier
2015-12-15 14:06 ` Marc Zyngier
2015-12-15 8:49 ` [PATCH v7 13/19] KVM: ARM64: Add access handler for PMSWINC register Shannon Zhao
2015-12-15 8:49 ` Shannon Zhao
2015-12-15 8:49 ` Shannon Zhao
2015-12-15 14:36 ` Marc Zyngier
2015-12-15 14:36 ` Marc Zyngier
2015-12-15 8:49 ` [PATCH v7 14/19] KVM: ARM64: Add helper to handle PMCR register bits Shannon Zhao
2015-12-15 8:49 ` Shannon Zhao
2015-12-15 8:49 ` Shannon Zhao
2015-12-15 8:49 ` [PATCH v7 15/19] KVM: ARM64: Add access handler for PMUSERENR register Shannon Zhao
2015-12-15 8:49 ` Shannon Zhao
2015-12-15 8:49 ` Shannon Zhao
2015-12-15 14:58 ` Marc Zyngier
2015-12-15 14:58 ` Marc Zyngier
2015-12-15 15:59 ` Shannon Zhao
2015-12-15 15:59 ` Shannon Zhao
2015-12-15 16:02 ` Marc Zyngier
2015-12-15 16:02 ` Marc Zyngier
2015-12-15 8:49 ` [PATCH v7 16/19] KVM: ARM64: Add PMU overflow interrupt routing Shannon Zhao
2015-12-15 8:49 ` Shannon Zhao
2015-12-15 8:49 ` Shannon Zhao
2015-12-15 15:19 ` Marc Zyngier
2015-12-15 15:19 ` Marc Zyngier
2015-12-15 8:49 ` [PATCH v7 17/19] KVM: ARM64: Reset PMU state when resetting vcpu Shannon Zhao
2015-12-15 8:49 ` Shannon Zhao
2015-12-15 8:49 ` Shannon Zhao
2015-12-15 8:49 ` [PATCH v7 18/19] KVM: ARM64: Free perf event of PMU when destroying vcpu Shannon Zhao
2015-12-15 8:49 ` Shannon Zhao
2015-12-15 8:49 ` Shannon Zhao
2015-12-15 8:49 ` [PATCH v7 19/19] KVM: ARM64: Add a new kvm ARM PMU device Shannon Zhao
2015-12-15 8:49 ` Shannon Zhao
2015-12-15 8:49 ` Shannon Zhao
2015-12-15 15:33 ` Marc Zyngier
2015-12-15 15:33 ` Marc Zyngier
2015-12-15 15:50 ` Shannon Zhao
2015-12-15 15:50 ` Shannon Zhao
2015-12-15 15:59 ` Marc Zyngier
2015-12-15 15:59 ` Marc Zyngier
2015-12-15 17:50 ` Andrew Jones
2015-12-15 17:50 ` [Qemu-devel] " Andrew Jones
2015-12-15 17:50 ` Andrew Jones
2015-12-15 20:47 ` Christoffer Dall
2015-12-15 20:47 ` Christoffer Dall
2015-12-16 7:31 ` Shannon Zhao
2015-12-16 7:31 ` Shannon Zhao
2015-12-16 7:31 ` Shannon Zhao
2015-12-16 8:06 ` Shannon Zhao
2015-12-16 8:06 ` Shannon Zhao
2015-12-16 9:04 ` Marc Zyngier
2015-12-16 9:04 ` Marc Zyngier
2015-12-16 9:29 ` Shannon Zhao
2015-12-16 9:29 ` Shannon Zhao
2015-12-16 9:29 ` Shannon Zhao
2015-12-16 20:33 ` Christoffer Dall
2015-12-16 20:33 ` Christoffer Dall
2015-12-17 7:22 ` Shannon Zhao
2015-12-17 7:22 ` Shannon Zhao
2015-12-17 7:22 ` Shannon Zhao
2015-12-17 8:33 ` Marc Zyngier
2015-12-17 8:33 ` Marc Zyngier
2015-12-17 8:33 ` Marc Zyngier
2015-12-17 8:41 ` Shannon Zhao
2015-12-17 8:41 ` Shannon Zhao
2015-12-17 8:41 ` Shannon Zhao
2015-12-17 9:38 ` Marc Zyngier
2015-12-17 9:38 ` Marc Zyngier
2015-12-17 10:10 ` Shannon Zhao
2015-12-17 10:10 ` Shannon Zhao
2015-12-17 10:10 ` Shannon Zhao
2015-12-17 10:38 ` Marc Zyngier
2015-12-17 10:38 ` Marc Zyngier
2015-12-18 10:00 ` Christoffer Dall
2015-12-18 10:00 ` Christoffer Dall
2015-12-15 15:41 ` [PATCH v7 00/19] KVM: ARM64: Add guest PMU support Marc Zyngier
2015-12-15 15:41 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566FFD38.7060803@linaro.org \
--to=shannon.zhao@linaro.org \
--cc=christoffer.dall@linaro.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=marc.zyngier@arm.com \
--cc=will.deacon@arm.com \
--cc=zhaoshenglong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.